Remove tests, benchmarks and alter transaction extension.

shamil-gadelshin · shamil-gadelshin · commit 53f574fe76c9 · 2025-09-02T14:10:41.000+03:00
diff --git a/common/src/lib.rs b/common/src/lib.rs
@@ -154,7 +154,7 @@ pub enum ProxyType {
     Registration,
     Transfer,
     SmallTransfer,
-    RootWeights,
+    RootWeights, // deprecated
     ChildKeys,
     SudoUncheckedSetCode,
     SwapHotkey,
diff --git a/pallets/subtensor/src/benchmarks.rs b/pallets/subtensor/src/benchmarks.rs
@@ -98,33 +98,6 @@ mod pallet_benchmarks {
         );
     }
 
-    #[benchmark]
-    fn become_delegate() {
-        let netuid = NetUid::from(1);
-        let tempo: u16 = 1;
-
-        Subtensor::<T>::init_new_network(netuid, tempo);
-        SubtokenEnabled::<T>::insert(netuid, true);
-        Subtensor::<T>::set_burn(netuid, 1.into());
-        Subtensor::<T>::set_max_allowed_uids(netuid, 4096);
-        Subtensor::<T>::set_network_registration_allowed(netuid, true);
-
-        let seed: u32 = 1;
-        let coldkey: T::AccountId = account("Test", 0, seed);
-        let hotkey: T::AccountId = account("Alice", 0, seed);
-        let amount_to_be_staked: u64 = 1_000_000_000;
-
-        Subtensor::<T>::add_balance_to_coldkey_account(&coldkey, amount_to_be_staked);
-        assert_ok!(Subtensor::<T>::do_burned_registration(
-            RawOrigin::Signed(coldkey.clone()).into(),
-            netuid,
-            hotkey.clone()
-        ));
-
-        #[extrinsic_call]
-        _(RawOrigin::Signed(coldkey.clone()), hotkey.clone());
-    }
-
     #[benchmark]
     fn add_stake() {
         let netuid = NetUid::from(1);
@@ -1280,27 +1253,6 @@ mod pallet_benchmarks {
         );
     }
 
-    #[benchmark]
-    fn set_tao_weights() {
-        let netuid = NetUid::from(1);
-        let hotkey: T::AccountId = account("A", 0, 6);
-        let dests = vec![0u16];
-        let weights = vec![0u16];
-        let version: u64 = 1;
-
-        Subtensor::<T>::init_new_network(netuid, 1);
-
-        #[extrinsic_call]
-        _(
-            RawOrigin::None,
-            netuid,
-            hotkey.clone(),
-            dests.clone(),
-            weights.clone(),
-            version,
-        );
-    }
-
     #[benchmark]
     fn swap_hotkey() {
         let coldkey: T::AccountId = whitelisted_caller();
diff --git a/pallets/subtensor/src/tests/weights.rs b/pallets/subtensor/src/tests/weights.rs
@@ -62,119 +62,6 @@ fn test_set_weights_dispatch_info_ok() {
     });
 }
 
-// SKIP_WASM_BUILD=1 RUST_LOG=debug cargo test --package pallet-subtensor --lib -- tests::weights::test_set_rootweights_validate --exact --show-output --nocapture
-#[test]
-fn test_set_rootweights_validate() {
-    // Testing the signed extension validate function
-    // correctly filters this transaction.
-
-    new_test_ext(0).execute_with(|| {
-        let dests = vec![1, 1];
-        let weights = vec![1, 1];
-        let netuid = NetUid::from(1);
-        let version_key: u64 = 0;
-        let coldkey = U256::from(0);
-        let hotkey: U256 = U256::from(1); // Add the hotkey field
-        assert_ne!(hotkey, coldkey); // Ensure hotkey is NOT the same as coldkey !!!
-        let fee: u64 = 0; // FIXME: DefaultStakingFee is deprecated
-
-        let who = coldkey; // The coldkey signs this transaction
-
-        let call = RuntimeCall::SubtensorModule(SubtensorCall::set_tao_weights {
-            netuid,
-            dests,
-            weights,
-            version_key,
-            hotkey, // Include the hotkey field
-        });
-
-        // Create netuid
-        add_network(netuid, 1, 0);
-        // Register the hotkey
-        SubtensorModule::append_neuron(netuid, &hotkey, 0);
-        crate::Owner::<Test>::insert(hotkey, coldkey);
-
-        SubtensorModule::add_balance_to_coldkey_account(&hotkey, u64::MAX);
-
-        let min_stake = TaoCurrency::from(500_000_000_000);
-        // Set the minimum stake
-        SubtensorModule::set_stake_threshold(min_stake.into());
-
-        // Verify stake is less than minimum
-        assert!(SubtensorModule::get_total_stake_for_hotkey(&hotkey) < min_stake);
-        let info: DispatchInfo =
-            DispatchInfoOf::<<Test as frame_system::Config>::RuntimeCall>::default();
-
-        let extension = SubtensorTransactionExtension::<Test>::new();
-        // Submit to the signed extension validate function
-        let result_no_stake = extension.validate(
-            RawOrigin::Signed(who).into(),
-            &call.clone(),
-            &info,
-            10,
-            (),
-            &TxBaseImplication(()),
-            TransactionSource::External,
-        );
-        // Should fail
-        assert_eq!(
-            // Should get an invalid transaction error
-            result_no_stake.unwrap_err(),
-            CustomTransactionError::StakeAmountTooLow.into()
-        );
-
-        // Increase the stake to be equal to the minimum
-        assert_ok!(SubtensorModule::do_add_stake(
-            RuntimeOrigin::signed(hotkey),
-            hotkey,
-            netuid,
-            min_stake + fee.into()
-        ));
-
-        // Verify stake is equal to minimum
-        assert_eq!(
-            SubtensorModule::get_total_stake_for_hotkey(&hotkey),
-            min_stake
-        );
-
-        // Submit to the signed extension validate function
-        let result_min_stake = extension.validate(
-            RawOrigin::Signed(who).into(),
-            &call.clone(),
-            &info,
-            10,
-            (),
-            &TxBaseImplication(()),
-            TransactionSource::External,
-        );
-        // Now the call should pass
-        assert_ok!(result_min_stake);
-
-        // Try with more stake than minimum
-        assert_ok!(SubtensorModule::do_add_stake(
-            RuntimeOrigin::signed(hotkey),
-            hotkey,
-            netuid,
-            DefaultMinStake::<Test>::get() * 10.into()
-        ));
-
-        // Verify stake is more than minimum
-        assert!(SubtensorModule::get_total_stake_for_hotkey(&hotkey) > min_stake);
-
-        let result_more_stake = extension.validate(
-            RawOrigin::Signed(who).into(),
-            &call.clone(),
-            &info,
-            10,
-            (),
-            &TxBaseImplication(()),
-            TransactionSource::External,
-        );
-        // The call should still pass
-        assert_ok!(result_more_stake);
-    });
-}
-
 // SKIP_WASM_BUILD=1 RUST_LOG=debug cargo test --package pallet-subtensor --lib -- tests::weights::test_commit_weights_dispatch_info_ok --exact --show-output --nocapture
 #[test]
 fn test_commit_weights_dispatch_info_ok() {
diff --git a/pallets/subtensor/src/transaction_extension.rs b/pallets/subtensor/src/transaction_extension.rs
@@ -223,13 +223,6 @@ where
                     Err(CustomTransactionError::StakeAmountTooLow.into())
                 }
             }
-            Some(Call::set_tao_weights { netuid, hotkey, .. }) => {
-                if Self::check_weights_min_stake(hotkey, *netuid) {
-                    Ok((Default::default(), Some(who.clone()), origin))
-                } else {
-                    Err(CustomTransactionError::StakeAmountTooLow.into())
-                }
-            }
             Some(Call::commit_crv3_weights {
                 netuid,
                 reveal_round,
diff --git a/runtime/src/lib.rs b/runtime/src/lib.rs
@@ -398,7 +398,6 @@ impl Contains<RuntimeCall> for SafeModeWhitelistedCalls {
                 | RuntimeCall::Timestamp(_)
                 | RuntimeCall::SubtensorModule(
                     pallet_subtensor::Call::set_weights { .. }
-                        | pallet_subtensor::Call::set_tao_weights { .. }
                         | pallet_subtensor::Call::serve_axon { .. }
                 )
                 | RuntimeCall::Commitments(pallet_commitments::Call::set_commitment { .. })
@@ -733,7 +732,6 @@ impl InstanceFilter<RuntimeCall> for ProxyType {
                     | RuntimeCall::SubtensorModule(pallet_subtensor::Call::root_register { .. })
                     | RuntimeCall::SubtensorModule(pallet_subtensor::Call::burned_register { .. })
                     | RuntimeCall::Triumvirate(..)
-                    | RuntimeCall::SubtensorModule(pallet_subtensor::Call::set_tao_weights { .. })
                     | RuntimeCall::Sudo(..)
             ),
             ProxyType::Triumvirate => matches!(
@@ -771,10 +769,7 @@ impl InstanceFilter<RuntimeCall> for ProxyType {
                 RuntimeCall::SubtensorModule(pallet_subtensor::Call::burned_register { .. })
                     | RuntimeCall::SubtensorModule(pallet_subtensor::Call::register { .. })
             ),
-            ProxyType::RootWeights => matches!(
-                c,
-                RuntimeCall::SubtensorModule(pallet_subtensor::Call::set_tao_weights { .. })
-            ),
+            ProxyType::RootWeights => false, // deprecated
             ProxyType::ChildKeys => matches!(
                 c,
                 RuntimeCall::SubtensorModule(pallet_subtensor::Call::set_children { .. })

Original file line number	Diff line number	Diff line change
`@@ -223,13 +223,6 @@ where`
`223`	`223`	`Err(CustomTransactionError::StakeAmountTooLow.into())`
`224`	`224`	`}`
`225`	`225`	`}`
`226`		`- Some(Call::set_tao_weights { netuid, hotkey, .. }) => {`
`227`		`- if Self::check_weights_min_stake(hotkey, *netuid) {`
`228`		`- Ok((Default::default(), Some(who.clone()), origin))`
`229`		`- } else {`
`230`		`- Err(CustomTransactionError::StakeAmountTooLow.into())`
`231`		`- }`
`232`		`- }`
`233`	`226`	`Some(Call::commit_crv3_weights {`
`234`	`227`	`netuid,`
`235`	`228`	`reveal_round,`