Merge pull request #2122 from opentensor/fix/ban-expect

Add linter rule to flag expect. Remove expects/allow exceptions.

Author: sam0x17

Cargo.toml

@@ -40,6 +40,7 @@ edition = "2024"
 
 [workspace.lints.clippy]
 arithmetic-side-effects = "deny"
+expect-used = "deny"
 indexing-slicing = "deny"
 manual_inspect = "allow"
 result_large_err = "allow"

node/src/benchmarking.rs

@@ -105,6 +105,7 @@ impl frame_benchmarking_cli::ExtrinsicBuilder for TransferKeepAliveBuilder {
 // Create a transaction using the given `call`.
 //
 // Note: Should only be used for benchmarking.
+#[allow(clippy::expect_used)]
 pub fn create_benchmark_extrinsic(
     client: &FullClient,
     sender: sp_core::sr25519::Pair,

node/src/chain_spec/mod.rs

@@ -1,5 +1,5 @@
 // Allowed since it's actually better to panic during chain setup when there is an error
-#![allow(clippy::unwrap_used)]
+#![allow(clippy::expect_used, clippy::unwrap_used)]
 
 pub mod devnet;
 pub mod finney;

node/src/command.rs

@@ -245,6 +245,7 @@ pub fn run() -> sc_cli::Result<()> {
     }
 }
 
+#[allow(clippy::expect_used)]
 fn start_babe_service(arg_matches: &ArgMatches) -> Result<(), sc_cli::Error> {
     let cli = Cli::from_arg_matches(arg_matches).expect("Bad arg_matches");
     let runner = cli.create_runner(&cli.run)?;
@@ -281,6 +282,7 @@ fn start_babe_service(arg_matches: &ArgMatches) -> Result<(), sc_cli::Error> {
     }
 }
 
+#[allow(clippy::expect_used)]
 fn start_aura_service(arg_matches: &ArgMatches) -> Result<(), sc_cli::Error> {
     let cli = Cli::from_arg_matches(arg_matches).expect("Bad arg_matches");
     let runner = cli.create_runner(&cli.run)?;
@@ -313,6 +315,7 @@ fn start_aura_service(arg_matches: &ArgMatches) -> Result<(), sc_cli::Error> {
     }
 }
 
+#[allow(clippy::expect_used)]
 fn customise_config(arg_matches: &ArgMatches, config: Configuration) -> Configuration {
     let cli = Cli::from_arg_matches(arg_matches).expect("Bad arg_matches");
 

node/src/consensus/babe_consensus.rs

@@ -44,6 +44,7 @@ impl ConsensusMechanism for BabeConsensus {
         sp_timestamp::InherentDataProvider,
     );
 
+    #[allow(clippy::expect_used)]
     fn start_authoring<C, SC, I, PF, SO, L, CIDP, BS, Error>(
         self,
         task_manager: &mut TaskManager,

node/src/consensus/hybrid_import_queue.rs

@@ -77,6 +77,7 @@ impl HybridBlockImport {
             FrontierBlockImport::new(grandpa_block_import.clone(), client.clone()),
         );
 
+        #[allow(clippy::expect_used)]
         let (babe_import, babe_link) = sc_consensus_babe::block_import(
             babe_config,
             grandpa_block_import.clone(),

node/src/service.rs

@@ -60,6 +60,7 @@ pub type BIQ<'a> = Box<
         + 'a,
 >;
 
+#[allow(clippy::expect_used)]
 pub fn new_partial(
     config: &Configuration,
     eth_config: &EthConfiguration,
@@ -250,6 +251,7 @@ pub fn build_manual_seal_import_queue(
 }
 
 /// Builds a new service for a full client.
+#[allow(clippy::expect_used)]
 pub async fn new_full<NB, CM>(
     mut config: Configuration,
     eth_config: EthConfiguration,

pallets/admin-utils/src/lib.rs

@@ -18,6 +18,7 @@ mod tests;
 
 #[deny(missing_docs)]
 #[frame_support::pallet]
+#[allow(clippy::expect_used)]
 pub mod pallet {
     use super::*;
     use frame_support::pallet_prelude::*;
@@ -162,6 +163,8 @@ pub mod pallet {
     /// Dispatchable functions allows users to interact with the pallet and invoke state changes.
     #[pallet::call]
     impl<T: Config> Pallet<T> {
+        #![deny(clippy::expect_used)]
+
         /// The extrinsic sets the new authorities for Aura consensus.
         /// It is only callable by the root account.
         /// The extrinsic will call the Aura pallet to change the authorities.

pallets/collective/src/benchmarking.rs

@@ -16,7 +16,11 @@
 // limitations under the License.
 
 //! Staking pallet benchmarking.
-#![allow(clippy::arithmetic_side_effects, clippy::indexing_slicing)]
+#![allow(
+    clippy::arithmetic_side_effects,
+    clippy::expect_used,
+    clippy::indexing_slicing
+)]
 
 use super::*;
 use crate::Pallet as Collective;

pallets/collective/src/lib.rs

@@ -179,6 +179,7 @@ pub struct Votes<AccountId, BlockNumber> {
 
 #[deny(missing_docs)]
 #[frame_support::pallet]
+#[allow(clippy::expect_used)]
 pub mod pallet {
     use super::*;
     use frame_system::pallet_prelude::*;
@@ -397,6 +398,8 @@ pub mod pallet {
     // Note that councillor operations are assigned to the operational class.
     #[pallet::call]
     impl<T: Config<I>, I: 'static> Pallet<T, I> {
+        #![deny(clippy::expect_used)]
+
         /// Set the collective's membership.
         ///
         /// - `new_members`: The new member list. Be nice to the chain and provide it sorted.
@@ -1128,6 +1131,7 @@ impl<
     }
 
     #[cfg(feature = "runtime-benchmarks")]
+    #[allow(clippy::expect_used)]
     fn try_successful_origin() -> Result<O, ()> {
         let zero_account_id =
             AccountId::decode(&mut sp_runtime::traits::TrailingZeroInput::zeroes())