Skip to content

Port src/app/pages files from JS to TS #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Port src/app/pages files from JS to TS #2801

wants to merge 1 commit into from

Conversation

@OpenStaxClaude
Copy link
Contributor

@OpenStaxClaude OpenStaxClaude commented Nov 25, 2025

Summary

Converts JavaScript files in src/app/pages to TypeScript as part of the migration effort tracked in CORE-1386.

Changes

  • 404.tsx: Converted 404 error page to TypeScript
  • a-page-template.tsx: Added PageData type for template data structure
  • school-selector.tsx: Typed school selector with proper React event handlers and HTMLFormElement
  • testimonials.tsx: Created types for testimonial and image data structures
  • language-selector-section.tsx: Converted to TypeScript with Record type for props
  • use-categorized-books.tsx: Typed book categorization hook with proper return types

Guidelines Followed

  • Avoided using any type
  • Preferred type over interface
  • Relied on type inference where possible
  • Used inline type definitions for function parameters
  • Kept line lengths under 120 characters
  • Each file ends with a blank line

Related Issue

https://openstax.atlassian.net/browse/CORE-1386

🤖 Generated with Claude Code

@OpenStaxClaude @claude
Port src/app/pages files from JS to TS
936ee5e 
- Convert 404.js to TypeScript
- Convert a-page-template.js to TypeScript with PageData type
- Convert school-selector.js to TypeScript with proper event typing
- Convert testimonials.js to TypeScript with testimonial data types
- Convert language-selector-section.js to TypeScript
- Convert use-categorized-books.js to TypeScript with proper book categorization types
- Add proper types for all component props and function parameters
- Type React event handlers properly (onChange)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OpenStaxClaude