Clean up unused static assets #1671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes unused JavaScript and CSS files, fixes broken asset manifests, and removes unused images to improve maintainability and reduce bundle size. Changes: - Removed unused signup.js bundle and all related files (signup/*) The legacy signup flow redirects to newflow, making this bundle unused - Removed section_block.scss (unused stylesheet with note indicating it may be obsolete) - Removed unused images: accounts_horiz_v2.png, rice_logo_4.png - Fixed remote-access/index.coffee by uncommenting require directives - Fixed signin/index.coffee by uncommenting require directives - Updated assets.rb precompile list to remove: * signup.js (unused bundle) * newflow_colors.css (imported by newflow.scss, shouldn't be standalone) Benefits: - Reduced asset precompilation time - Cleaner codebase with less confusion - Removed dead code that could mislead developers - Fixed broken require directives that could cause issues
Copilot finished reviewing on behalf of
mwvolo
November 12, 2025 02:37
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused static assets and fixes broken asset manifests to improve maintainability and reduce bundle size. The cleanup focuses on removing the legacy signup flow bundle that has been superseded by the newflow implementation.
- Removed the entire legacy signup.js bundle and all related JavaScript files
- Fixed broken require directives in signin and remote-access asset manifests by uncommenting them
- Removed unused stylesheet and image files
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| config/initializers/assets.rb | Removed signup.js and newflow_colors.css from precompile list (the latter is imported by newflow.scss, not standalone) |
| app/assets/stylesheets/section_block.scss | Deleted unused stylesheet that was already marked as potentially obsolete |
| app/assets/javascripts/signup/type-selector.coffee | Removed as part of legacy signup bundle cleanup |
| app/assets/javascripts/signup/phone-number.js | Removed as part of legacy signup bundle cleanup |
| app/assets/javascripts/signup/namespace.coffee | Removed as part of legacy signup bundle cleanup |
| app/assets/javascripts/signup/index.js | Removed as part of legacy signup bundle cleanup |
| app/assets/javascripts/signup/email-value.coffee | Removed as part of legacy signup bundle cleanup |
| app/assets/javascripts/signin/index.coffee | Fixed commented-out require directives by changing ##= to #= |
| app/assets/javascripts/remote-access/index.coffee | Fixed commented-out require directives by changing ##= to #= |
| app/assets/images/rice_logo_4.png | Removed unused image file |
| app/assets/images/accounts_horiz_v2.png | Removed unused image file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes unused JavaScript and CSS files, fixes broken asset manifests, and removes unused images to improve maintainability and reduce bundle size.
Changes:
Benefits: