Skip to content

Commit eaabe5b

Browse files
S0okJuhalucinor
authored andcommitted
bug(cinder): Delete is_bootable attribute(#93)
1 parent e9fe44b commit eaabe5b

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

src/openstack_mcp_server/tools/block_storage_tools.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ def create_volume(
110110
description: str | None = None,
111111
volume_type: str | None = None,
112112
availability_zone: str | None = None,
113-
bootable: bool | None = None,
114113
image: str | None = None,
115114
) -> Volume:
116115
"""
@@ -121,7 +120,6 @@ def create_volume(
121120
:param description: Optional description for the volume
122121
:param volume_type: Optional volume type
123122
:param availability_zone: Optional availability zone
124-
:param bootable: Optional flag to make the volume bootable
125123
:param image: Optional Image name, ID or object from which to create
126124
:return: The created Volume object
127125
"""
@@ -141,7 +139,6 @@ def create_volume(
141139
volume = conn.block_storage.create_volume(
142140
size=size,
143141
image=image,
144-
bootable=bootable,
145142
**volume_kwargs,
146143
)
147144

tests/tools/test_block_storage_tools.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,6 @@ def test_create_volume_success(
395395
mock_conn.block_storage.create_volume.assert_called_once_with(
396396
size=10,
397397
image=None,
398-
bootable=None,
399398
name="new-volume",
400399
description="Test volume",
401400
volume_type="ssd",
@@ -435,7 +434,6 @@ def test_create_volume_minimal_params(
435434
mock_conn.block_storage.create_volume.assert_called_once_with(
436435
size=5,
437436
image=None,
438-
bootable=None,
439437
name="minimal-volume",
440438
)
441439

@@ -468,20 +466,17 @@ def test_create_volume_with_image_and_bootable(
468466
"Bootable volume from image",
469467
"ssd",
470468
"nova",
471-
True,
472469
"ubuntu-20.04",
473470
)
474471

475472
assert isinstance(result, Volume)
476473
assert result.name == "bootable-volume"
477474
assert result.id == "vol-bootable"
478475
assert result.size == 20
479-
assert result.is_bootable
480476

481477
mock_conn.block_storage.create_volume.assert_called_once_with(
482478
size=20,
483479
image="ubuntu-20.04",
484-
bootable=True,
485480
name="bootable-volume",
486481
description="Bootable volume from image",
487482
volume_type="ssd",

0 commit comments

Comments
 (0)