Skip to content

Commit 3ae5a98

Browse files
platanus-krhalucinor
authored andcommitted
Fix: alignment network model field (#56)
* fix(network): alignment network model field (#55) * fix(network): test pass (#55)
1 parent 714cf3e commit 3ae5a98

File tree

2 files changed

+24
-24
lines changed

2 files changed

+24
-24
lines changed

src/openstack_mcp_server/tools/network_tools.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,8 @@ def _convert_to_network_model(self, openstack_network) -> Network:
197197
name=openstack_network.name or "",
198198
status=openstack_network.status or "",
199199
description=openstack_network.description or None,
200-
is_admin_state_up=openstack_network.admin_state_up or False,
201-
is_shared=openstack_network.shared or False,
200+
is_admin_state_up=openstack_network.is_admin_state_up or False,
201+
is_shared=openstack_network.is_shared or False,
202202
mtu=openstack_network.mtu or None,
203203
provider_network_type=openstack_network.provider_network_type
204204
or None,

tests/tools/test_network_tools.py

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ def test_get_networks_success(
2525
mock_network1.name = "private-network"
2626
mock_network1.status = "ACTIVE"
2727
mock_network1.description = "Private network for project"
28-
mock_network1.admin_state_up = True
29-
mock_network1.shared = False
28+
mock_network1.is_admin_state_up = True
29+
mock_network1.is_shared = False
3030
mock_network1.mtu = 1500
3131
mock_network1.provider_network_type = "vxlan"
3232
mock_network1.provider_physical_network = None
@@ -38,8 +38,8 @@ def test_get_networks_success(
3838
mock_network2.name = "public-network"
3939
mock_network2.status = "ACTIVE"
4040
mock_network2.description = "Public shared network"
41-
mock_network2.admin_state_up = True
42-
mock_network2.shared = True
41+
mock_network2.is_admin_state_up = True
42+
mock_network2.is_shared = True
4343
mock_network2.mtu = 1450
4444
mock_network2.provider_network_type = "flat"
4545
mock_network2.provider_physical_network = "physnet1"
@@ -113,8 +113,8 @@ def test_get_networks_with_status_filter(
113113
mock_network1.name = "active-network"
114114
mock_network1.status = "ACTIVE"
115115
mock_network1.description = None
116-
mock_network1.admin_state_up = True
117-
mock_network1.shared = False
116+
mock_network1.is_admin_state_up = True
117+
mock_network1.is_shared = False
118118
mock_network1.mtu = None
119119
mock_network1.provider_network_type = None
120120
mock_network1.provider_physical_network = None
@@ -126,8 +126,8 @@ def test_get_networks_with_status_filter(
126126
mock_network2.name = "down-network"
127127
mock_network2.status = "DOWN"
128128
mock_network2.description = None
129-
mock_network2.admin_state_up = False
130-
mock_network2.shared = False
129+
mock_network2.is_admin_state_up = False
130+
mock_network2.is_shared = False
131131
mock_network2.mtu = None
132132
mock_network2.provider_network_type = None
133133
mock_network2.provider_physical_network = None
@@ -160,8 +160,8 @@ def test_get_networks_shared_only(
160160
mock_network1.name = "private-network"
161161
mock_network1.status = "ACTIVE"
162162
mock_network1.description = None
163-
mock_network1.admin_state_up = True
164-
mock_network1.shared = False
163+
mock_network1.is_admin_state_up = True
164+
mock_network1.is_shared = False
165165
mock_network1.mtu = None
166166
mock_network1.provider_network_type = None
167167
mock_network1.provider_physical_network = None
@@ -173,8 +173,8 @@ def test_get_networks_shared_only(
173173
mock_network2.name = "shared-network"
174174
mock_network2.status = "ACTIVE"
175175
mock_network2.description = None
176-
mock_network2.admin_state_up = True
177-
mock_network2.shared = True
176+
mock_network2.is_admin_state_up = True
177+
mock_network2.is_shared = True
178178
mock_network2.mtu = None
179179
mock_network2.provider_network_type = None
180180
mock_network2.provider_physical_network = None
@@ -205,8 +205,8 @@ def test_create_network_success(self, mock_openstack_connect_network):
205205
mock_network.name = "new-network"
206206
mock_network.status = "ACTIVE"
207207
mock_network.description = "A new network"
208-
mock_network.admin_state_up = True
209-
mock_network.shared = False
208+
mock_network.is_admin_state_up = True
209+
mock_network.is_shared = False
210210
mock_network.mtu = 1500
211211
mock_network.provider_network_type = "vxlan"
212212
mock_network.provider_physical_network = None
@@ -260,8 +260,8 @@ def test_create_network_minimal_args(self, mock_openstack_connect_network):
260260
mock_network.name = "minimal-network"
261261
mock_network.status = "ACTIVE"
262262
mock_network.description = None
263-
mock_network.admin_state_up = True
264-
mock_network.shared = False
263+
mock_network.is_admin_state_up = True
264+
mock_network.is_shared = False
265265
mock_network.mtu = None
266266
mock_network.provider_network_type = None
267267
mock_network.provider_physical_network = None
@@ -307,8 +307,8 @@ def test_get_network_detail_success(self, mock_openstack_connect_network):
307307
mock_network.name = "detail-network"
308308
mock_network.status = "ACTIVE"
309309
mock_network.description = "Network for detail testing"
310-
mock_network.admin_state_up = True
311-
mock_network.shared = True
310+
mock_network.is_admin_state_up = True
311+
mock_network.is_shared = True
312312
mock_network.mtu = 1500
313313
mock_network.provider_network_type = "vlan"
314314
mock_network.provider_physical_network = "physnet1"
@@ -364,8 +364,8 @@ def test_update_network_success(self, mock_openstack_connect_network):
364364
mock_network.name = "updated-network"
365365
mock_network.status = "ACTIVE"
366366
mock_network.description = "Updated description"
367-
mock_network.admin_state_up = False
368-
mock_network.shared = True
367+
mock_network.is_admin_state_up = False
368+
mock_network.is_shared = True
369369
mock_network.mtu = 1400
370370
mock_network.provider_network_type = "vxlan"
371371
mock_network.provider_physical_network = None
@@ -422,8 +422,8 @@ def test_update_network_partial_update(
422422
mock_network.name = "new-name"
423423
mock_network.status = "ACTIVE"
424424
mock_network.description = "old description"
425-
mock_network.admin_state_up = True
426-
mock_network.shared = False
425+
mock_network.is_admin_state_up = True
426+
mock_network.is_shared = False
427427
mock_network.mtu = None
428428
mock_network.provider_network_type = None
429429
mock_network.provider_physical_network = None

0 commit comments

Comments
 (0)