-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-17315-Added required Google Cloud APIs back to OSD docs that were removed in error. #102328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🤖 Thu Nov 13 15:56:53 - Prow CI generated the docs preview: https://102328--ocpdocs-pr.netlify.app/openshift-dedicated/latest/osd_planning/gcp-ccs.html |
|
@rcampos2029 @shreyansvm Can you please review and advise if anything else needs to be amended? Many thanks. |
|
Thanks @AedinC . This looks okay. |
|
@AedinC : Should we update this change in the release notes indicating something on the lines of "these APIs were missed due to a bug and it has been addressed.". We want to have some way to letting our users know that the table has been updated. |
|
Possibly, this and the required role for Marketplace billing could be combined in the Release Notes update. |
Yes, I can look at adding this to the release notes. |
rcampos2029
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that all of the required GCP APIs are listed in Table 1. Required API services. All links are valid.
…ere removed in error.
| {product-title} is professionally managed by Red{nbsp}Hat and hosted on {GCP} or {AWS}. Each {product-title} cluster includes a fully managed link:https://access.redhat.com/documentation/en-us/openshift_container_platform/{ocp-version}/html/architecture/control-plane[control plane] (Control and Infrastructure nodes), application nodes, installation and management by Red{nbsp}Hat Site Reliability Engineers (SRE), premium Red{nbsp}Hat Support, and cluster services such as logging, metrics, monitoring, notifications portal, and a cluster portal. | ||
|
|
||
| {product-title} clusters are available on the link:https://console.redhat.com/openshift[Hybrid Cloud Console]. With the Red Hat {cluster-manager} application, you can deploy {product-title} clusters to either on-premise or cloud environments. | ||
| {product-title} clusters are available on the link:https://console.redhat.com/openshift[Hybrid Cloud Console]. With the Red{nbsp}Hat {cluster-manager} application, you can deploy {product-title} clusters to either on-premise or cloud environments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{hybrid-console-second}' rather than the plain text product term 'Hybrid Cloud Console', unless your use case is an exception.
|
@AedinC: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@shreyansvm Have added that to the release notes and have requested a peer review. Once that is done I will get this PR merged. |
Version(s):
4.20+
Issue:
https://issues.redhat.com/browse/OSDOCS-17315
Link to docs preview:
Peer review:
SME review:
QE review:
Additional information: