Skip to content

Commit f9c6a62

Browse files
committed
Add code comments
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
1 parent 27ef9bc commit f9c6a62

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

pom.xml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,18 +104,19 @@
104104
<version>${javax.annotation-api.version}</version>
105105
</dependency>
106106

107+
<!-- reuse a few xDS proto here -->
108+
<dependency>
109+
<groupId>io.envoyproxy.controlplane</groupId>
110+
<artifactId>api</artifactId>
111+
<version>${envoy-api.version}</version>
112+
</dependency>
113+
107114
<!-- test-scope dependencies -->
108115
<dependency>
109116
<groupId>junit</groupId>
110117
<artifactId>junit</artifactId>
111118
<scope>test</scope>
112119
</dependency>
113-
114-
<dependency>
115-
<groupId>io.envoyproxy.controlplane</groupId>
116-
<artifactId>api</artifactId>
117-
<version>${envoy-api.version}</version>
118-
</dependency>
119120
</dependencies>
120121

121122
<dependencyManagement>

src/main/java/io/opensergo/OpenSergoConfigKindRegistry.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,15 @@ public final class OpenSergoConfigKindRegistry {
3838
static {
3939
KIND_MAP = new ConcurrentHashMap<>();
4040

41+
// domain: fault-tolerance
4142
registerConfigKind(ConfigKind.FAULT_TOLERANCE_RULE, FaultToleranceRule.class);
4243
registerConfigKind(ConfigKind.RATE_LIMIT_STRATEGY, RateLimitStrategy.class);
4344
registerConfigKind(ConfigKind.THROTTLING_STRATEGY, ThrottlingStrategy.class);
4445
registerConfigKind(ConfigKind.CONCURRENCY_LIMIT_STRATEGY, ConcurrencyLimitStrategy.class);
4546
registerConfigKind(ConfigKind.CIRCUIT_BREAKER_STRATEGY, CircuitBreakerStrategy.class);
47+
48+
// domain: traffic
49+
// NOTE: here we've reused a few parts of xDS proto (e.g. route proto)
4650
registerConfigKind(ConfigKind.TRAFFIC_ROUTER_STRATEGY, RouteConfiguration.class);
4751
}
4852

0 commit comments

Comments
 (0)