INF-1060: Generate project mapfile from topology/LDAP instead of COManage #27
+82
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses LDAP search to find active and provisioned groups then compares them to the list project groups in COmanage to determine which LDAP groups and users to build the map out of.
And clean up of no-longer-used methods remove collections import
Writes the osggids to project name dict to a file containing the epoch time the cache was made. If the file is found to exist and was made in the past 0.5 hours (by default), the program will read from the cache instead of making COmanage API calls. Otherwise, the program will get the project data from the API and overwrite any existing cache.
Uses LDAP search to find active and provisioned groups then compares them to the list project groups in COmanage to determine which LDAP groups and users to build the map out of.
And clean up of no-longer-used methods remove collections import
Writes the osggids to project name dict to a file containing the epoch time the cache was made. If the file is found to exist and was made in the past 0.5 hours (by default), the program will read from the cache instead of making COmanage API calls. Otherwise, the program will get the project data from the API and overwrite any existing cache.
…nswanson/osg-comanage-project-usermap into INF-1060.member-removals
…s' from topology rather than comanage
mwestphall
force-pushed
the
INF-1060-member-removals
branch
from
8f05ba7 to
f5fc575
Compare
mwestphall
force-pushed
the
INF-1060-member-removals
branch
from
f5fc575 to
e3677da
Compare
brianhlin
requested changes
Nov 26, 2025
Member
brianhlin
left a comment
brianhlin
left a comment
There was a problem hiding this comment.
I imagine this works but it could use some touching up
mwestphall
force-pushed
the
INF-1060-member-removals
branch
from
9496d0d to
df440b4
Compare
brianhlin
requested changes
Nov 26, 2025
Member
brianhlin
left a comment
brianhlin
left a comment
There was a problem hiding this comment.
Some minor changes requested but otherwise LGTM
…oups/get_ldap_active_users_and_groups
brianhlin
reviewed
Nov 26, 2025
brianhlin
approved these changes
Dec 1, 2025
Member
brianhlin
left a comment
brianhlin
left a comment
There was a problem hiding this comment.
LGTM. Holding off on merging since I don't recall if this automatically gets deployed in prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all COManage-facing code from the projectmap generation script. Instead, get user and group information from LDAP and OSPool project information from topology. Marked as do-not-merge until we resolve some data misalignments between topology and COManage:
https://opensciencegrid.atlassian.net/browse/INF-1060