Skip to content

Commit df440b4

Browse files
committed
Remove unused code from first draft of PR
1 parent e3677da commit df440b4

File tree

2 files changed

+2
-49
lines changed

2 files changed

+2
-49
lines changed

comanage_utils.py

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import time
77
import urllib.error
88
import urllib.request
9-
from ldap3 import Server, Connection, ALL, SAFE_SYNC
9+
from ldap3 import Server, Connection, ALL, SAFE_SYNC, Tls
1010

1111
#PRODUCTION VALUES
1212

@@ -71,7 +71,7 @@ def mkauthstr(user, passwd):
7171

7272
def get_ldap_authtok(ldap_authfile):
7373
if ldap_authfile is not None:
74-
ldap_authtok = open(ldap_authfile).readline().rstrip("\n")
74+
ldap_authtok = open(ldap_authfile).readline().strip()
7575
else:
7676
raise PermissionError
7777
return ldap_authtok
@@ -183,28 +183,6 @@ def get_ldap_groups(ldap_server, ldap_user, ldap_authtok):
183183
return ldap_group_osggids
184184

185185

186-
def get_ldap_group_members(ldap_gid, ldap_server, ldap_user, ldap_authtok):
187-
ldap_group_members = set()
188-
server = Server(ldap_server, get_info=ALL)
189-
connection = Connection(server, ldap_user, ldap_authtok, client_strategy=SAFE_SYNC, auto_bind=True)
190-
_, _, response, _ = connection.search("ou=groups,o=OSG,o=CO,dc=cilogon,dc=org", f"(&(gidNumber={ldap_gid})(cn=*))", attributes=["hasMember"])
191-
for group in response:
192-
ldap_group_members.update(group["attributes"]["hasMember"])
193-
return ldap_group_members
194-
195-
196-
def get_ldap_active_users(ldap_server, ldap_user, ldap_authtok, filter_group_name=None):
197-
ldap_active_users = set()
198-
filter_str = ("(isMemberOf=CO:members:active)" if filter_group_name is None
199-
else f"(&(isMemberOf={filter_group_name})(isMemberOf=CO:members:active))")
200-
server = Server(ldap_server, get_info=ALL)
201-
connection = Connection(server, ldap_user, ldap_authtok, client_strategy=SAFE_SYNC, auto_bind=True)
202-
_, _, response, _ = connection.search("ou=people,o=OSG,o=CO,dc=cilogon,dc=org", filter_str, attributes=["employeeNumber"])
203-
for person in response:
204-
# the "employeeNumber" is the person's name in the first.last format
205-
ldap_active_users.add(person["attributes"]["employeeNumber"])
206-
return ldap_active_users
207-
208186
def get_ldap_active_users_and_groups(ldap_server, ldap_user, ldap_authtok, filter_group_name=None):
209187
""" Retrieve a dictionary of active users from LDAP, with their group memberships. """
210188
ldap_active_users = {}

osg-comanage-project-usermap.py

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@
33
import os
44
import re
55
import sys
6-
import time
76
import getopt
8-
import urllib.error
9-
import urllib.request
107
import requests
118
import comanage_utils as utils
129

@@ -122,28 +119,6 @@ def _deduplicate_list(items):
122119
"""
123120
return list(dict.fromkeys(items))
124121

125-
def get_ldap_group_members_dict():
126-
group_data_dict = dict()
127-
for group_gid in utils.get_ldap_groups(options.ldap_server, options.ldap_user, options.ldap_authtok):
128-
group_members = utils.get_ldap_group_members(group_gid, options.ldap_server, options.ldap_user, options.ldap_authtok)
129-
group_data_dict[group_gid] = group_members
130-
131-
return group_data_dict
132-
133-
134-
def create_user_to_projects_map(project_to_user_map, active_users, osggids_to_names):
135-
users_to_projects_map = dict()
136-
for osggid in project_to_user_map:
137-
for user in project_to_user_map[osggid]:
138-
if user in active_users:
139-
if user not in users_to_projects_map:
140-
users_to_projects_map[user] = [osggids_to_names[osggid]]
141-
else:
142-
users_to_projects_map[user].append(osggids_to_names[osggid])
143-
144-
return users_to_projects_map
145-
146-
147122
def get_osguser_groups(filter_group_name=None):
148123
ldap_users = utils.get_ldap_active_users_and_groups(options.ldap_server, options.ldap_user, options.ldap_authtok, filter_group_name)
149124
topology_projects = requests.get(f"{TOPOLOGY_ENDPOINT}/miscproject/json").json()

0 commit comments

Comments
 (0)