Automatic merge of T1.6-106-gdcc176472 and 14 pull requests

- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds

Author: openrails-bot

Source/RunActivity/Viewer3D/Popups/TrainCarOperationsViewerWindow.cs

@@ -602,8 +602,12 @@ public buttonCouplerFront(int x, int y, int size, Viewer viewer, TrainCar car, i
                 bool first = car == Viewer.PlayerTrain.Cars.First();
                 var CurrentCar = Viewer.PlayerTrain.Cars[carPosition];
 
-                var isSteamAndHasTender = (CurrentCar is MSTSSteamLocomotive) &&
-                    (carPosition + (CurrentCar.Flipped ? -1 : 1) < Viewer.PlayerTrain.Cars.Count) && (Viewer.PlayerTrain.Cars[carPosition + (CurrentCar.Flipped ? -1 : 1)].WagonType == MSTSWagon.WagonTypes.Tender);
+                var isSteamAndHasTender = false;
+                if (CurrentCar is MSTSSteamLocomotive)
+                {
+                    var validTenderPosition = CurrentCar.Flipped ? carPosition - 1 > -1 : carPosition + 1 < Viewer.PlayerTrain.Cars.Count;
+                    isSteamAndHasTender = validTenderPosition && (Viewer.PlayerTrain.Cars[carPosition + (CurrentCar.Flipped ? -1 : 1)].WagonType == MSTSWagon.WagonTypes.Tender);
+                }
                 var isTender = CurrentCar.WagonType == MSTSWagon.WagonTypes.Tender;
                 if (isSteamAndHasTender || isTender)
                 {

Source/RunActivity/Viewer3D/Popups/TrainCarOperationsWindow.cs

@@ -908,8 +908,12 @@ public buttonCouplerFront(int x, int y, int size, Viewer viewer, TrainCar car, i
             First = car == Viewer.PlayerTrain.Cars.First();
             var CurrentCar = Viewer.PlayerTrain.Cars[carPosition]; ;
 
-            var isSteamAndHasTender = (CurrentCar is MSTSSteamLocomotive) &&
-                (carPosition + (CurrentCar.Flipped ? -1 : 1) < Viewer.PlayerTrain.Cars.Count) && (Viewer.PlayerTrain.Cars[carPosition + (CurrentCar.Flipped ? -1 : 1)].WagonType == MSTSWagon.WagonTypes.Tender);
+            var isSteamAndHasTender = false;
+            if (CurrentCar is MSTSSteamLocomotive)
+            {
+                var validTenderPosition = CurrentCar.Flipped ? carPosition - 1 > -1 : carPosition + 1 < Viewer.PlayerTrain.Cars.Count;
+                isSteamAndHasTender = validTenderPosition && (Viewer.PlayerTrain.Cars[carPosition + (CurrentCar.Flipped ? -1 : 1)].WagonType == MSTSWagon.WagonTypes.Tender);
+            }
             var isTender = CurrentCar.WagonType == MSTSWagon.WagonTypes.Tender;
 
             if (isSteamAndHasTender || isTender)