Fix for bug https://bugs.launchpad.net/or/+bug/2117357. Exception index of of range when opening Train Car Operations window

sweiland-openrails · sweiland-openrails · commit b47224d7d366 · 2025-07-20T19:50:53.000+02:00
diff --git a/Source/RunActivity/Viewer3D/WebServices/TrainCarOperationsWebpage.cs b/Source/RunActivity/Viewer3D/WebServices/TrainCarOperationsWebpage.cs
@@ -710,6 +710,10 @@ public void buttonCouplerFrontClick(int carPosition)
                 TrainCarViewer.NewCarPosition = carPosition - 1;
                 if (Viewer.CarOperationsWindow.CarPosition > carPosition - 1)
                     Viewer.CarOperationsWindow.Visible = false;
+                if (Viewer.TrainCarOperationsWindow.SelectedCarPosition >= Viewer.PlayerTrain.Cars.Count())
+                {
+                    Viewer.TrainCarOperationsWindow.SelectedCarPosition = Viewer.PlayerTrain.Cars.Count - 1;
+                }
             }
         }
 
@@ -808,6 +812,10 @@ public void buttonCouplerRearClick(int carPosition)
                 TrainCarViewer.CouplerChanged = true;
                 if (Viewer.CarOperationsWindow.CarPosition > carPosition)
                     Viewer.CarOperationsWindow.Visible = false;
+                if (Viewer.TrainCarOperationsWindow.SelectedCarPosition >= Viewer.PlayerTrain.Cars.Count())
+                {
+                    Viewer.TrainCarOperationsWindow.SelectedCarPosition = Viewer.PlayerTrain.Cars.Count - 1;
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -710,6 +710,10 @@ public void buttonCouplerFrontClick(int carPosition)`
`710`	`710`	`TrainCarViewer.NewCarPosition = carPosition - 1;`
`711`	`711`	`if (Viewer.CarOperationsWindow.CarPosition > carPosition - 1)`
`712`	`712`	`Viewer.CarOperationsWindow.Visible = false;`
	`713`	`+ if (Viewer.TrainCarOperationsWindow.SelectedCarPosition >= Viewer.PlayerTrain.Cars.Count())`
	`714`	`+ {`
	`715`	`+ Viewer.TrainCarOperationsWindow.SelectedCarPosition = Viewer.PlayerTrain.Cars.Count - 1;`
	`716`	`+ }`
`713`	`717`	`}`
`714`	`718`	`}`
`715`	`719`
`@@ -808,6 +812,10 @@ public void buttonCouplerRearClick(int carPosition)`
`808`	`812`	`TrainCarViewer.CouplerChanged = true;`
`809`	`813`	`if (Viewer.CarOperationsWindow.CarPosition > carPosition)`
`810`	`814`	`Viewer.CarOperationsWindow.Visible = false;`
	`815`	`+ if (Viewer.TrainCarOperationsWindow.SelectedCarPosition >= Viewer.PlayerTrain.Cars.Count())`
	`816`	`+ {`
	`817`	`+ Viewer.TrainCarOperationsWindow.SelectedCarPosition = Viewer.PlayerTrain.Cars.Count - 1;`
	`818`	`+ }`
`811`	`819`	`}`
`812`	`820`	`}`
`813`	`821`