Automatic merge of T1.5.1-719-g89833d44e and 18 pull requests

- Pull request #570 at c59c788: Experimental glTF 2.0 support with PBR lighting
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #865 at 3b5a2fe: Dispatcher window improvements
- Pull request #874 at f8dbeab: Dynamic brake controller refactoring
- Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #882 at 9df6e1d: Blueprint/train car operations UI window
- Pull request #883 at edcc2dd: SwitchPanel disconnect/connect handling
- Pull request #885 at c81447b: feat: Add notifications to Menu
- Pull request #886 at cd452ee: Scene viewer extension to TrackViewer
- Pull request #888 at d7daf62: docs: Document player application model
- Pull request #890 at 39a9fa4: Allow depart early
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #893 at bf8876b: Signal errors
- Pull request #894 at 794fddf: Correct Decrease Colour
- Pull request #896 at 5866028: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #897 at 0a9d939: feat: Improved system information collection
- Pull request #898 at e271395: Extra line with all the arguments for debugging purposes in logfile

Author: openrails-bot

Source/RunActivity/Viewer3D/Cameras.cs

@@ -1295,8 +1295,12 @@ protected override void OnActivate(bool sameCamera)
                     }
                     else if (isVisibleTrainCarViewerOrWebpage && carPosition >= 0)
                     {
-                        SetCameraCar(trainCars[carPosition]);
-                        oldCarPosition = carPosition;
+                        if (carPosition < trainCars.Count)
+                        {
+                            // sometimes when decoupling cars the carPosition is out-of-range
+                            SetCameraCar(trainCars[carPosition]);
+                            oldCarPosition = carPosition;
+                        }
                     }
                     else
                         SetCameraCar(GetCameraCars().First());

Source/RunActivity/Viewer3D/WebServices/TrainCarOperationsWebpage.cs

@@ -428,6 +428,13 @@ private void fillStatusArrowLeft(int carPosition)
         {
             string filename;
 
+            if (Viewer.TrainCarOperationsWindow.CarIdClicked) {
+                // on the train operations window wagon has been clicked
+                // wagon on webpage gets selected also
+                TrainCarSelected = true;
+                TrainCarSelectedPosition = Viewer.TrainCarOperationsWindow.SelectedCarPosition;
+            }
+
             if (TrainCarSelected && (carPosition == TrainCarSelectedPosition))
             {
                 filename = "TrainOperationsArrowRight32.png";

Source/RunActivity/Viewer3D/WebServices/Web/TrainCarOperations/index.js

@@ -130,6 +130,12 @@ function handleMessage(json) {
         let id = "button:" + row + ":" + column;
         let button = document.getElementById(id);
         button.innerHTML = "<img src='" + json.Operations[i].Filename + "' />";
+        if (json.Operations[i].Filename.includes("Arrow")) {
+            if (!isInView(button)) {
+                console.log("scrollTo");
+                button.scrollIntoView({ behavior: "smooth" });
+            }
+        }
         button.disabled = !json.Operations[i].Enabled;
         button.style.cursor = json.Operations[i].Enabled ? "pointer" : "";
     }
@@ -157,6 +163,27 @@ function sleep(time) {
     return new Promise((resolve) => setTimeout(resolve, time));
 }
 
+function isInView(el) {
+
+    var rect = el.getBoundingClientRect(),
+        vWidth = window.innerWidth || document.documentElement.clientWidth,
+        vHeight = window.innerHeight || document.documentElement.clientHeight,
+        efp = function (x, y) { return document.elementFromPoint(x, y) };
+
+    // Return false if it's not in the viewport
+    if (rect.right < 0 || rect.bottom < 0
+        || rect.left > vWidth || rect.top > vHeight)
+        return false;
+
+    // Return true if any of its four corners are visible
+    return (
+        el.contains(efp(rect.left, rect.top))
+        || el.contains(efp(rect.right, rect.top))
+        || el.contains(efp(rect.right, rect.bottom))
+        || el.contains(efp(rect.left, rect.bottom))
+    );
+}
+
 //
 // main
 //