Only support GPU-friendly texture formats for particles

Author: SteelFill

Source/Documentation/Manual/physics.rst

@@ -2611,7 +2611,8 @@ be included to further customize effect emitters:
   particles from this emitter. The default texture is "smokemain.ace" for steam-type emitters and
   "dieselsmoke.ace" for diesel-type emitters. If the texture cannot be found from the engine's/wagon's
   folder, then the ``GLOBAL\TEXTURES`` folder is checked, and if the texture is not there the ``Content``
-  folder included with OR is checked. Allowed texture formats are ``.png, .jpg, .bmp, .gif, .ace, or .dds``.
+  folder included with OR is checked. OR will search for any ``.ace`` or ``.dds`` textures with the name
+  specified, though .dds is preferred over .ace.
   A path to a texture can also be used, such as ``ORTSGraphic ( "..\\SmokeTextures\\steam.dds" )``, to search
   for textures not in the same folder as the engine or wagon.
 - ``ORTSGraphicAtlasLayout ( w h )`` -- Particle textures generally include multiple sprites in a single file

Source/RunActivity/Viewer3D/Materials.cs

@@ -65,14 +65,12 @@ public Texture2D Get(string path, Texture2D defaultTexture, bool required = fals
                 return defaultTexture;
 
             path = path.ToLowerInvariant();
-            var ext = Path.GetExtension(path);
-
             if (!Textures.ContainsKey(path))
             {
                 try
                 {
                     Texture2D texture;
-                    if (ext == ".dds")
+                    if (Path.GetExtension(path) == ".dds")
                     {
                         if (File.Exists(path))
                         {
@@ -91,10 +89,10 @@ public Texture2D Get(string path, Texture2D defaultTexture, bool required = fals
                             else return defaultTexture;
                         }
                     }
-                    else if (ext == ".ace")
+                    else if (Path.GetExtension(path) == ".ace")
                     {
                         var alternativeTexture = Path.ChangeExtension(path, ".dds");
-
+                        
                         if (File.Exists(alternativeTexture))
                         {
                             DDSLib.DDSFromFile(alternativeTexture, GraphicsDevice, true, out texture);
@@ -147,30 +145,7 @@ Texture2D invalid()
                         }
                     }
                     else
-                    {
-                        using (var stream = File.OpenRead(path))
-                        {
-                            if (ext == ".gif" || ext == ".jpg" || ext == ".png")
-                                texture = Texture2D.FromStream(GraphicsDevice, stream);
-                            else if (ext == ".bmp")
-                            {
-                                using (var image = System.Drawing.Image.FromStream(stream))
-                                {
-                                    using (var memoryStream = new MemoryStream())
-                                    {
-                                        image.Save(memoryStream, System.Drawing.Imaging.ImageFormat.Png);
-                                        memoryStream.Seek(0, SeekOrigin.Begin);
-                                        texture = Texture2D.FromStream(GraphicsDevice, memoryStream);
-                                    }
-                                }
-                            }
-                            else
-                            {
-                                Trace.TraceWarning("Unsupported texture format: {0}", path);
-                                return defaultTexture;
-                            }
-                        }
-                    }
+                        return defaultTexture;
 
                     Textures.Add(path, texture);
                     return texture;

Source/RunActivity/Viewer3D/ParticleEmitter.cs

@@ -87,13 +87,21 @@ public void Initialize(string defaultTextureName)
             else
                 TexturePath = defaultTextureName;
 
+            string noExtension = Path.ChangeExtension(TexturePath, null);
+
+            string wagPath = Path.Combine(Path.GetDirectoryName(Emitter.CarViewer.Car.WagFilePath), noExtension);
+            string globalPath = Path.Combine(Viewer.Simulator.BasePath + @"\GLOBAL\TEXTURES\", noExtension);
+            string contentPath = Path.Combine(Viewer.ContentPath, noExtension);
+
             // Texture location preference is eng/wag folder -> MSTS GLOBAL\TEXTURES folder -> OR CONTENT folder
-            if (File.Exists(Path.Combine(Path.GetDirectoryName(Emitter.CarViewer.Car.WagFilePath), TexturePath)))
-                TexturePath = Path.Combine(Path.GetDirectoryName(Emitter.CarViewer.Car.WagFilePath), TexturePath);
-            else if (File.Exists(Path.Combine(Viewer.Simulator.BasePath + @"\GLOBAL\TEXTURES\", TexturePath)))
-                TexturePath = Path.Combine(Viewer.Simulator.BasePath + @"\GLOBAL\TEXTURES\", TexturePath);
-            else if (customTexture && File.Exists(Path.Combine(Viewer.ContentPath, TexturePath)))
-                TexturePath = Path.Combine(Viewer.ContentPath, TexturePath);
+            // File type agnostic: We should detect a match if a .ace OR .dds is present, regardless of the specific file type requested
+            // We give the material manager the path to the .dds file, but it will automatically load the .ace file if the .dds is missing
+            if (File.Exists(wagPath + ".dds") || File.Exists(wagPath + ".ace"))
+                TexturePath = wagPath + ".dds";
+            else if (File.Exists(globalPath + ".dds") || File.Exists(globalPath + ".ace"))
+                TexturePath = globalPath + ".dds";
+            else if (File.Exists(contentPath + ".dds") || File.Exists(contentPath + ".ace"))
+                TexturePath = contentPath + ".dds";
             else // Fall back to default texture in CONTENT folder
             {
                 TexturePath = Path.Combine(Viewer.ContentPath, defaultTextureName);