Automatic merge of T1.5.1-722-g01614a154 and 17 pull requests

- Pull request #570 at c59c788: Experimental glTF 2.0 support with PBR lighting
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #865 at 3b5a2fe: Dispatcher window improvements
- Pull request #874 at f8dbeab: Dynamic brake controller refactoring
- Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #882 at 90255fb: Blueprint/train car operations UI window
- Pull request #885 at c81447b: feat: Add notifications to Menu
- Pull request #886 at 697a4b6: Scene viewer extension to TrackViewer
- Pull request #888 at d7daf62: docs: Document player application model
- Pull request #890 at 39a9fa4: Allow depart early
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #893 at bf8876b: Signal errors
- Pull request #894 at 794fddf: Correct Decrease Colour
- Pull request #896 at 5866028: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #897 at 0a9d939: feat: Improved system information collection
- Pull request #898 at e271395: Extra line with all the arguments for debugging purposes in logfile

Author: openrails-bot

Source/Contrib/TrackViewer/SceneViewer.cs

@@ -53,6 +53,7 @@ public class SceneViewer
         OrbitingCamera Camera;
 
         EditorState EditorState;
+        EditorMoveState EditorMoveState;
         StaticShape SelectedObject;
         WorldFile SelectedWorldFile;
         Orts.Formats.Msts.WorldObject SelectedWorldObject;
@@ -109,11 +110,6 @@ public void Show()
             SceneWindow.Activate();
         }
 
-        /// <summary>
-        /// Allows the game to run logic such as updating the world,
-        /// checking for collisions, gathering input, and playing audio.
-        /// </summary>
-        /// <param name="gameTime">Provides a snapshot of timing values.</param>
         public void Update(GameTime gameTime)
         {
             Viewer = Viewer ?? Game.RenderProcess?.Viewer;
@@ -155,19 +151,29 @@ public void Update(GameTime gameTime)
             {
                 if (UserInput.IsPressed(UserCommand.EditorMove))
                 {
+                    EditorMoveState = EditorMoveState.Move;
+                    StartObjectMove();
+                }
+                if (UserInput.IsPressed(UserCommand.EditorRotate))
+                {
+                    EditorMoveState = EditorMoveState.Rotate;
                     StartObjectMove();
                 }
                 if (UserInput.IsPressed(UserCommand.EditorMoveHandle))
                 {
+                    EditorMoveState = EditorMoveState.Move;
                     StartHandleMove();
                 }
             }
             if (EditorState == EditorState.HandleMoving)
             {
                 if (UserInput.IsPressed(UserCommand.EditorMove))
                 {
-                    CancelHandleMove();
-                    StartObjectMove();
+                    EditorMoveState = EditorMoveState.Move;
+                }
+                if (UserInput.IsPressed(UserCommand.EditorRotate))
+                {
+                    EditorMoveState = EditorMoveState.Rotate;
                 }
                 if (UserInput.IsPressed(UserCommand.EditorCancel))
                 {
@@ -180,10 +186,13 @@ public void Update(GameTime gameTime)
             }
             if (EditorState == EditorState.ObjectMoving)
             {
-                if (UserInput.IsPressed(UserCommand.EditorMoveHandle))
+                if (UserInput.IsPressed(UserCommand.EditorMove))
                 {
-                    CancelObjectMove();
-                    StartHandleMove();
+                    EditorMoveState = EditorMoveState.Move;
+                }
+                if (UserInput.IsPressed(UserCommand.EditorRotate))
+                {
+                    EditorMoveState = EditorMoveState.Rotate;
                 }
                 if (UserInput.IsPressed(UserCommand.EditorCancel))
                 {
@@ -315,7 +324,7 @@ Matrix GetMovingMatrix(in WorldPosition originalPosition, in WorldPosition handl
             var handle = handleOriginalPosition ?? originalPosition;
             var xnaMatrix = originalPosition.XNAMatrix;
 
-            if (UserInput.IsDown(UserCommand.EditorLockRotation))
+            if (EditorMoveState == EditorMoveState.Rotate)
             {
                 var distance = WorldLocation.GetDistance(handle.WorldLocation, CursorLocation);
                 distance.Z *= -1;
@@ -337,8 +346,12 @@ Matrix GetMovingMatrix(in WorldPosition originalPosition, in WorldPosition handl
                     handleMatrix.Translation += translation;
                     handlePosition.XNAMatrix = handleMatrix;
                 }
+
+                DeltaX = 0;
+                DeltaY = MathHelper.ToDegrees(angle);
+                DeltaZ = 0;
             }
-            else
+            else if (EditorMoveState == EditorMoveState.Move)
             {
                 var distance = WorldLocation.GetDistance(originalPosition.WorldLocation, CursorLocation);
                 distance.Z *= -1;
@@ -461,16 +474,9 @@ void UndoRedo(UndoDataSet undoDataSet, bool undo)
             }
             else if (undoDataSet.UndoEvent == UndoEvent.WorldObjectChanged)
             {
-                if (undo)
-                {
-                    var newPosition = new WorldPosition(undoDataSet.ChangedStaticShape.Location);
-                    undoDataSet.ChangedStaticShape.Location.CopyFrom(undoDataSet.OldPosition);
-                    undoDataSet.OldPosition.CopyFrom(newPosition);
-                }
-                else
-                {
-
-                }
+                var newPosition = new WorldPosition(undoDataSet.ChangedStaticShape.Location);
+                undoDataSet.ChangedStaticShape.Location.CopyFrom(undoDataSet.OldPosition);
+                undoDataSet.OldPosition.CopyFrom(newPosition);
             }
         }
 
@@ -500,8 +506,8 @@ void ApplyObjectMove()
                 TileZ = MovedObject.Location.TileZ,
                 Uid = MovedObject.Uid,
                 ChangedStaticShape = MovedObject,
-                OldPosition = MovedObjectOriginalPosition,
-                MovedWithRespectTo = HandlePosition ?? MovedObject.Location,
+                OldPosition = new WorldPosition(MovedObjectOriginalPosition),
+                MoveOrigin = HandlePosition,
             });
             RedoStack.Clear();
 
@@ -593,7 +599,7 @@ public class UndoDataSet
         public int Uid;
         public StaticShape ChangedStaticShape;
         public WorldPosition OldPosition;
-        public WorldPosition MovedWithRespectTo;
+        public WorldPosition MoveOrigin;
         public Orts.Formats.Msts.WorldObject OldWorldObject;
         public Orts.Formats.Msts.WorldObject NewWorldObject;
 
@@ -620,6 +626,12 @@ public enum EditorState
         HandleMoving,
     }
 
+    public enum EditorMoveState
+    {
+        Move,
+        Rotate,
+    }
+
     public class SceneViewerHwndHost : HwndHost
     {
         readonly IntPtr HwndChildHandle;

Source/ORTS.Common/Coordinates.cs

@@ -186,7 +186,7 @@ public void CopyFrom(WorldPosition copy)
         {
             TileX = copy.TileX;
             TileZ = copy.TileZ;
-            Location = copy.Location;
+            XNAMatrix = copy.XNAMatrix;
         }
     }
 

Source/ORTS.Common/Input/UserCommand.cs

@@ -260,6 +260,6 @@ public enum UserCommand
         [GetString("Editor Move Handle")] EditorMoveHandle,
         [GetString("Editor Move Orthogonal")] EditorLockOrthogonal,
         [GetString("Editor Move Orthogonal")] EditorLockElevation,
-        [GetString("Editor Move Orthogonal")] EditorLockRotation,
+        [GetString("Editor Move Orthogonal")] EditorRotate,
     }
 }

Source/ORTS.Settings/InputSettings.cs

@@ -547,7 +547,7 @@ static void InitializeCommands(UserCommandInput[] Commands)
             Commands[(int)UserCommand.EditorMoveHandle] = new UserCommandKeyInput(Keys.M, KeyModifiers.Alt);
             Commands[(int)UserCommand.EditorLockOrthogonal] = new UserCommandModifierInput(KeyModifiers.Shift);
             Commands[(int)UserCommand.EditorLockElevation] = new UserCommandModifierInput(KeyModifiers.Control);
-            Commands[(int)UserCommand.EditorLockRotation] = new UserCommandKeyInput(Keys.R);
+            Commands[(int)UserCommand.EditorRotate] = new UserCommandKeyInput(Keys.R);
         }
         #endregion