Containers: reject save and warn player during a container load/unload operation

Author: Csantucci

Source/Documentation/Manual/driving.rst

@@ -1253,7 +1253,8 @@ this occurs when the wagon is at the boundary of the crane displacement range; t
 move the wagon towards the inside of the crane displacement range and stop the train. The crane 
 will then continue its loading mission up to the end.
 
-It is advised not to perform a Save (key ``<F2>``) when a loading or unloading operation is ongoing.
+Saves (key ``<F2>``) are rejected and a message appears on the display when a loading 
+or unloading operation is ongoing.
 
 .. _driving-autopilot:
 

Source/Orts.Simulation/Simulation/Container.cs

@@ -273,6 +273,7 @@ public class ContainerManager
         public Dictionary<int, ContainerHandlingItem> ContainerHandlingItems;
         public List<Container> Containers;
         public static Dictionary<string, Container> LoadedContainers = new Dictionary<string, Container>();
+        public static int ActiveOperationsCounter;
 
         public ContainerManager(Simulator simulator)
         {
@@ -907,6 +908,8 @@ public void Update()
                         MoveY = false;
                         Status = ContainerStationStatus.Idle;
                         MSTSWagon.RefillProcess.OkToRefill = false;
+                        ContainerManager.ActiveOperationsCounter--;
+                        if (ContainerManager.ActiveOperationsCounter < 0) ContainerManager.ActiveOperationsCounter = 0;
                     }
                     break;
                 default:
@@ -916,6 +919,7 @@ public void Update()
 
         public void PrepareForUnload(FreightAnimationDiscrete linkedFreightAnimation)
         {
+            ContainerManager.ActiveOperationsCounter++;
             LinkedFreightAnimation = linkedFreightAnimation;
             RelativeContainerPosition = new Matrix();
             LinkedFreightAnimation.Wagon.WorldPosition.NormalizeTo(ShapePosition.TileX, ShapePosition.TileZ);
@@ -934,6 +938,7 @@ public void PrepareForUnload(FreightAnimationDiscrete linkedFreightAnimation)
 
         public void PrepareForLoad(FreightAnimationDiscrete linkedFreightAnimation)
         {
+            ContainerManager.ActiveOperationsCounter++;
             LinkedFreightAnimation = linkedFreightAnimation;
             SelectedStackLocationIndex = SelectLoadPosition();
             if (SelectedStackLocationIndex == -1) return;

Source/RunActivity/Viewer3D/Processes/GameStateRunActivity.cs

@@ -343,6 +343,12 @@ void Start(UserSettings settings, string acttype, string[] args)
         public static void Save()
         {
             if (MPManager.IsMultiPlayer() && !MPManager.IsServer()) return; //no save for multiplayer sessions yet
+            if (ContainerManager.ActiveOperationsCounter > 0)
+                // don't save if performing a container load/unload
+            {
+                Simulator.Confirmer.Message(ConfirmLevel.Warning, Viewer.Catalog.GetString("Game save is not allowed during container load/unload"));
+                return;
+            }
             // Prefix with the activity filename so that, when resuming from the Menu.exe, we can quickly find those Saves 
             // that are likely to match the previously chosen route and activity.
             // Append the current date and time, so that each file is unique.