Fix emergency dump valve not deactivating and add sound trigger

Author: cesarBLG

Source/Documentation/Manual/physics.rst

@@ -2945,6 +2945,7 @@ MaxAuxilaryChargingRate and EmergencyResChargingRate.
    single: BrakePipeVolume
    single: ORTSEmergencyValveActuationRate
    single: ORTSEmergencyDumpValveRate
+   single: ORTSEmergencyDumpValveTimer
    single: ORTSMainResPipeAuxResCharging
    single: ORTSMainResChargingRate
    single: ORTSEngineBrakeReleaseRate
@@ -2975,6 +2976,9 @@ MaxAuxilaryChargingRate and EmergencyResChargingRate.
   emergency mode.
 - ``Wagon(ORTSEmergencyDumpValveRate)``-- Rate at which BP is locally discharged
   at every wagon during an emergency brake application.
+- ``Wagon(ORTSEmergencyDumpValveTimer)``-- Timer for emergency dump valve to close
+  after it is activated. If set to 0, it will close as soon as BP is discharged.
+  Default value will prevent BP from being charged for 2 minutes.
 - ``Wagon(ORTSMainResPipeAuxResCharging`` -- Boolean value that indicates,
   for twin pipe systems, if the main reservoir pipe is used for charging the auxiliary
   reservoirs. If set to false, the main reservoir pipe will not be used

Source/Documentation/Manual/sound.rst

@@ -403,6 +403,9 @@ Trigger       Function
 243           GenericItem2Off
 =========     =====================================
 
+Trigger 252 is activated when the braking system detects an
+emergency brake application and starts venting air from the Brake Pipe.
+
 Variable Triggers
 -----------------
 

Source/Orts.Simulation/Common/Events.cs

@@ -255,6 +255,7 @@ public enum Event
 
         OverchargeBrakingOn,
         OverchargeBrakingOff,
+        EmergencyVentValveOn,
 
         // Cruise Control
         LeverFromZero,
@@ -523,6 +524,7 @@ public static Event From(Source source, int eventID)
 
                         case 250: return Event.OverchargeBrakingOn;
                         case 251: return Event.OverchargeBrakingOff;
+                        case 252: return Event.EmergencyVentValveOn;
 
                         // Cruise Control
                         case 298: return Event.LeverFromZero;

Source/Orts.Simulation/Simulation/RollingStocks/SubSystems/Brakes/MSTS/AirSinglePipe.cs

@@ -52,6 +52,8 @@ public class AirSinglePipe : MSTSBrakeSystem
         protected float BrakeInsensitivityPSIpS = 0.07f;
         protected float EmergencyValveActuationRatePSIpS = 0;
         protected float EmergencyDumpValveRatePSIpS = 0;
+        protected float EmergencyDumpValveTimerS = 120;
+        protected float? EmergencyDumpStartTime;
         protected float EmergResChargingRatePSIpS = 1.684f;
         protected float EmergAuxVolumeRatio = 1.4f;
         protected string DebugType = string.Empty;
@@ -118,6 +120,7 @@ public override void InitializeFromCopy(BrakeSystem copy)
             BrakeInsensitivityPSIpS = thiscopy.BrakeInsensitivityPSIpS;
             EmergencyValveActuationRatePSIpS = thiscopy.EmergencyValveActuationRatePSIpS;
             EmergencyDumpValveRatePSIpS = thiscopy.EmergencyDumpValveRatePSIpS;
+            EmergencyDumpValveTimerS = thiscopy.EmergencyDumpValveTimerS;
             EmergResChargingRatePSIpS = thiscopy.EmergResChargingRatePSIpS;
             EmergAuxVolumeRatio = thiscopy.EmergAuxVolumeRatio;
             TwoPipes = thiscopy.TwoPipes;
@@ -235,6 +238,7 @@ public override void Parse(string lowercasetoken, STFReader stf)
                 case "wagon(ortsbrakeinsensitivity": BrakeInsensitivityPSIpS = stf.ReadFloatBlock(STFReader.UNITS.PressureRateDefaultPSIpS, 0.07f); break;
                 case "wagon(ortsemergencyvalveactuationrate": EmergencyValveActuationRatePSIpS = stf.ReadFloatBlock(STFReader.UNITS.PressureRateDefaultPSIpS, 15f); break;
                 case "wagon(ortsemergencydumpvalverate": EmergencyDumpValveRatePSIpS = stf.ReadFloatBlock(STFReader.UNITS.PressureRateDefaultPSIpS, 15f); break;
+                case "wagon(ortsemergencydumpvalvetimer": EmergencyDumpValveTimerS = stf.ReadFloatBlock(STFReader.UNITS.Time, 120.0f); break;
                 case "wagon(ortsmainrespipeauxrescharging": MRPAuxResCharging = this is AirTwinPipe && stf.ReadBoolBlock(true); break;
             }
         }
@@ -346,6 +350,7 @@ public override void LocoInitializeMoving() // starting conditions when starting
 
         public void UpdateTripleValveState(float elapsedClockSeconds)
         {
+            var prevState = TripleValveState;
             var valveType = (Car as MSTSWagon).BrakeValve;
             if (valveType == MSTSWagon.BrakeValveType.Distributor)
             {
@@ -377,6 +382,15 @@ public void UpdateTripleValveState(float elapsedClockSeconds)
             {
                 TripleValveState = ValveState.Release;
             }
+            if (TripleValveState == ValveState.Emergency)
+            {
+                if (prevState != ValveState.Emergency)
+                {
+                    EmergencyDumpStartTime = (float)Car.Simulator.GameTime;
+                    Car.SignalEvent(Event.EmergencyVentValveOn);
+                }
+            }
+            else EmergencyDumpStartTime = null;
             prevBrakePipePressurePSI = BrakeLine1PressurePSI;
         }
 
@@ -446,7 +460,15 @@ public override void Update(float elapsedClockSeconds)
                         EmergResPressurePSI -= dp;
                         AuxResPressurePSI += dp * EmergAuxVolumeRatio;
                     }
-                    if (EmergencyDumpValveRatePSIpS > 0)
+                    if (EmergencyDumpValveTimerS == 0)
+                    {
+                        if (BrakeLine1PressurePSI < 1) EmergencyDumpStartTime = null;
+                    }
+                    else if (Car.Simulator.GameTime - EmergencyDumpStartTime > EmergencyDumpValveTimerS)
+                    {
+                        EmergencyDumpStartTime = null;
+                    }
+                    if (EmergencyDumpValveRatePSIpS > 0 && EmergencyDumpStartTime != null)
                     {
                         BrakeLine1PressurePSI -= elapsedClockSeconds * EmergencyDumpValveRatePSIpS;
                         if (BrakeLine1PressurePSI < 0)