File tree Expand file tree Collapse file tree 3 files changed +35
-35
lines changed
Expand file tree Collapse file tree 3 files changed +35
-35
lines changed Original file line number Diff line number Diff line change @@ -55,15 +55,15 @@ All new features must result in the following three things existing:
5555These things must be done in the required order:
5656
57571 . The road-map card cannot be approved without the completed discussion
58- 2 . The pull request cannot be pending (non-draft) without the completed discussion
58+ 2 . The pull request cannot be ready for review without the completed discussion
59593 . The pull request cannot be approved without the approved road-map card
6060
6161Our recommended order is:
6262
63631 . Create road-map card
64642 . Create forum discussion
65653 . Create draft pull request
66- 4 . When discussion is completed, pull request can be pending
66+ 4 . When discussion is completed, pull request can be ready for review
67675 . When road-map card is approved, pull request can be approved (if code review is okay)
6868
6969** Note:** A blueprint can be used by a seasoned Open Rails developer in place of a road-map card.
@@ -130,7 +130,7 @@ Your code should be fixing exactly one bug or adding a single new feature; mixin
130130
131131### Different versions of code
132132
133- When your pull request is draft or pending , it will not be included in any version of Open Rails unless:
133+ When your pull request is draft or ready for review , it will not be included in any version of Open Rails unless:
134134
135135* You are a member of the core team
136136* A member of the core team adds a particular label
Original file line number Diff line number Diff line change 11digraph {
2- roadmapPending [label =" Road-map (pending )" ]
2+ roadmapCreated [label =" Road-map (created )" ]
33 roadmapApproved [label =" Road-map (approved)" ]
44 discussion [label =" Discussion (1 week)" ]
55 prDraft [label =" Pull request (draft)" ] [style =dashed]
6- prPending [label =" Pull request (pending )" ]
6+ prReadyForReview [label =" Pull request (ready for review )" ]
77 prApproved [label =" Pull request (approved)" ]
8- roadmapPending -> roadmapApproved
9- discussion -> {roadmapApproved,prPending } -> prApproved
10- roadmapPending -> discussion -> prDraft -> prPending [style =dashed]
8+ roadmapCreated -> roadmapApproved
9+ discussion -> {roadmapApproved,prReadyForReview } -> prApproved
10+ roadmapCreated -> discussion -> prDraft -> prReadyForReview [style =dashed]
1111}
You can’t perform that action at this time.
0 commit comments