Skip to content

Commit 2f1cdf2

Browse files
author
Chris Jakeman
committed
Removed option CircularSpeedGauge
Equivalent to always being true. Also made changes to Manual missing from previous commit
1 parent 760ba43 commit 2f1cdf2

File tree

8 files changed

+73
-97
lines changed

8 files changed

+73
-97
lines changed

‎Source/Documentation/Manual/cabs.rst‎

Lines changed: 44 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,50 @@ OR supports with a high degree of compatibility all functions available in
1616
MSTS for 2D cabs, and provides some significant enhancements described in the
1717
next paragraphs.
1818

19-
OR adds support for the ETCS circular speed gauge, as described
20-
:ref:`here <options-etcs>`.
19+
20+
ETCS circular speed gauge
21+
-------------------------
22+
23+
When this option is selected, it is possible to add to the cabview a
24+
circular speed gauge accordingly to the European standard train control
25+
system ETCS.
26+
27+
.. image:: images/options-etcs.png
28+
:scale: 60 %
29+
:align: center
30+
31+
32+
.. admonition:: For content developers
33+
34+
The gauge is added by the insertion of a block like the following
35+
into the .cvf file::
36+
37+
Digital (
38+
Type ( SPEEDOMETER DIGITAL )
39+
Style ( NEEDLE )
40+
Position ( 160 255 56 56 )
41+
ScaleRange ( 0 250 )
42+
Units ( KM_PER_HOUR )
43+
)
44+
45+
It is also possible to display the full ETCS display using the following block
46+
instead::
47+
48+
ScreenDisplay (
49+
Type ( ORTS_ETCS SCREEN_DISPLAY )
50+
Position ( 280 272 320 240 )
51+
Units ( KM_PER_HOUR )
52+
Parameters (
53+
Mode FullSize
54+
)
55+
)
56+
57+
The following DMI size variants are available: FullSize (displays the whole DMI), SpeedArea
58+
(displays only the left part with information about distance and speed) and PlanningArea
59+
(displays only the planning area and navigation buttons).
60+
61+
The information displayed in the DMI is controlled via the TCS script. For more details,
62+
see :ref:`C# engine scripting - Train Control System <features-scripting-tcs>`.
2163

2264
.. _cabs-battery-switch:
2365

‎Source/Documentation/Manual/options.rst‎

Lines changed: 0 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -606,52 +606,6 @@ When this option is selected, when OR is loading the shape (.s) files it
606606
will report errors in syntax and structure (even if these don't cause
607607
runtime errors) in the :ref:`Log file <driving-logfile>` ``OpenRailsLog.txt`` on the desktop.
608608

609-
.. _options-etcs:
610-
611-
ETCS circular speed gauge
612-
-------------------------
613-
614-
When this option is selected, it is possible to add to the cabview a
615-
circular speed gauge accordingly to the European standard train control
616-
system ETCS.
617-
618-
.. image:: images/options-etcs.png
619-
:scale: 60 %
620-
:align: center
621-
622-
623-
.. admonition:: For content developers
624-
625-
The gauge is added by the insertion of a block like the following
626-
into the .cvf file::
627-
628-
Digital (
629-
Type ( SPEEDOMETER DIGITAL )
630-
Style ( NEEDLE )
631-
Position ( 160 255 56 56 )
632-
ScaleRange ( 0 250 )
633-
Units ( KM_PER_HOUR )
634-
)
635-
636-
It is also possible to display the full ETCS display using the following block
637-
instead::
638-
639-
ScreenDisplay (
640-
Type ( ORTS_ETCS SCREEN_DISPLAY )
641-
Position ( 280 272 320 240 )
642-
Units ( KM_PER_HOUR )
643-
Parameters (
644-
Mode FullSize
645-
)
646-
)
647-
648-
The following DMI size variants are available: FullSize (displays the whole DMI), SpeedArea
649-
(displays only the left part with information about distance and speed) and PlanningArea
650-
(displays only the planning area and navigation buttons).
651-
652-
The information displayed in the DMI is controlled via the TCS script. For more details,
653-
see :ref:`C# engine scripting - Train Control System <features-scripting-tcs>`.
654-
655609
Load day/night textures only when needed
656610
----------------------------------------
657611

@@ -727,14 +681,6 @@ lat/lon rectangle corresponding to the arid zone of North America (lat from
727681
The randomization is not performed either if the activity contains weather
728682
change events.
729683

730-
Extend object maximum viewing distance to horizon
731-
-------------------------------------------------
732-
733-
With this option selected, all objects viewable up to the viewing distance
734-
defined in the Video Options are displayed. As a default ORTS only
735-
displays objects up to 2000 m distance. Selecting this option improves
736-
display quality but may reduce frame rate.
737-
738684
.. _options-dds-textures:
739685

740686
Load DDS textures in preference to ACE

‎Source/Menu/Options.Designer.cs‎

Lines changed: 18 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Source/Menu/Options.cs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,6 @@ orderby folder.Key
319319
trackLODBias_ValueChanged(null, null);
320320
checkConditionalLoadOfNightTextures.Checked = Settings.ConditionalLoadOfDayOrNightTextures;
321321
checkSignalLightGlow.Checked = Settings.SignalLightGlow;
322-
checkCircularSpeedGauge.Checked = Settings.CircularSpeedGauge;
323322
checkPreferDDSTexture.Checked = Settings.PreferDDSTexture;
324323
checkUseLocationPassingPaths.Checked = Settings.UseLocationPassingPaths;
325324
checkUseMSTSEnv.Checked = Settings.UseMSTSEnv;
@@ -514,7 +513,6 @@ void buttonOK_Click(object sender, EventArgs e)
514513
Settings.LODBias = trackLODBias.Value;
515514
Settings.ConditionalLoadOfDayOrNightTextures = checkConditionalLoadOfNightTextures.Checked;
516515
Settings.SignalLightGlow = checkSignalLightGlow.Checked;
517-
Settings.CircularSpeedGauge = checkCircularSpeedGauge.Checked;
518516
Settings.PreferDDSTexture = checkPreferDDSTexture.Checked;
519517
Settings.UseLocationPassingPaths = checkUseLocationPassingPaths.Checked;
520518
Settings.UseMSTSEnv = checkUseMSTSEnv.Checked;

‎Source/Menu/Options.resx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,4 +123,7 @@
123123
<metadata name="bindingSourceContent.TrayLocation" type="System.Drawing.Point, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
124124
<value>114, 17</value>
125125
</metadata>
126+
<metadata name="toolTip1.TrayLocation" type="System.Drawing.Point, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
127+
<value>17, 17</value>
128+
</metadata>
126129
</root>

‎Source/ORTS.Settings/UserSettings.cs‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -308,10 +308,6 @@ public enum DirectXFeature
308308
[Default(false)]
309309
public bool AuxActionEnabled { get; set; }
310310
[Default(false)]
311-
public bool CircularSpeedGauge { get; set; }
312-
[Default(false)]
313-
public bool LODViewingExtention { get; set; }
314-
[Default(false)]
315311
public bool PreferDDSTexture { get; set; }
316312
[Default(false)]
317313
public bool UseLocationPassingPaths { get; set; }

‎Source/RunActivity/Viewer3D/RollingStock/MSTSLocomotiveViewer.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1190,7 +1190,7 @@ public CabRenderer(Viewer viewer, MSTSLocomotive car)
11901190
if (digital != null)
11911191
{
11921192
CabViewDigitalRenderer cvdr;
1193-
if (viewer.Settings.CircularSpeedGauge && digital.ControlStyle == CABViewControlStyles.NEEDLE)
1193+
if (digital.ControlStyle == CABViewControlStyles.NEEDLE)
11941194
cvdr = new CircularSpeedGaugeRenderer(viewer, car, digital, _Shader);
11951195
else
11961196
cvdr = new CabViewDigitalRenderer(viewer, car, digital, _Shader);
@@ -1311,7 +1311,7 @@ public CabRenderer(Viewer viewer, MSTSLocomotive car, CabViewFile CVFFile) //use
13111311
if (digital != null)
13121312
{
13131313
CabViewDigitalRenderer cvdr;
1314-
if (viewer.Settings.CircularSpeedGauge && digital.ControlStyle == CABViewControlStyles.NEEDLE)
1314+
if (digital.ControlStyle == CABViewControlStyles.NEEDLE)
13151315
cvdr = new CircularSpeedGaugeRenderer(viewer, car, digital, _Shader);
13161316
else
13171317
cvdr = new CabViewDigitalRenderer(viewer, car, digital, _Shader);

‎Source/RunActivity/Viewer3D/Shapes.cs‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2125,8 +2125,12 @@ public void PrepareFrame(RenderFrame frame, WorldPosition location, Matrix[] ani
21252125
? lodControl.DistanceLevels[lodControl.DistanceLevels.Length - 1]
21262126
: displayDetail;
21272127

2128-
// If set, extend the lowest LOD to the maximum viewing distance.
2129-
if (Viewer.Settings.LODViewingExtention && displayDetailLevel == lodControl.DistanceLevels.Length - 1)
2128+
// Extend the lowest LOD to the maximum viewing distance.
2129+
// Set to MaxValue so that an object never disappears.
2130+
// Many MSTS objects had a LOD of 2km which is the maximum distance that MSTS can handle.
2131+
// Open Rails can handle greater distances, so we override the lowest-detail LOD to make sure OR shows shapes further away than 2km.
2132+
// See http://www.elvastower.com/forums/index.php?/topic/35301-menu-options/page__view__findpost__p__275531
2133+
if (displayDetailLevel == lodControl.DistanceLevels.Length - 1)
21302134
distanceDetail.ViewingDistance = float.MaxValue;
21312135

21322136
for (var i = 0; i < displayDetail.SubObjects.Length; i++)

0 commit comments

Comments
 (0)