Add check to prevent crashes when signal scripts use a bad draw state

cesarBLG · cesarBLG · commit 223aae66e776 · 2022-08-11T16:04:02.000+02:00
diff --git a/Source/Orts.Simulation/Simulation/RollingStocks/SubSystems/TrainControlSystem.cs b/Source/Orts.Simulation/Simulation/RollingStocks/SubSystems/TrainControlSystem.cs
@@ -660,7 +660,7 @@ SignalFeatures NextGenericSignalFeatures(string signalFunctionTypeName, int item
 
                 var functionHead = trainSignal.SignalObject.SignalHeads.Find(head => head.ORTSsigFunctionIndex == fn_type);
                 signalTypeName = functionHead.SignalTypeName;
-                if (functionHead.draw_state >= 0)
+                if (functionHead.signalType.DrawStates.Any(d => d.Value.Index == functionHead.draw_state))
                 {
                     drawStateName = functionHead.signalType.DrawStates.First(d => d.Value.Index == functionHead.draw_state).Value.Name;
                 }

Original file line number	Diff line number	Diff line change
`@@ -660,7 +660,7 @@ SignalFeatures NextGenericSignalFeatures(string signalFunctionTypeName, int item`
`660`	`660`
`661`	`661`	`var functionHead = trainSignal.SignalObject.SignalHeads.Find(head => head.ORTSsigFunctionIndex == fn_type);`
`662`	`662`	`signalTypeName = functionHead.SignalTypeName;`
`663`		`- if (functionHead.draw_state >= 0)`
	`663`	`+ if (functionHead.signalType.DrawStates.Any(d => d.Value.Index == functionHead.draw_state))`
`664`	`664`	`{`
`665`	`665`	`drawStateName = functionHead.signalType.DrawStates.First(d => d.Value.Index == functionHead.draw_state).Value.Name;`
`666`	`666`	`}`