transform, transformAsync: Return empty Uint8Array by default for non-streams
#70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… non-streams When `process` and `finish` return undefined for non-stream objects, return an empty Uint8Array instead of undefined, to be consistent with the streaming case where `await readToEnd(transform(stream))` returns an empty Uint8Array as well.
larabr
force-pushed
the
main
branch
2 times, most recently
from
d0f6ef9 to
d8efe87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
processandfinishreturn undefined for non-stream objects, return an empty Uint8Array instead of undefined, to be consistent with the streaming case whereawait readToEnd(transform(stream))returns an empty Uint8Array as well.Also to simplify the TS types in #68.