fix: handle routes-manifests without staticRoutes defined (#1120)

* fix: handle missing routes in manifest

* chore: add test

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Author: ascorbic

src/helpers/redirects.ts

@@ -139,8 +139,8 @@ export const generateRedirects = async ({
       )
     }
   })
-  // Add rewrites for all static SSR routes
-  staticRoutes.forEach((route) => {
+  // Add rewrites for all static SSR routes. This is Next 12+
+  staticRoutes?.forEach((route) => {
     if (staticRoutePaths.has(route.page) || isApiRoute(route.page)) {
       // Prerendered static routes are either handled by the CDN or are ISR
       return

src/helpers/types.ts

@@ -46,7 +46,7 @@ export interface RoutesManifest {
   redirects: Redirect[]
   headers: Header[]
   dynamicRoutes: DynamicRoute[]
-  staticRoutes: StaticRoute[]
+  staticRoutes?: StaticRoute[]
   dataRoutes: DataRoute[]
   i18n: I18n
   rewrites: Rewrites

test/index.js

@@ -409,6 +409,16 @@ describe('onBuild()', () => {
     expect(readFileSync(handlerFile, 'utf8')).toMatch(`require("../../../.next/required-server-files.json")`)
     expect(readFileSync(odbHandlerFile, 'utf8')).toMatch(`require("../../../.next/required-server-files.json")`)
   })
+
+  test('handles empty routesManifest.staticRoutes', async () => {
+    await moveNextDist()
+    const manifestPath = path.resolve('.next/routes-manifest.json')
+    const routesManifest = await readJson(manifestPath)
+    delete routesManifest.staticRoutes
+    await writeJSON(manifestPath, routesManifest)
+    // The function is supposed to return undefined, but we want to check if it throws
+    expect(await plugin.onBuild(defaultArgs)).toBeUndefined()
+  })
 })
 
 describe('onPostBuild', () => {