fix: simplified dryRun input

Author: kekcleader

gateway/resolver/arguments.go

@@ -170,27 +170,3 @@ func validateSortBy(items []unstructured.Unstructured, fieldPath string) error {
 
 	return nil
 }
-
-func getDryRunArg(args map[string]interface{}, key string, required bool) ([]string, error) {
-	val, exists := args[key]
-	if !exists {
-		if required {
-			err := errors.New("missing required argument: " + key)
-			log.Error().Err(err).Msg(key + " argument is required")
-			return nil, err
-		}
-		return nil, nil
-	}
-
-	dryRun, ok := val.(bool)
-	if !ok {
-		err := errors.New("invalid type for dryRun argument: expected boolean")
-		log.Error().Err(err).Msg("dryRun argument must be a boolean")
-		return nil, err
-	}
-
-	if dryRun {
-		return []string{"All"}, nil
-	}
-	return nil, nil
-}

gateway/resolver/resolver.go

@@ -237,10 +237,14 @@ func (r *Service) CreateItem(gvk schema.GroupVersionKind, scope v1.ResourceScope
 			return nil, errors.New("object metadata.name is required")
 		}
 
-		dryRun, err := getDryRunArg(p.Args, DryRunArg, false)
+		dryRunBool, err := getBoolArg(p.Args, DryRunArg, false)
 		if err != nil {
 			return nil, err
 		}
+		dryRun := []string{}
+		if dryRunBool {
+			dryRun = []string{"All"}
+		}
 
 		if err := r.runtimeClient.Create(ctx, obj, &client.CreateOptions{DryRun: dryRun}); err != nil {
 			log.Error().Err(err).Msg("Failed to create object")
@@ -292,10 +296,14 @@ func (r *Service) UpdateItem(gvk schema.GroupVersionKind, scope v1.ResourceScope
 			return nil, err
 		}
 
-		dryRun, err := getDryRunArg(p.Args, DryRunArg, false)
+		dryRunBool, err := getBoolArg(p.Args, DryRunArg, false)
 		if err != nil {
 			return nil, err
 		}
+		dryRun := []string{}
+		if dryRunBool {
+			dryRun = []string{"All"}
+		}
 
 		// Apply the merge patch to the existing object
 		patch := client.RawPatch(types.MergePatchType, patchData)
@@ -335,10 +343,14 @@ func (r *Service) DeleteItem(gvk schema.GroupVersionKind, scope v1.ResourceScope
 			obj.SetNamespace(namespace)
 		}
 
-		dryRun, err := getDryRunArg(p.Args, DryRunArg, false)
+		dryRunBool, err := getBoolArg(p.Args, DryRunArg, false)
 		if err != nil {
 			return nil, err
 		}
+		dryRun := []string{}
+		if dryRunBool {
+			dryRun = []string{"All"}
+		}
 
 		if err := r.runtimeClient.Delete(ctx, obj, &client.DeleteOptions{DryRun: dryRun}); err != nil {
 			log.Error().Err(err).Msg("Failed to delete object")