feat: introduced testlogger, changed some tests to use testlogger; pass log by APIBindingReconciler

Author: kekcleader

listener/controller/apibinding_controller_test.go

@@ -12,7 +12,7 @@ import (
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
-	"github.com/openmfp/golang-commons/logger"
+	"github.com/openmfp/golang-commons/logger/testlogger"
 	controllerRuntimeMocks "github.com/openmfp/kubernetes-graphql-gateway/gateway/resolver/mocks"
 	apischemaMocks "github.com/openmfp/kubernetes-graphql-gateway/listener/apischema/mocks"
 	clusterpathMocks "github.com/openmfp/kubernetes-graphql-gateway/listener/clusterpath/mocks"
@@ -59,6 +59,7 @@ func TestAPIBindingReconciler_Reconcile(t *testing.T) {
 		},
 	}
 
+	log := testlogger.New().HideLogOutput().Logger
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			ioHandler := workspacefileMocks.NewMockIOHandler(t)
@@ -70,12 +71,8 @@ func TestAPIBindingReconciler_Reconcile(t *testing.T) {
 				tt.mockSetup(ioHandler, discoveryFactory, apiSchemaResolver, clusterPathResolver)
 			}
 
-			loggerCfg := logger.DefaultConfig()
-			loggerCfg.Name = "test-apibinding-reconciler"
-			log, err := logger.New(loggerCfg)
-			assert.NoError(t, err)
 			r := controller.NewAPIBindingReconciler(ioHandler, discoveryFactory, apiSchemaResolver, clusterPathResolver, log)
-			_, err = r.Reconcile(context.Background(), ctrl.Request{ClusterName: tt.clusterName})
+			_, err := r.Reconcile(context.Background(), ctrl.Request{ClusterName: tt.clusterName})
 			assert.Equal(t, tt.err, err)
 		})
 	}

listener/kcp/reconciler_factory.go

@@ -59,7 +59,7 @@ func NewReconciler(appCfg config.Config, opts ReconcilerOpts, restcfg *rest.Conf
 		return newStandardReconciler(opts, discoveryInterface, preReconcileFunc, log)
 	}
 
-	return newKcpReconciler(opts, restcfg, discoverFactory)
+	return newKcpReconciler(opts, restcfg, discoverFactory, log)
 }
 
 func newStandardReconciler(
@@ -118,7 +118,7 @@ func PreReconcile(
 	return nil
 }
 
-func newKcpReconciler(opts ReconcilerOpts, restcfg *rest.Config, newDiscoveryFactoryFunc func(cfg *rest.Config) (*discoveryclient.FactoryProvider, error)) (CustomReconciler, error) {
+func newKcpReconciler(opts ReconcilerOpts, restcfg *rest.Config, newDiscoveryFactoryFunc func(cfg *rest.Config) (*discoveryclient.FactoryProvider, error), log *logger.Logger) (CustomReconciler, error) {
 	ioHandler, err := workspacefile.NewIOHandler(opts.OpenAPIDefinitionsPath)
 	if err != nil {
 		return nil, errors.Join(ErrCreateIOHandler, err)
@@ -134,8 +134,7 @@ func newKcpReconciler(opts ReconcilerOpts, restcfg *rest.Config, newDiscoveryFac
 		return nil, errors.Join(ErrCreateDiscoveryClient, err)
 	}
 
-	// TODO: pass logger here as well if needed by APIBindingReconciler?
 	return controller.NewAPIBindingReconciler(
-		ioHandler, df, apischema.NewResolver(), pr /* log */, nil,
+		ioHandler, df, apischema.NewResolver(), pr, log,
 	), nil
 }

listener/kcp/reconciler_factory_test.go

@@ -15,7 +15,7 @@ import (
 	"k8s.io/client-go/rest"
 	"sigs.k8s.io/controller-runtime/pkg/client/fake"
 
-	"github.com/openmfp/golang-commons/logger"
+	"github.com/openmfp/golang-commons/logger/testlogger"
 	"github.com/openmfp/kubernetes-graphql-gateway/listener/apischema"
 	"github.com/openmfp/kubernetes-graphql-gateway/listener/discoveryclient"
 	"github.com/openmfp/kubernetes-graphql-gateway/listener/workspacefile"
@@ -81,10 +81,7 @@ func TestNewReconciler(t *testing.T) {
 
 			fakeClient := fake.NewClientBuilder().WithScheme(scheme).Build()
 
-			loggerCfg := logger.DefaultConfig()
-			loggerCfg.Name = "test-reconciler"
-			log, err := logger.New(loggerCfg)
-			assert.NoError(t, err)
+			log := testlogger.New().HideLogOutput().Logger
 
 			reconciler, err := NewReconciler(appCfg, ReconcilerOpts{
 				Config:                 tc.cfg,