fix(encoding): prevent accept encoding from being passed via proxy #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the /managed endpoint bad encoding
andreaskienle
approved these changes
Nov 25, 2025
Contributor
andreaskienle
left a comment
andreaskienle
left a comment
There was a problem hiding this comment.
Good catch! Thanks for taking care of it 👍🏻 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sometimes the bff proxy just forwarded the accept-encoding header to the backend which told the backend to encode some responses accordingly. This caused a mix in the output which resulted in an error.
This removed the accept-encoding header from the proxy forwarding to prevent this error.
Special notes for your reviewer:
See also: openmcp-project/ui-backend#16 (backend)