Skip to content

Commit dcc71e3

Browse files
feat: Bugfix/adding click here link to feedback (#174)
1 parent 6cf174f commit dcc71e3

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

public/locales/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,8 @@
104104
"feedbackButton": "Send feedback",
105105
"feedbackButtonInfo": "Give us your feedback",
106106
"feedbackPlaceholder": "Please let us know what you think about our application",
107-
"feedbackNotification": "*Slack notification with your email address will be shared with our Operations Team. If you have a special Feature request in mind, please create here.",
107+
"feedbackNotificationText": "*Slack notification with your email address will be shared with our Operations Team. If you have a special Feature request in mind ",
108+
"feedbackNotificationAction": "click here.",
108109
"feedbackThanks": "Thank you for your feedback!"
109110
},
110111
"CreateProjectDialog": {

src/components/Core/ShellBar.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
FormItem,
88
Icon,
99
Label,
10+
Link,
1011
List,
1112
ListItemStandard,
1213
Popover,
@@ -36,7 +37,6 @@ import { generateInitialsForEmail } from '../Helper/generateInitialsForEmail.ts'
3637
import styles from './ShellBar.module.css';
3738
import { ThemingParameters } from '@ui5/webcomponents-react-base';
3839
import { ShellBarItemClickEventDetail } from '@ui5/webcomponents-fiori/dist/ShellBarItem.js';
39-
import { t } from 'i18next';
4040

4141
type UI5RatingIndicatorElement = HTMLElement & { value: number };
4242

@@ -149,11 +149,7 @@ export function ShellBarComponent() {
149149
}
150150
onProfileClick={onProfileClick}
151151
>
152-
<ShellBarItem
153-
icon="feedback"
154-
text={t('ShellBar.feedbackNotification')}
155-
onClick={onFeedbackClick}
156-
/>
152+
<ShellBarItem icon="feedback" onClick={onFeedbackClick} />
157153
</ShellBar>
158154

159155
<ProfilePopover
@@ -336,7 +332,14 @@ const FeedbackPopover = ({
336332
</FormItem>
337333
<FormItem>
338334
<Label style={{ color: 'gray' }}>
339-
{t('ShellBar.feedbackNotification')}
335+
{t('ShellBar.feedbackNotificationText')}
336+
<Link
337+
href="https://github.com/openmcp-project/ui-frontend/issues/new/choose"
338+
target="_blank"
339+
rel="noreferrer"
340+
>
341+
{t('ShellBar.feedbackNotificationAction')}
342+
</Link>
340343
</Label>
341344
</FormItem>
342345
</FormGroup>

0 commit comments

Comments
 (0)