Skip to content

Commit eb8eb89

Browse files
authored
fix: make either clusterRef of requestRef optional (#17)
1 parent a224993 commit eb8eb89

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

api/clusters/v1alpha1/accessrequest_types.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,15 @@ type AccessRequestSpec struct {
1010
// Exactly one of clusterRef or requestRef must be set.
1111
// This value is immutable.
1212
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="clusterRef is immutable"
13-
ClusterRef NamespacedObjectReference `json:"clusterRef"`
13+
// +optional
14+
ClusterRef *NamespacedObjectReference `json:"clusterRef,omitempty"`
1415

1516
// RequestRef is the reference to the ClusterRequest for whose Cluster access is requested.
1617
// Exactly one of clusterRef or requestRef must be set.
1718
// This value is immutable.
1819
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="requestRef is immutable"
19-
RequestRef NamespacedObjectReference `json:"requestRef"`
20+
// +optional
21+
RequestRef *NamespacedObjectReference `json:"requestRef,omitempty"`
2022

2123
// Permissions are the requested permissions.
2224
Permissions []PermissionsRequest `json:"permissions"`

api/clusters/v1alpha1/zz_generated.deepcopy.go

Lines changed: 10 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/crds/manifests/clusters.openmcp.cloud_accessrequests.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,7 @@ spec:
153153
- message: requestRef is immutable
154154
rule: self == oldSelf
155155
required:
156-
- clusterRef
157156
- permissions
158-
- requestRef
159157
type: object
160158
status:
161159
description: AccessRequestStatus defines the observed state of AccessRequest

0 commit comments

Comments
 (0)