fix: remove broken validation rule (#111)

Author: Diaphteiros

api/common/oidc_types.go

@@ -63,8 +63,8 @@ type RoleBindings struct {
 	RoleRefs []RoleRef `json:"roleRefs"`
 }
 
-// +kubebuilder:validation:XValidation:rule="self.kind == 'Role' && has(self.namespace) && self.namespace != ”", message="namespace must be set if kind is 'Role'"
-// +kubebuilder:validation:XValidation:rule="self.kind == 'ClusterRole' && (!has(self.namespace) || self.namespace == ”)", message="namespace must not be set if kind is 'ClusterRole'"
+// RoleRef defines a reference to a (cluster) role that should be bound to the subjects.
+// TODO: Validate that Namespace is set if Kind is 'Role' and not set if Kind is 'ClusterRole'.
 type RoleRef struct {
 	// Name is the name of the role or cluster role to bind to the subjects.
 	// +kubebuilder:validation:MinLength=1

api/crds/manifests/clusters.openmcp.cloud_accessrequests.yaml

@@ -116,6 +116,8 @@ spec:
                             RoleRefs is a list of (cluster) role references that the subjects should be bound to.
                             Note that existence of the roles is not checked and missing (cluster) roles will result in ineffective (cluster) role bindings.
                           items:
+                            description: RoleRef defines a reference to a (cluster)
+                              role that should be bound to the subjects.
                             properties:
                               kind:
                                 description: |-
@@ -139,13 +141,6 @@ spec:
                             - kind
                             - name
                             type: object
-                            x-kubernetes-validations:
-                            - message: namespace must be set if kind is 'Role'
-                              rule: self.kind == 'Role' && has(self.namespace) &&
-                                self.namespace != ”
-                            - message: namespace must not be set if kind is 'ClusterRole'
-                              rule: self.kind == 'ClusterRole' && (!has(self.namespace)
-                                || self.namespace == ”)
                           type: array
                         subjects:
                           description: |-

api/crds/manifests/core.openmcp.cloud_managedcontrolplanev2s.yaml

@@ -100,6 +100,8 @@ spec:
                                   RoleRefs is a list of (cluster) role references that the subjects should be bound to.
                                   Note that existence of the roles is not checked and missing (cluster) roles will result in ineffective (cluster) role bindings.
                                 items:
+                                  description: RoleRef defines a reference to a (cluster)
+                                    role that should be bound to the subjects.
                                   properties:
                                     kind:
                                       description: |-
@@ -123,14 +125,6 @@ spec:
                                   - kind
                                   - name
                                   type: object
-                                  x-kubernetes-validations:
-                                  - message: namespace must be set if kind is 'Role'
-                                    rule: self.kind == 'Role' && has(self.namespace)
-                                      && self.namespace != ”
-                                  - message: namespace must not be set if kind is
-                                      'ClusterRole'
-                                    rule: self.kind == 'ClusterRole' && (!has(self.namespace)
-                                      || self.namespace == ”)
                                 type: array
                               subjects:
                                 description: |-
@@ -209,6 +203,8 @@ spec:
                             RoleRefs is a list of (cluster) role references that the subjects should be bound to.
                             Note that existence of the roles is not checked and missing (cluster) roles will result in ineffective (cluster) role bindings.
                           items:
+                            description: RoleRef defines a reference to a (cluster)
+                              role that should be bound to the subjects.
                             properties:
                               kind:
                                 description: |-
@@ -232,13 +228,6 @@ spec:
                             - kind
                             - name
                             type: object
-                            x-kubernetes-validations:
-                            - message: namespace must be set if kind is 'Role'
-                              rule: self.kind == 'Role' && has(self.namespace) &&
-                                self.namespace != ”
-                            - message: namespace must not be set if kind is 'ClusterRole'
-                              rule: self.kind == 'ClusterRole' && (!has(self.namespace)
-                                || self.namespace == ”)
                           type: array
                         subjects:
                           description: |-