Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Nov 25, 2025

Backporting JDK-8365065: Cancelled ForkJoinPool tasks no longer throw CancellationException. Fixes the exception propagation and tests. Based on the original bug it is a regression and it last worked in version 17.0.16. Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(Passed) - make test-tier1
(Passed) - make test TEST=test/jdk/java/util/concurrent

Results are attached.

linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8365065 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8365065: cancelled ForkJoinPool tasks no longer throw CancellationException

Issue

  • JDK-8365065: cancelled ForkJoinPool tasks no longer throw CancellationException (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/3.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2025

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 61acdf6512c6ea3123edb9017ef99d851c917b90 8365065: cancelled ForkJoinPool tasks no longer throw CancellationException Nov 25, 2025
@openjdk
Copy link

openjdk bot commented Nov 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Nov 25, 2025
@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 25, 2025
@rm-gh-8 rm-gh-8 marked this pull request as ready for review November 26, 2025 17:04
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Nov 26, 2025

/approval request for backport of JDK-8365065: Cancelled ForkJoinPool tasks no longer throw CancellationException.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 26, 2025
@openjdk
Copy link

openjdk bot commented Nov 26, 2025

@rm-gh-8
8365065: The approval request has been updated successfully.

@mlbridge
Copy link

mlbridge bot commented Nov 26, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant