-
Notifications
You must be signed in to change notification settings - Fork 18
8362573: Incorrect weight of the first ObjectAllocationSample JFR event (regression) #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back vish-chan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8362573 which fixes the incorrect weight reported for the first ObjectAllocationSample JFR event by ensuring that allocations that occurred before the recording start are not counted in the event weight. New test passes with the fix and fails without the fix. Low risk as this is a clean backport. |
|
@vish-chan |
|
Hi @vish-chan |
|
Also, please enable GHA actions. |
Backport of:
Testing
Low risk as this is a clean backport.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/29/head:pull/29$ git checkout pull/29Update a local copy of the PR:
$ git checkout pull/29$ git pull https://git.openjdk.org/jdk25u-dev.git pull/29/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29View PR using the GUI difftool:
$ git pr show -t 29Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/29.diff
Using Webrev
Link to Webrev Comment