Skip to content

Conversation

@vish-chan
Copy link
Contributor

@vish-chan vish-chan commented Nov 28, 2025

Backport of:

  • 8362573: Incorrect weight of the first ObjectAllocationSample JFR event (regression)
  • Fixes the incorrect weight reported for the first ObjectAllocationSample JFR event by ensuring that allocations that occurred before the recording start are not counted in the event weight.

Testing

  • New test passes with the fix and fails without the fix.

Low risk as this is a clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8362573 needs maintainer approval

Issue

  • JDK-8362573: Incorrect weight of the first ObjectAllocationSample JFR event (regression) (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/29/head:pull/29
$ git checkout pull/29

Update a local copy of the PR:
$ git checkout pull/29
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/29/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29

View PR using the GUI difftool:
$ git pr show -t 29

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/29.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2025

👋 Welcome back vish-chan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b19e872192106f47c5d9b425230cc2bfe3e4786c 8362573: Incorrect weight of the first ObjectAllocationSample JFR event (regression) Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

⚠️ @vish-chan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2025
@vish-chan
Copy link
Contributor Author

/approval request for backport of JDK-8362573 which fixes the incorrect weight reported for the first ObjectAllocationSample JFR event by ensuring that allocations that occurred before the recording start are not counted in the event weight. New test passes with the fix and fails without the fix. Low risk as this is a clean backport.

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@vish-chan
8362573: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 28, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2025

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Nov 28, 2025

Hi @vish-chan
The risk is not determined by the fact that a change is clean. Please have a second look at your risk assesment.
The risk assesment should take into account whether an application that updates the JVM will see any effect.
For example, if you change the default GC and this is backported clean, you will have a huge effect on applications although it is clean.

@GoeLin
Copy link
Member

GoeLin commented Nov 28, 2025

Also, please enable GHA actions.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants