Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Sep 19, 2025

Hi all,

This pull request contains a backport of commit 762423d6 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 7 May 2025 and was reviewed by Alexander Zuev and Phil Race.

Thanks!


Progress

  • JDK-8355561 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355561: [macos] Build failure with Xcode 16.3 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3974/head:pull/3974
$ git checkout pull/3974

Update a local copy of the PR:
$ git checkout pull/3974
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3974

View PR using the GUI difftool:
$ git pr show -t 3974

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3974.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355561: [macos] Build failure with Xcode 16.3

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 762423d64d10dcdb37800767d2b2f1b7757c804a 8355561: [macos] Build failure with Xcode 16.3 Sep 19, 2025
@openjdk
Copy link

openjdk bot commented Sep 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 19, 2025
@mrserb mrserb marked this pull request as ready for review September 21, 2025 04:20
@openjdk
Copy link

openjdk bot commented Sep 21, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 21, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2025

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Oct 30, 2025

/approval request
Clean backport. Fix for the broken build. The usage of VLA in PLATFORM_API_MacOSX_Ports.cpp
has been replaced with malloc/calloc and free. No new issues were found by the jdk_desktop tests.

@openjdk
Copy link

openjdk bot commented Oct 30, 2025

@mrserb
8355561: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 30, 2025
@shipilev shipilev mentioned this pull request Nov 4, 2025
4 tasks
@shipilev
Copy link
Member

shipilev commented Nov 4, 2025

Need this for #4115 to work, please and thank you :)

@mrserb
Copy link
Member Author

mrserb commented Nov 4, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

Going to push as commit 76a55f2.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 7d6e99c: 8352966: Opensource Several Font related tests - Batch 2
  • 1f34ffc: 8353007: Open some JComboBox bugs 2

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2025
@openjdk openjdk bot closed this Nov 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2025
@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@mrserb Pushed as commit 76a55f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants