Skip to content
This repository was archived by the owner on Feb 5, 2022. It is now read-only.

Commit 19244f1

Browse files
luiskcs89luiskcs89
committed
fix(home): add alt text to images
1 parent 7f0e241 commit 19244f1

File tree

2 files changed

+42
-48
lines changed

2 files changed

+42
-48
lines changed

‎src/components.d.ts‎

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,13 @@ declare global {
3636
}
3737

3838
interface AppCta {
39-
'hideButton': boolean;
40-
'linkUrl': string;
39+
4140
}
4241

4342
interface AppFooter {
4443

4544
}
4645

47-
interface AppHeroHome {
48-
'textNoWrap': boolean;
49-
}
50-
5146
interface AppImg {
5247
'alt': string;
5348
'fit': boolean;
@@ -190,14 +185,6 @@ declare global {
190185
};
191186

192187

193-
interface HTMLAppHeroHomeElement extends StencilComponents.AppHeroHome, HTMLStencilElement {}
194-
195-
var HTMLAppHeroHomeElement: {
196-
prototype: HTMLAppHeroHomeElement;
197-
new (): HTMLAppHeroHomeElement;
198-
};
199-
200-
201188
interface HTMLAppImgElement extends StencilComponents.AppImg, HTMLStencilElement {}
202189

203190
var HTMLAppImgElement: {
@@ -380,7 +367,6 @@ declare global {
380367
'app-carousel-indicators': JSXElements.AppCarouselIndicatorsAttributes;
381368
'app-cta': JSXElements.AppCtaAttributes;
382369
'app-footer': JSXElements.AppFooterAttributes;
383-
'app-hero-home': JSXElements.AppHeroHomeAttributes;
384370
'app-img': JSXElements.AppImgAttributes;
385371
'app-input': JSXElements.AppInputAttributes;
386372
'app-members': JSXElements.AppMembersAttributes;
@@ -413,18 +399,13 @@ declare global {
413399
}
414400

415401
export interface AppCtaAttributes extends HTMLAttributes {
416-
'hideButton'?: boolean;
417-
'linkUrl'?: string;
402+
418403
}
419404

420405
export interface AppFooterAttributes extends HTMLAttributes {
421406

422407
}
423408

424-
export interface AppHeroHomeAttributes extends HTMLAttributes {
425-
'textNoWrap'?: boolean;
426-
}
427-
428409
export interface AppImgAttributes extends HTMLAttributes {
429410
'alt'?: string;
430411
'fit'?: boolean;
@@ -550,7 +531,6 @@ declare global {
550531
'app-carousel-indicators': HTMLAppCarouselIndicatorsElement
551532
'app-cta': HTMLAppCtaElement
552533
'app-footer': HTMLAppFooterElement
553-
'app-hero-home': HTMLAppHeroHomeElement
554534
'app-img': HTMLAppImgElement
555535
'app-input': HTMLAppInputElement
556536
'app-members': HTMLAppMembersElement
@@ -579,7 +559,6 @@ declare global {
579559
'app-carousel-indicators': HTMLAppCarouselIndicatorsElement;
580560
'app-cta': HTMLAppCtaElement;
581561
'app-footer': HTMLAppFooterElement;
582-
'app-hero-home': HTMLAppHeroHomeElement;
583562
'app-img': HTMLAppImgElement;
584563
'app-input': HTMLAppInputElement;
585564
'app-members': HTMLAppMembersElement;

‎src/pages/app-home/app-home.tsx‎

Lines changed: 40 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export class AppHome {
2121

2222
private sticky;
2323

24-
2524
componentDidLoad() {
2625
// isServer is false when running in the browser
2726
// and true when being prerendered
@@ -136,6 +135,7 @@ export class AppHome {
136135
<object
137136
data="/assets/svg/home-graphic-header.svg"
138137
class="svg-header-desktop"
138+
aria-label="header"
139139
/>
140140
</header>
141141

@@ -158,6 +158,7 @@ export class AppHome {
158158
<img
159159
class="carousel-image-h"
160160
src="/assets/svg/home-graphic-process-discovery.svg"
161+
alt="discovery"
161162
/>
162163
</div>
163164
<div class="col-lg-6 col-md-6 col-sm-12 carousel-panel align-self-center">
@@ -182,6 +183,7 @@ export class AppHome {
182183
<img
183184
class="carousel-image-h"
184185
src="/assets/svg/home-graphic-process-design.svg"
186+
alt="design"
185187
/>
186188
</div>
187189
<div class="col-lg-6 col-md-6 col-sm-12 carousel-panel align-self-center">
@@ -206,6 +208,7 @@ export class AppHome {
206208
<img
207209
class="carousel-image"
208210
src="/assets/svg/home-graphic-process-development.svg"
211+
alt="development"
209212
/>
210213
</div>
211214
<div class="col-lg-6 col-md-6 col-sm-12 carousel-panel align-self-center">
@@ -230,12 +233,13 @@ export class AppHome {
230233
<img
231234
class="carousel-image"
232235
src="/assets/svg/home-graphic-process-deployment.svg"
236+
alt="deployment"
233237
/>
234238
</div>
235239
<div class="col-lg-6 col-md-6 col-sm-12 carousel-panel align-self-center">
236240
<div class="carousel-text">
237241
<h2>
238-
< app-translate key="home.process.deployment.title" />
242+
<app-translate key="home.process.deployment.title" />
239243
</h2>
240244
<app-carousel-indicators
241245
class="carousel-mobile-indicators"
@@ -254,6 +258,7 @@ export class AppHome {
254258
<img
255259
class="carousel-image-userfeedback"
256260
src="/assets/svg/home-graphic-process-userfeedback.svg"
261+
alt="user feedback"
257262
/>
258263
</div>
259264
<div class="col-lg-6 col-md-6 col-sm-12 carousel-panel align-self-center">
@@ -306,12 +311,8 @@ export class AppHome {
306311
<div class="content-panel loudcloud">
307312
<div class="content-panel-inner description">
308313
<div class="panel-inner-text">
309-
<h2>
310-
{translate('home.services.mobileTechnology.title')}
311-
</h2>
312-
<p>
313-
{translate('home.services.mobileTechnology.text')}
314-
</p>
314+
<h2>{translate('home.services.mobileTechnology.title')}</h2>
315+
<p>{translate('home.services.mobileTechnology.text')}</p>
315316
</div>
316317
</div>
317318
<div class="content-panel-image">
@@ -324,21 +325,28 @@ export class AppHome {
324325
href="https://itunes.apple.com/us/app/loudcloud-disposable-numbers/id723331666?mt=8"
325326
target="_blank"
326327
>
327-
<img src="/assets/graphic-apple-appstore.png" />
328+
<img
329+
src="/assets/graphic-apple-appstore.png"
330+
alt="download on app store"
331+
/>
328332
</a>
329333
</div>
330334
<div class="col-6 text-left">
331335
<a
332336
href="https://play.google.com/store/apps/details?id=com.ignitras.loudcloud&hl=en"
333337
target="_blank"
334338
>
335-
<img src="/assets/graphic-google-googleplaystore.png" />
339+
<img
340+
src="/assets/graphic-google-googleplaystore.png"
341+
alt="download on play store"
342+
/>
336343
</a>
337344
</div>
338345
</div>
339346
<img
340347
src="/assets/shared-graphic-loudcloud.png"
341348
class="phone-image"
349+
alt="loudcloud"
342350
/>
343351
</div>
344352
</div>
@@ -348,9 +356,7 @@ export class AppHome {
348356
<h2>
349357
{translate('home.services.digitalExperience.title')}
350358
</h2>
351-
<p>
352-
{translate('home.services.digitalExperience.text')}
353-
</p>
359+
<p>{translate('home.services.digitalExperience.text')}</p>
354360
</div>
355361
</div>
356362
<div class="content-panel-image">
@@ -363,33 +369,36 @@ export class AppHome {
363369
href="https://itunes.apple.com/us/app/the-voyage-by-new-ocean-health/id779637437?mt=8"
364370
target="_blank"
365371
>
366-
<img src="/assets/graphic-apple-appstore.png" />
372+
<img
373+
src="/assets/graphic-apple-appstore.png"
374+
alt="download on app store"
375+
/>
367376
</a>
368377
</div>
369378
<div class="col-6 text-left">
370379
<a
371380
href="https://play.google.com/store/apps/details?id=com.carecaminnovations.mobile"
372381
target="_blank"
373382
>
374-
<img src="/assets/graphic-google-googleplaystore.png" />
383+
<img
384+
src="/assets/graphic-google-googleplaystore.png"
385+
alt="download on play store"
386+
/>
375387
</a>
376388
</div>
377389
</div>
378390
<img
379391
src="/assets/shared-graphic-voyage.png"
380392
class="phone-image"
393+
alt="voyage"
381394
/>
382395
</div>
383396
</div>
384397
<div class="content-panel juntoscope">
385398
<div class="content-panel-inner description">
386399
<div class="panel-inner-text">
387-
<h2>
388-
{translate('home.services.brandingDesign.title')}
389-
</h2>
390-
<p>
391-
{translate('home.services.brandingDesign.text')}
392-
</p>
400+
<h2>{translate('home.services.brandingDesign.title')}</h2>
401+
<p>{translate('home.services.brandingDesign.text')}</p>
393402
</div>
394403
</div>
395404
<div class="content-panel-image">
@@ -402,21 +411,28 @@ export class AppHome {
402411
href="https://itunes.apple.com/us/app/digi-thermo/id1307130445?mt=8"
403412
target="_blank"
404413
>
405-
<img src="/assets/graphic-apple-appstore.png" />
414+
<img
415+
src="/assets/graphic-apple-appstore.png"
416+
alt="download on app store"
417+
/>
406418
</a>
407419
</div>
408420
<div class="col-6 text-left">
409421
<a
410422
href="https://play.google.com/store/apps/details?id=com.webjuntollc.digithermoapp"
411423
target="_blank"
412424
>
413-
<img src="/assets/graphic-google-googleplaystore.png" />
425+
<img
426+
src="/assets/graphic-google-googleplaystore.png"
427+
alt="download on play store"
428+
/>
414429
</a>
415430
</div>
416431
</div>
417432
<img
418433
src="/assets/shared-graphic-juntoscope.png"
419434
class="phone-image"
435+
alt="juntoscope"
420436
/>
421437
</div>
422438
</div>
@@ -427,9 +443,8 @@ export class AppHome {
427443

428444
{/* aside - cta */}
429445
<app-cta />
430-
431-
<app-footer />
432446

447+
<app-footer />
433448
</div>
434449
);
435450
}

0 commit comments

Comments
 (0)