Skip to content
This repository was archived by the owner on Mar 21, 2025. It is now read-only.

Commit 5adbfa0

Browse files
author
Michael Sauter
committed
Change KinD registry port to 5001
Closes #390.
1 parent 1c79cf6 commit 5adbfa0

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

deploy/ods-pipeline/values.kind.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ setup:
2020
storageSize: '2Gi'
2121
replicaCount: 1
2222
image:
23-
registry: localhost:5000
23+
registry: localhost:5001
2424
namespace: ods
2525
repository: ods-pipeline-manager
2626
pullPolicy: Always
@@ -65,9 +65,9 @@ tasks:
6565
# registry: ghcr.io
6666
# namespace: opendevstack/ods-pipeline
6767

68-
registry: localhost:5000
68+
registry: localhost:5001
6969
namespace: ods
70-
pushRegistry: kind-registry.kind:5000
70+
pushRegistry: kind-registry.kind:5001
7171

7272
##
7373
# images chart

docs/adr/20210517-testing-tekton-tasks.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Run a task that prints a hello world message and define a test in Go using Use [
3232
As part of the preconditions to run the tests, we shall:
3333

3434
- Create a KinD cluster with a registry. (needed to push images for buildah)
35-
- Pull the images from DockerHub into the KinD registry (Tasks by default will use localhost:5000, make it easy later to override).
35+
- Pull the images from DockerHub into the KinD registry (Tasks by default will use localhost:5001, make it easy later to override).
3636
- Install Tekton Core components
3737
- Apply the custom Tekton tasks under /deploy.
3838
- Verify we can run Tekton tests.

scripts/build-and-push-images.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set -eu
33

44
# To carry out normal operations like running ODS Tekton Tasks,
55
# we need the ODS tasks images available in the KinD cluster.
6-
REGISTRY="localhost:5000"
6+
REGISTRY="localhost:5001"
77
NAMESPACE="ods"
88

99
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"

scripts/kind-with-registry.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ ODS_PIPELINE_DIR=${SCRIPT_DIR%/*}
2525
# desired cluster name; default is "kind"
2626
KIND_CLUSTER_NAME="kind"
2727
RECREATE_KIND_CLUSTER="false"
28-
REGISTRY_PORT="5000"
28+
REGISTRY_PORT="5001"
2929

3030
# K8S version is aligned with OpenShift GA 4.8.
3131
# See https://docs.openshift.com/container-platform/4.8/release_notes/ocp-4-8-release-notes.html

test/tasks/ods-deploy-helm_external_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,11 +100,11 @@ func TestTaskODSDeployHelmExternal(t *testing.T) {
100100

101101
imageStream = random.PseudoString()
102102
tag := "latest"
103-
fullTag := fmt.Sprintf("localhost:5000/%s/%s:%s", ctxt.Namespace, imageStream, tag)
103+
fullTag := fmt.Sprintf("localhost:5001/%s/%s:%s", ctxt.Namespace, imageStream, tag)
104104
buildAndPushImageWithLabel(t, ctxt, fullTag, wsDir)
105105
ia := artifact.Image{
106-
Image: fmt.Sprintf("kind-registry.kind:5000/%s/%s:%s", ctxt.Namespace, imageStream, tag),
107-
Registry: "kind-registry.kind:5000",
106+
Image: fmt.Sprintf("kind-registry.kind:5001/%s/%s:%s", ctxt.Namespace, imageStream, tag),
107+
Registry: "kind-registry.kind:5001",
108108
Repository: ctxt.Namespace,
109109
Name: imageStream,
110110
Tag: tag,

test/tasks/ods-package-image_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,5 +207,5 @@ func getDockerImageTag(t *testing.T, ctxt *tasktesting.TaskRunContext, wsDir str
207207
if err != nil {
208208
t.Fatalf("could not read git-commit-sha: %s", err)
209209
}
210-
return fmt.Sprintf("localhost:5000/%s/%s:%s", ctxt.Namespace, ctxt.ODS.Component, sha)
210+
return fmt.Sprintf("localhost:5001/%s/%s:%s", ctxt.Namespace, ctxt.ODS.Component, sha)
211211
}

0 commit comments

Comments
 (0)