-
Notifications
You must be signed in to change notification settings - Fork 124
RHAIENG-948: fix(jupyter datascience on IBM/Power): build failure due to AIPCC base (missing curl and openssl -devel packages) and AIPCC wheels (some prereqs are missing) #2678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
28f0ae1
RHAIENG-948: fix(ppc): build failure due to missing curl
jiridanek ef8a1c0
RHAIENG-948: fix(ppc): build failure due to missing openssl
jiridanek 65c8df9
RHAIENG-948: fix(ppc): build failure due to missing cython in aipcc w…
jiridanek a7c3f57
RHAIENG-948: fix(ppc): build failure due to missing numpy in aipcc wh…
jiridanek b44381a
RHAIENG-948: fix(ppc): build failure due to missing protobuf>=4.25.1 …
jiridanek d91601e
RHAIENG-948: fix(ppc): build failure due to missing numpy>=1.16.6 in …
jiridanek a8883c3
RHOAIENG-32541: chore(jupyter/datascience): add `subscription-manager…
jiridanek e43a44e
RHAIENG-948: fix(ppc): build failure due to missing cryptography buil…
jiridanek 4bec539
RHAIENG-948: fix(ppc): build failure due to missing zlib-devel to bui…
jiridanek 4183ea4
RHAIENG-948: fix(ppc): build failure due to missing libjpeg-turbo-dev…
jiridanek 3594426
RHAIENG-948: fix(ppc): build failure due to missing openssl-devel to …
jiridanek 75199d2
RHAIENG-948: fix(ppc): build failure due to missing fortran to build …
jiridanek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai create github issue to capture
jupyter/datascience/ubi9-python-3.12/Dockerfile.cpu (1)
189-190: Consistent use of extra PyPI index is pragmatic but warrants a comment on sustainability.
The --extra-index-url https://pypi.org/simple pattern appears consistently across Power-specific builds to compensate for gaps in the AIPCC index (missing cython, numpy, protobuf, etc.). While this is an appropriate workaround, consider adding a top-level comment in the file (near the first occurrence or in the file header) documenting that this is a temporary mitigation for AIPCC index limitations and should be revisited if/when the AIPCC index coverage improves.
Also applies to: 241-246, 347-348, 361-363, 428-428
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 55
@jiridanek I've created GitHub issue #2679 to capture this documentation improvement: #2679
The issue documents the need to add a top-level comment in the Dockerfile explaining that the
--extra-index-url https://pypi.org/simplepattern is a temporary workaround for AIPCC index limitations, along with references to the affected lines and known missing packages (cython, numpy>=1.22, protobuf>=4.25.1, cryptography dependencies).