From 33805b8f427964272f4b05881ff393c7a143f9e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jiri=20Dan=C4=9Bk?= Date: Fri, 24 Oct 2025 16:13:17 +0200 Subject: [PATCH] RHAIENG-287: fix(kustomization.yaml): abbreviate namePrefix to resolve Kubernetes label character limit issue ``` kubernetes namespace events [INFO] Running command (('kubectl get events',), {'shell': True}) LAST SEEN TYPE REASON OBJECT MESSAGE 71s Warning FailedCreate statefulset/jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook create Pod jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-0 in StatefulSet jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook failed error: Pod "jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-0" is invalid: metadata.labels: Invalid value: "jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-7d69c59fc6": must be no more than 63 characters ``` ``` + notebook_workload_name=jupyter-pt-llmcompress-ubi9-python-3-12-notebook-0 + _handle_test + local notebook_id= ++ _get_notebook_id ++ local notebook_id= ++ local accelerator=cuda ++ accelerator= ++ case "${notebook_workload_name}" in ++ printf '%s\n' 'No matching condition found for jupyter-pt-llmcompress-ubi9-python-3-12-notebook-0.' ++ exit 1 ``` --- .../ubi9-python-3.12/kustomize/base/kustomization.yaml | 4 +++- scripts/test_jupyter_with_papermill.sh | 5 +++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/jupyter/pytorch+llmcompressor/ubi9-python-3.12/kustomize/base/kustomization.yaml b/jupyter/pytorch+llmcompressor/ubi9-python-3.12/kustomize/base/kustomization.yaml index 8c7428520d..18ca810f0c 100644 --- a/jupyter/pytorch+llmcompressor/ubi9-python-3.12/kustomize/base/kustomization.yaml +++ b/jupyter/pytorch+llmcompressor/ubi9-python-3.12/kustomize/base/kustomization.yaml @@ -1,7 +1,9 @@ --- apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization -namePrefix: jupyter-pytorch-llmcompressor-ubi9-python-3-12- +# have to abbreviate the prefix, otherwise we'd go over the 63 character limit +# > Pod "jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-0" is invalid: metadata.labels: Invalid value: "jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-7d69c59fc6": must be no more than 63 characters +namePrefix: jupyter-pt-llmcompress-ubi9-python-3-12- labels: - includeSelectors: true pairs: diff --git a/scripts/test_jupyter_with_papermill.sh b/scripts/test_jupyter_with_papermill.sh index 9cea3a5736..4b09a9659d 100755 --- a/scripts/test_jupyter_with_papermill.sh +++ b/scripts/test_jupyter_with_papermill.sh @@ -346,6 +346,9 @@ function _get_notebook_id() { *${jupyter_pytorch_notebook_id}-*) notebook_id="${accelerator:+$accelerator/}${jupyter_pytorch_notebook_id}" ;; + *${jupyter_pytorch_llmcompressor_notebook_shortened_id}-*) + notebook_id="${accelerator:+$accelerator/}${jupyter_pytorch_llmcompressor_notebook_full_id}" + ;; *) printf '%s\n' "No matching condition found for ${notebook_workload_name}." exit 1 @@ -387,6 +390,8 @@ jupyter_datascience_notebook_id='datascience' jupyter_trustyai_notebook_id='trustyai' jupyter_pytorch_notebook_id='pytorch' jupyter_tensorflow_notebook_id='tensorflow' +jupyter_pytorch_llmcompressor_notebook_shortened_id='pt-llmcompress' +jupyter_pytorch_llmcompressor_notebook_full_id="pytorch-llmcompressor" notebook_name=$( _get_notebook_name "${test_target}" ) python_flavor="python-${test_target//*-python-/}" # <-- python-3.11