Skip to content

Commit b86bd10

Browse files
committed
[v1.0.1] Corrected plugin interface
1 parent 587843f commit b86bd10

File tree

4 files changed

+10
-25
lines changed

4 files changed

+10
-25
lines changed

README.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,6 @@ registry.register(
3737
}
3838
}
3939
}
40-
},
41-
err => {
42-
if (err) {
43-
console.log('plugin initialisation failed:', err);
44-
} else {
45-
console.log('jwt verify now available');
46-
}
4740
}
4841
);
4942

@@ -66,13 +59,6 @@ registry.register(
6659
}
6760
}
6861
}
69-
},
70-
err => {
71-
if (err) {
72-
console.log('plugin initialisation failed:', err);
73-
} else {
74-
console.log('jwt verify now available');
75-
}
7662
}
7763
);
7864

lib/verify.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ const defaultKeyStore = require('./defaultKeyStore');
55
let keyStore;
66

77
module.exports = {
8-
register(options, callback) {
8+
register(options, dependencies, next) {
99
if (options && options.keyStore) {
1010
keyStore = options.keyStore;
1111
} else {
1212
keyStore = defaultKeyStore(options);
1313
}
14-
return callback();
14+
next();
1515
},
1616
execute(token, callback) {
1717
try {

lib/verify.test.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,14 @@ const dataToTokenzie = {
55
name: 'John Doe',
66
sub: '1234567890'
77
};
8-
const emptyCallback = () => {};
98

109
describe('verify', () => {
1110
describe('when given a valid public key signed token', () => {
1211
const token = utils.getTokenSignedWithPrivateKey(dataToTokenzie);
1312

1413
it('returns the verified token with no errors', () => {
1514
const verify = require('./verify');
16-
verify.register({ keys }, emptyCallback);
15+
verify.register({ keys }, {}, () => {});
1716
verify.execute(token, (error, verifiedToken) => {
1817
expect(error).toBe(null);
1918
expect(verifiedToken).toMatchSnapshot();
@@ -26,7 +25,7 @@ describe('verify', () => {
2625

2726
it('returns the verified token with no errors', () => {
2827
const verify = require('./verify');
29-
verify.register({ keys }, emptyCallback);
28+
verify.register({ keys }, {}, () => {});
3029
verify.execute(token, (error, verifiedToken) => {
3130
expect(error).toBe(null);
3231
expect(verifiedToken).toMatchSnapshot();
@@ -39,7 +38,7 @@ describe('verify', () => {
3938

4039
it('it returns an error with no token', () => {
4140
const verify = require('./verify');
42-
verify.register({ keys }, emptyCallback);
41+
verify.register({ keys }, {}, () => {});
4342
verify.execute(token, (error, verifiedToken) => {
4443
expect(error).toMatchSnapshot();
4544
expect(verifiedToken).toBe(undefined);
@@ -59,7 +58,7 @@ describe('verify', () => {
5958
}
6059
}
6160
};
62-
verify.register(options, emptyCallback);
61+
verify.register(options, {}, () => {});
6362
verify.execute(token, (error, verifiedToken) => {
6463
expect(error).toBe(null);
6564
expect(verifiedToken).toMatchSnapshot();
@@ -72,7 +71,7 @@ describe('verify', () => {
7271

7372
it('it returns an error with no token', () => {
7473
const verify = require('./verify');
75-
verify.register({ keys }, emptyCallback);
74+
verify.register({ keys }, {}, () => {});
7675
verify.execute(token, (error, verifiedToken) => {
7776
expect(error).toMatchSnapshot();
7877
expect(verifiedToken).toBe(undefined);
@@ -85,7 +84,7 @@ describe('verify', () => {
8584

8685
it('it returns an error with no token', () => {
8786
const verify = require('./verify');
88-
verify.register({ keys }, emptyCallback);
87+
verify.register({ keys }, {}, () => {});
8988
verify.execute(token, (error, verifiedToken) => {
9089
expect(error).toMatchSnapshot();
9190
expect(verifiedToken).toBe(undefined);
@@ -98,7 +97,7 @@ describe('verify', () => {
9897

9998
it('it returns an error with no token', () => {
10099
const verify = require('./verify');
101-
verify.register({ keys }, emptyCallback);
100+
verify.register({ keys }, {}, () => {});
102101
verify.execute(token, (error, verifiedToken) => {
103102
expect(error).toMatchSnapshot();
104103
expect(verifiedToken).toBe(undefined);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "oc-plugin-jwt",
3-
"version": "1.0.0",
3+
"version": "1.0.1",
44
"description": "OpenComponents Plugin for Verifying & Decoding JSON Web Tokens (JWT)",
55
"main": "index.js",
66
"scripts": {

0 commit comments

Comments
 (0)