Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Commit 0173515

Browse files
spacetherspacether
committed
Removes cases that lacked success response code, stops adding type hint for generic ApiResponse
1 parent 7ebac48 commit 0173515

File tree

11 files changed

+72
-36
lines changed

11 files changed

+72
-36
lines changed

‎modules/openapi-json-schema-generator/src/test/resources/3_0/python/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -651,8 +651,8 @@ paths:
651651
- 1.1
652652
- -1.2
653653
responses:
654-
'400':
655-
description: Invalid request
654+
'200':
655+
description: Success
656656
'404':
657657
description: Not found
658658
requestBody:
@@ -693,8 +693,8 @@ paths:
693693
가짜 엔드 포인트
694694
operationId: EndpointParameters
695695
responses:
696-
'400':
697-
description: Invalid username supplied
696+
'200':
697+
description: Success
698698
'404':
699699
description: User not found
700700
security:
@@ -822,8 +822,8 @@ paths:
822822
type: integer
823823
format: int64
824824
responses:
825-
'400':
826-
description: Someting wrong
825+
'200':
826+
description: succeeded
827827
/fake/refs/number:
828828
post:
829829
tags:

‎samples/openapi3/client/petstore/python/docs/apis/tags/FakeApi.md‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,10 +1009,10 @@ Key | Input Type | Accessed Type | Description | Notes
10091009
Code | Class | Description
10101010
------------- | ------------- | -------------
10111011
n/a | api_client.ApiResponseWithoutDeserialization | When skip_deserialization is True this response is returned
1012-
400 | [ApiResponseFor400](#endpoint_parameters.ApiResponseFor400) | Invalid username supplied
1012+
200 | [ApiResponseFor200](#endpoint_parameters.ApiResponseFor200) | Success
10131013
404 | [ApiResponseFor404](#endpoint_parameters.ApiResponseFor404) | User not found
10141014

1015-
#### endpoint_parameters.ApiResponseFor400
1015+
#### endpoint_parameters.ApiResponseFor200
10161016
Name | Type | Description | Notes
10171017
------------- | ------------- | ------------- | -------------
10181018
response | urllib3.HTTPResponse | Raw response |
@@ -1206,10 +1206,10 @@ str, | str, | | must be one of ["_abc", "-efg", "(xyz)", ] if omitted the ser
12061206
Code | Class | Description
12071207
------------- | ------------- | -------------
12081208
n/a | api_client.ApiResponseWithoutDeserialization | When skip_deserialization is True this response is returned
1209-
400 | [ApiResponseFor400](#enum_parameters.ApiResponseFor400) | Invalid request
1209+
200 | [ApiResponseFor200](#enum_parameters.ApiResponseFor200) | Success
12101210
404 | [ApiResponseFor404](#enum_parameters.ApiResponseFor404) | Not found
12111211

1212-
#### enum_parameters.ApiResponseFor400
1212+
#### enum_parameters.ApiResponseFor200
12131213
Name | Type | Description | Notes
12141214
------------- | ------------- | ------------- | -------------
12151215
response | urllib3.HTTPResponse | Raw response |
@@ -1438,9 +1438,9 @@ bool, | BoolClass, | |
14381438
Code | Class | Description
14391439
------------- | ------------- | -------------
14401440
n/a | api_client.ApiResponseWithoutDeserialization | When skip_deserialization is True this response is returned
1441-
400 | [ApiResponseFor400](#group_parameters.ApiResponseFor400) | Someting wrong
1441+
200 | [ApiResponseFor200](#group_parameters.ApiResponseFor200) | succeeded
14421442

1443-
#### group_parameters.ApiResponseFor400
1443+
#### group_parameters.ApiResponseFor200
14441444
Name | Type | Description | Notes
14451445
------------- | ------------- | ------------- | -------------
14461446
response | urllib3.HTTPResponse | Raw response |

‎samples/openapi3/client/petstore/python/petstore_api/paths/fake/delete.py‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,17 +118,17 @@ class RequestHeaderParams(RequestRequiredHeaderParams, RequestOptionalHeaderPara
118118

119119

120120
@dataclass
121-
class ApiResponseFor400(api_client.ApiResponse):
121+
class ApiResponseFor200(api_client.ApiResponse):
122122
response: urllib3.HTTPResponse
123123
body: schemas.Unset = schemas.unset
124124
headers: schemas.Unset = schemas.unset
125125

126126

127-
_response_for_400 = api_client.OpenApiResponse(
128-
response_cls=ApiResponseFor400,
127+
_response_for_200 = api_client.OpenApiResponse(
128+
response_cls=ApiResponseFor200,
129129
)
130130
_status_code_to_response = {
131-
'400': _response_for_400,
131+
'200': _response_for_200,
132132
}
133133

134134

@@ -143,6 +143,7 @@ def _group_parameters_oapg(
143143
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
144144
skip_deserialization: typing_extensions.Literal[False] = False,
145145
) -> typing.Union[
146+
ApiResponseFor200,
146147
]: ...
147148

148149
@typing.overload
@@ -164,6 +165,7 @@ def _group_parameters_oapg(
164165
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
165166
skip_deserialization: bool = False,
166167
) -> typing.Union[
168+
ApiResponseFor200,
167169
api_client.ApiResponseWithoutDeserialization,
168170
]: ...
169171

@@ -249,6 +251,7 @@ def group_parameters(
249251
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
250252
skip_deserialization: typing_extensions.Literal[False] = False,
251253
) -> typing.Union[
254+
ApiResponseFor200,
252255
]: ...
253256

254257
@typing.overload
@@ -270,6 +273,7 @@ def group_parameters(
270273
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
271274
skip_deserialization: bool = False,
272275
) -> typing.Union[
276+
ApiResponseFor200,
273277
api_client.ApiResponseWithoutDeserialization,
274278
]: ...
275279

@@ -302,6 +306,7 @@ def delete(
302306
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
303307
skip_deserialization: typing_extensions.Literal[False] = False,
304308
) -> typing.Union[
309+
ApiResponseFor200,
305310
]: ...
306311

307312
@typing.overload
@@ -323,6 +328,7 @@ def delete(
323328
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
324329
skip_deserialization: bool = False,
325330
) -> typing.Union[
331+
ApiResponseFor200,
326332
api_client.ApiResponseWithoutDeserialization,
327333
]: ...
328334

‎samples/openapi3/client/petstore/python/petstore_api/paths/fake/delete.pyi‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,14 +113,14 @@ request_header_boolean_group = api_client.HeaderParameter(
113113

114114

115115
@dataclass
116-
class ApiResponseFor400(api_client.ApiResponse):
116+
class ApiResponseFor200(api_client.ApiResponse):
117117
response: urllib3.HTTPResponse
118118
body: schemas.Unset = schemas.unset
119119
headers: schemas.Unset = schemas.unset
120120

121121

122-
_response_for_400 = api_client.OpenApiResponse(
123-
response_cls=ApiResponseFor400,
122+
_response_for_200 = api_client.OpenApiResponse(
123+
response_cls=ApiResponseFor200,
124124
)
125125

126126

@@ -135,6 +135,7 @@ class BaseApi(api_client.Api):
135135
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
136136
skip_deserialization: typing_extensions.Literal[False] = False,
137137
) -> typing.Union[
138+
ApiResponseFor200,
138139
]: ...
139140

140141
@typing.overload
@@ -156,6 +157,7 @@ class BaseApi(api_client.Api):
156157
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
157158
skip_deserialization: bool = False,
158159
) -> typing.Union[
160+
ApiResponseFor200,
159161
api_client.ApiResponseWithoutDeserialization,
160162
]: ...
161163

@@ -241,6 +243,7 @@ class GroupParameters(BaseApi):
241243
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
242244
skip_deserialization: typing_extensions.Literal[False] = False,
243245
) -> typing.Union[
246+
ApiResponseFor200,
244247
]: ...
245248

246249
@typing.overload
@@ -262,6 +265,7 @@ class GroupParameters(BaseApi):
262265
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
263266
skip_deserialization: bool = False,
264267
) -> typing.Union[
268+
ApiResponseFor200,
265269
api_client.ApiResponseWithoutDeserialization,
266270
]: ...
267271

@@ -294,6 +298,7 @@ class ApiFordelete(BaseApi):
294298
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
295299
skip_deserialization: typing_extensions.Literal[False] = False,
296300
) -> typing.Union[
301+
ApiResponseFor200,
297302
]: ...
298303

299304
@typing.overload
@@ -315,6 +320,7 @@ class ApiFordelete(BaseApi):
315320
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
316321
skip_deserialization: bool = False,
317322
) -> typing.Union[
323+
ApiResponseFor200,
318324
api_client.ApiResponseWithoutDeserialization,
319325
]: ...
320326

‎samples/openapi3/client/petstore/python/petstore_api/paths/fake/get.py‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -424,14 +424,14 @@ def __new__(
424424

425425

426426
@dataclass
427-
class ApiResponseFor400(api_client.ApiResponse):
427+
class ApiResponseFor200(api_client.ApiResponse):
428428
response: urllib3.HTTPResponse
429429
body: schemas.Unset = schemas.unset
430430
headers: schemas.Unset = schemas.unset
431431

432432

433-
_response_for_400 = api_client.OpenApiResponse(
434-
response_cls=ApiResponseFor400,
433+
_response_for_200 = api_client.OpenApiResponse(
434+
response_cls=ApiResponseFor200,
435435
)
436436

437437

@@ -446,7 +446,7 @@ class ApiResponseFor404(api_client.ApiResponse):
446446
response_cls=ApiResponseFor404,
447447
)
448448
_status_code_to_response = {
449-
'400': _response_for_400,
449+
'200': _response_for_200,
450450
'404': _response_for_404,
451451
}
452452

@@ -464,6 +464,7 @@ def _enum_parameters_oapg(
464464
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
465465
skip_deserialization: typing_extensions.Literal[False] = False,
466466
) -> typing.Union[
467+
ApiResponseFor200,
467468
]: ...
468469

469470
@typing.overload
@@ -489,6 +490,7 @@ def _enum_parameters_oapg(
489490
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
490491
skip_deserialization: bool = False,
491492
) -> typing.Union[
493+
ApiResponseFor200,
492494
api_client.ApiResponseWithoutDeserialization,
493495
]: ...
494496

@@ -588,6 +590,7 @@ def enum_parameters(
588590
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
589591
skip_deserialization: typing_extensions.Literal[False] = False,
590592
) -> typing.Union[
593+
ApiResponseFor200,
591594
]: ...
592595

593596
@typing.overload
@@ -613,6 +616,7 @@ def enum_parameters(
613616
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
614617
skip_deserialization: bool = False,
615618
) -> typing.Union[
619+
ApiResponseFor200,
616620
api_client.ApiResponseWithoutDeserialization,
617621
]: ...
618622

@@ -651,6 +655,7 @@ def get(
651655
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
652656
skip_deserialization: typing_extensions.Literal[False] = False,
653657
) -> typing.Union[
658+
ApiResponseFor200,
654659
]: ...
655660

656661
@typing.overload
@@ -676,6 +681,7 @@ def get(
676681
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
677682
skip_deserialization: bool = False,
678683
) -> typing.Union[
684+
ApiResponseFor200,
679685
api_client.ApiResponseWithoutDeserialization,
680686
]: ...
681687

‎samples/openapi3/client/petstore/python/petstore_api/paths/fake/get.pyi‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -361,14 +361,14 @@ request_body_body = api_client.RequestBody(
361361

362362

363363
@dataclass
364-
class ApiResponseFor400(api_client.ApiResponse):
364+
class ApiResponseFor200(api_client.ApiResponse):
365365
response: urllib3.HTTPResponse
366366
body: schemas.Unset = schemas.unset
367367
headers: schemas.Unset = schemas.unset
368368

369369

370-
_response_for_400 = api_client.OpenApiResponse(
371-
response_cls=ApiResponseFor400,
370+
_response_for_200 = api_client.OpenApiResponse(
371+
response_cls=ApiResponseFor200,
372372
)
373373

374374

@@ -397,6 +397,7 @@ class BaseApi(api_client.Api):
397397
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
398398
skip_deserialization: typing_extensions.Literal[False] = False,
399399
) -> typing.Union[
400+
ApiResponseFor200,
400401
]: ...
401402

402403
@typing.overload
@@ -422,6 +423,7 @@ class BaseApi(api_client.Api):
422423
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
423424
skip_deserialization: bool = False,
424425
) -> typing.Union[
426+
ApiResponseFor200,
425427
api_client.ApiResponseWithoutDeserialization,
426428
]: ...
427429

@@ -521,6 +523,7 @@ class EnumParameters(BaseApi):
521523
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
522524
skip_deserialization: typing_extensions.Literal[False] = False,
523525
) -> typing.Union[
526+
ApiResponseFor200,
524527
]: ...
525528

526529
@typing.overload
@@ -546,6 +549,7 @@ class EnumParameters(BaseApi):
546549
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
547550
skip_deserialization: bool = False,
548551
) -> typing.Union[
552+
ApiResponseFor200,
549553
api_client.ApiResponseWithoutDeserialization,
550554
]: ...
551555

@@ -584,6 +588,7 @@ class ApiForget(BaseApi):
584588
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
585589
skip_deserialization: typing_extensions.Literal[False] = False,
586590
) -> typing.Union[
591+
ApiResponseFor200,
587592
]: ...
588593

589594
@typing.overload
@@ -609,6 +614,7 @@ class ApiForget(BaseApi):
609614
timeout: typing.Optional[typing.Union[int, typing.Tuple]] = None,
610615
skip_deserialization: bool = False,
611616
) -> typing.Union[
617+
ApiResponseFor200,
612618
api_client.ApiResponseWithoutDeserialization,
613619
]: ...
614620

0 commit comments

Comments
 (0)