Properly handle spaces in Enum keys. Fixes #198

Author: dbanty

CHANGELOG.md

@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.6.1 - 2020-09-26
+
+### Changes
+
+- Use httpx ^0.15.0 in generated clients
+
+### Fixes
+
+- Properly remove spaces from generated Enum keys (#198). Thanks @bowenwr!
+
 ## 0.6.0 - 2020-09-21
 
 ### Breaking Changes
@@ -30,22 +40,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - It's now possible to include custom headers and cookies in requests, as well as set a custom timeout. This can be done
   either by directly setting those parameters on a `Client` (e.g. `my_client.headers = {"Header": "Value"}`) or using
   a fluid api (e.g. `my_endpoint.sync(my_client.with_cookies({"MyCookie": "cookie"}).with_timeout(10.0))`).
-- Unsupported content types or no responses at all will no longer result in an endpoint being completely skipped. Instead, 
+- Unsupported content types or no responses at all will no longer result in an endpoint being completely skipped. Instead,
   only the `detailed` versions of the endpoint will be generated, where the resulting `Response.parsed` is always `None`.
   (#141)
 - Support for Python 3.6 (#137 & #154)
 - Support for enums with integer values
-  
+
 ### Changes
 
 - The format of any errors/warnings has been spaced out a bit.
 
 ## 0.5.5 - 2020-09-04
+
 ### Fixes
+
 - Improved trailing comma handling in endpoint generation (#178 & #179). Thanks @dtkav!
 - `Optional` is now properly imported for `nullable` fields (#177 & #180). Thanks @dtkav!
 
-
 ## 0.5.4 - 2020-08-29
 
 ### Additions

openapi_python_client/parser/properties.py

@@ -363,9 +363,8 @@ def values_from_list(values: List[ValueType]) -> Dict[str, ValueType]:
                 key = f"VALUE_{i}"
             if key in output:
                 raise ValueError(f"Duplicate key {key} in Enum")
-            sanitized_key = utils.fix_keywords(utils.sanitize(key))
+            sanitized_key = utils.snake_case(key).upper()
             output[sanitized_key] = utils.remove_string_escapes(value)
-
         return output
 
     def _validate_default(self, default: Any) -> str:

tests/test_openapi_parser/test_properties.py

@@ -430,7 +430,7 @@ def test_get_imports(self, mocker):
     def test_values_from_list(self):
         from openapi_python_client.parser.properties import EnumProperty
 
-        data = ["abc", "123", "a23", "1bc", 4, -3]
+        data = ["abc", "123", "a23", "1bc", 4, -3, "a Thing WIth spaces"]
 
         result = EnumProperty.values_from_list(data)
 
@@ -441,6 +441,7 @@ def test_values_from_list(self):
             "VALUE_3": "1bc",
             "VALUE_4": 4,
             "VALUE_NEGATIVE_3": -3,
+            "A_THING_WITH_SPACES": "a Thing WIth spaces",
         }
 
     def test_values_from_list_duplicate(self):