fix: ensure streams are always closed

Author: stainless-app[bot]

src/openai/_streaming.py

@@ -55,9 +55,10 @@ def __stream__(self) -> Iterator[_T]:
         process_data = self._client._process_response_data
         iterator = self._iter_events()
 
-        for sse in iterator:
-            if sse.data.startswith("[DONE]"):
-                break
+        try:
+            for sse in iterator:
+                if sse.data.startswith("[DONE]"):
+                    break
 
             # we have to special case the Assistants `thread.` events since we won't have an "event" key in the data
             if sse.event and sse.event.startswith("thread."):
@@ -96,8 +97,9 @@ def __stream__(self) -> Iterator[_T]:
 
                 yield process_data(data=data, cast_to=cast_to, response=response)
 
-        # As we might not fully consume the response stream, we need to close it explicitly
-        response.close()
+        finally:
+            # Ensure the response is closed even if the consumer doesn't read all data
+            response.close()
 
     def __enter__(self) -> Self:
         return self
@@ -156,9 +158,10 @@ async def __stream__(self) -> AsyncIterator[_T]:
         process_data = self._client._process_response_data
         iterator = self._iter_events()
 
-        async for sse in iterator:
-            if sse.data.startswith("[DONE]"):
-                break
+        try:
+            async for sse in iterator:
+                if sse.data.startswith("[DONE]"):
+                    break
 
             # we have to special case the Assistants `thread.` events since we won't have an "event" key in the data
             if sse.event and sse.event.startswith("thread."):
@@ -197,8 +200,9 @@ async def __stream__(self) -> AsyncIterator[_T]:
 
                 yield process_data(data=data, cast_to=cast_to, response=response)
 
-        # As we might not fully consume the response stream, we need to close it explicitly
-        await response.aclose()
+        finally:
+            # Ensure the response is closed even if the consumer doesn't read all data
+            await response.aclose()
 
     async def __aenter__(self) -> Self:
         return self