Skip to content

Fix recent_commits(limit=0) returning 1 commit instead of 0 #7334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etraut-openai merged 5 commits into from
Dec 1, 2025
Merged

Fix recent_commits(limit=0) returning 1 commit instead of 0 #7334

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8668ec5
Merge pull request #1 from openai/main
Towaiji Nov 26, 2025
504aea5
fix: recent_commits zero-limit behavior + UA override tests
Towaiji Nov 27, 2025
91ff773
restore recent_commits implementation before UA test changes
Towaiji Nov 27, 2025
38ca71b
undo changes to User-Agent and originator handling
Towaiji Nov 27, 2025
24ceaa4
fix(git): remove forced `-n 1` when limit=0 in recent_commits
Towaiji Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions codex-rs/core/src/git_info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,15 @@ pub async fn recent_commits(cwd: &Path, limit: usize) -> Vec<CommitLogEntry> {
}

let fmt = "%H%x1f%ct%x1f%s"; // <sha> <US> <commit_time> <US> <subject>
let n = limit.max(1).to_string();
let Some(log_out) =
run_git_command_with_timeout(&["log", "-n", &n, &format!("--pretty=format:{fmt}")], cwd)
.await
else {
let limit_arg = (limit > 0).then(|| limit.to_string());
let mut args: Vec<String> = vec!["log".to_string()];
if let Some(n) = &limit_arg {
args.push("-n".to_string());
args.push(n.clone());
}
args.push(format!("--pretty=format:{fmt}"));
let arg_refs: Vec<&str> = args.iter().map(String::as_str).collect();
let Some(log_out) = run_git_command_with_timeout(&arg_refs, cwd).await else {
return Vec::new();
};
if !log_out.status.success() {
Expand Down
Loading