Merge pull request #772 from daijh/fix-static-code-scan-issues

Fix static code scan issues

Author: taste1981

source/core/owt_base/LiveStreamIn.cpp

@@ -1083,6 +1083,10 @@ bool LiveStreamIn::parse_avcC(AVPacket *pkt) {
 
         int nals_buf_length = 128;
         uint8_t *nals_buf = (uint8_t *)malloc(nals_buf_length);
+        if (nals_buf == nullptr) {
+            ELOG_ERROR_T("OOM! Allocate size %d", nals_buf_length);
+            return false;
+        }
 
         int i, cnt, nalsize;
         const uint8_t *p = data;
@@ -1114,6 +1118,10 @@ bool LiveStreamIn::parse_avcC(AVPacket *pkt) {
 
                 nals_buf_length += nalsize + 4;
                 nals_buf = (uint8_t *)realloc(nals_buf, nals_buf_length);
+                if (nals_buf == nullptr) {
+                    ELOG_ERROR_T("OOM! Allocate size %d", nals_buf_length);
+                    return false;
+                }
             }
 
             nals_buf[nals_size] = 0;

source/core/owt_base/MsdkFrame.cpp

@@ -142,10 +142,15 @@ void MsdkFrame::sync(void)
 
     m_needSync = false;
 
-    if (!m_mainSession && !(m_mainSession = MsdkBase::get()->getMainSession())) {
-        ELOG_ERROR("Invalid main session!");
-
-        return;
+    if (!m_mainSession) {
+        MsdkBase *msdkBase = MsdkBase::get();
+        if (msdkBase)
+            m_mainSession = msdkBase->getMainSession();
+
+        if (!m_mainSession) {
+            ELOG_ERROR("Invalid main session!");
+            return;
+        }
     }
 
     sts = m_mainSession->SyncOperation(m_syncP, MFX_INFINITE);

source/core/owt_base/MsdkFrameDecoder.cpp

@@ -417,6 +417,12 @@ void MsdkFrameDecoder::updateBitstream(const Frame& frame)
         memset((void *)m_bitstream.get(), 0, sizeof(mfxBitstream));
 
         m_bitstream->Data         = (mfxU8 *)malloc(size);
+        if (m_bitstream->Data == nullptr) {
+            m_bitstream.reset();
+            ELOG_ERROR_T("OOM! Allocate size %d", size);
+            return;
+        }
+
         m_bitstream->MaxLength    = size;
         m_bitstream->DataOffset   = 0;
         m_bitstream->DataLength   = 0;
@@ -450,6 +456,12 @@ void MsdkFrameDecoder::updateBitstream(const Frame& frame)
                 );
 
         m_bitstream->Data         = (mfxU8 *)realloc(m_bitstream->Data, newSize);
+        if (m_bitstream->Data == nullptr) {
+            m_bitstream.reset();
+            ELOG_ERROR_T("OOM! Allocate size %d", newSize);
+            return;
+        }
+
         m_bitstream->MaxLength    = newSize;
     }
 

source/core/owt_base/MsdkFrameEncoder.cpp

@@ -512,7 +512,10 @@ class StreamEncoder : public FrameSource, public JobTimerListener
 #endif
 
 #if (MFX_VERSION >= 1025)
-        uint32_t MFE_timeout = MsdkBase::get()->getConfigMFETimeout();
+        uint32_t MFE_timeout = 0;
+        MsdkBase *msdkBase = MsdkBase::get();
+        if (msdkBase)
+            MFE_timeout = msdkBase->getConfigMFETimeout();
         if (MFE_timeout) {
             // MFX_EXTBUFF_MULTI_FRAME_PARAM
             m_encExtMultiFrameParam.reset(new mfxExtMultiFrameParam);