Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Commit a7829a2

Browse files
authored
Mark some function as private in documentation. (#137)
1 parent ad0755e commit a7829a2

File tree

6 files changed

+26
-9
lines changed

6 files changed

+26
-9
lines changed

src/sdk/conference/channel.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ export class ConferencePeerConnectionChannel extends EventDispatcher {
5454
* @desc Received a message from conference portal. Defined in client-server protocol.
5555
* @param {string} notification Notification type.
5656
* @param {object} message Message received.
57+
* @private
5758
*/
5859
onMessage(notification, message) {
5960
switch (notification) {

src/sdk/conference/client.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ export const ConferenceClient = function(config, signalingImpl) {
121121
* @desc Received a message from conference portal. Defined in client-server protocol.
122122
* @param {string} notification Notification type.
123123
* @param {object} data Data received.
124+
* @private
124125
*/
125126
function onSignalingMessage(notification, data) {
126127
if (notification === 'soac' || notification === 'progress') {

src/sdk/conference/error.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
/**
88
* @class ConferenceError
99
* @classDesc The ConferenceError object represents an error in conference mode.
10-
* @memberOf Oms.Conference
10+
* @memberOf Owt.Conference
1111
* @hideconstructor
1212
*/
1313
export class ConferenceError extends Error {

src/sdk/conference/streamutils.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import * as SubscriptionModule from './subscription.js';
1717
* @function extractBitrateMultiplier
1818
* @desc Extract bitrate multiplier from a string like "x0.2".
1919
* @return {Promise<Object, Error>} The float number after "x".
20-
* @private.
20+
* @private
2121
*/
2222
function extractBitrateMultiplier(input) {
2323
if (typeof input !== 'string' || !input.startsWith('x')) {
@@ -44,7 +44,7 @@ function sortResolutions(x, y) {
4444
/**
4545
* @function convertToPublicationSettings
4646
* @desc Convert mediaInfo received from server to PublicationSettings.
47-
* @private.
47+
* @private
4848
*/
4949
export function convertToPublicationSettings(mediaInfo) {
5050
let audio;
@@ -89,7 +89,7 @@ export function convertToPublicationSettings(mediaInfo) {
8989
/**
9090
* @function convertToSubscriptionCapabilities
9191
* @desc Convert mediaInfo received from server to SubscriptionCapabilities.
92-
* @private.
92+
* @private
9393
*/
9494
export function convertToSubscriptionCapabilities(mediaInfo) {
9595
let audio; let video;

src/sdk/p2p/error.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ export const errors = {
8888
* @function getErrorByCode
8989
* @desc Get error object by error code.
9090
* @param {string} errorCode Error code.
91-
* @return {Oms.P2P.Error} Error object
91+
* @return {Owt.P2P.Error} Error object
92+
* @private
9293
*/
9394
export function getErrorByCode(errorCode) {
9495
const codeErrorMap = {
@@ -115,7 +116,7 @@ export function getErrorByCode(errorCode) {
115116
/**
116117
* @class P2PError
117118
* @classDesc The P2PError object represents an error in P2P mode.
118-
* @memberOf Oms.P2P
119+
* @memberOf Owt.P2P
119120
* @hideconstructor
120121
*/
121122
export class P2PError extends Error {

src/sdk/p2p/peerconnection-channel.js

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ import * as SdpUtils from '../base/sdputils.js';
2020
/**
2121
* @class P2PPeerConnectionChannelEvent
2222
* @desc Event for Stream.
23-
* @private.
24-
*/
23+
* @memberOf Owt.P2P
24+
* @private
25+
* */
2526
export class P2PPeerConnectionChannelEvent extends Event {
2627
/* eslint-disable-next-line require-jsdoc */
2728
constructor(init) {
@@ -53,7 +54,8 @@ const sysInfo = Utils.sysInfo();
5354
/**
5455
* @class P2PPeerConnectionChannel
5556
* @desc A P2PPeerConnectionChannel handles all interactions between this endpoint and a remote endpoint.
56-
* @private.
57+
* @memberOf Owt.P2P
58+
* @private
5759
*/
5860
class P2PPeerConnectionChannel extends EventDispatcher {
5961
// |signaling| is an object has a method |sendSignalingMessage|.
@@ -96,6 +98,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
9698
/**
9799
* @function publish
98100
* @desc Publish a stream to the remote endpoint.
101+
* @private
99102
*/
100103
publish(stream) {
101104
if (!(stream instanceof StreamModule.LocalStream)) {
@@ -136,6 +139,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
136139
/**
137140
* @function send
138141
* @desc Send a message to the remote endpoint.
142+
* @private
139143
*/
140144
send(message) {
141145
if (!(typeof message === 'string')) {
@@ -176,6 +180,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
176180
/**
177181
* @function stop
178182
* @desc Stop the connection with remote endpoint.
183+
* @private
179184
*/
180185
stop() {
181186
this._stop(undefined, true);
@@ -184,6 +189,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
184189
/**
185190
* @function getStats
186191
* @desc Get stats for a specific MediaStream.
192+
* @private
187193
*/
188194
getStats(mediaStream) {
189195
if (this._pc) {
@@ -216,6 +222,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
216222
/**
217223
* @function onMessage
218224
* @desc This method is called by P2PClient when there is new signaling message arrived.
225+
* @private
219226
*/
220227
onMessage(message) {
221228
this._SignalingMesssageHandler(message);
@@ -267,6 +274,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
267274
/**
268275
* @function _tracksAddedHandler
269276
* @desc Handle track added event from remote side.
277+
* @private
270278
*/
271279
_tracksAddedHandler(ids) {
272280
// Currently, |ids| contains all track IDs of a MediaStream. Following algorithm also handles |ids| is a part of a MediaStream's tracks.
@@ -324,6 +332,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
324332
/**
325333
* @function _tracksRemovedHandler
326334
* @desc Handle track removed event from remote side.
335+
* @private
327336
*/
328337
_tracksRemovedHandler(ids) {
329338
// Currently, |ids| contains all track IDs of a MediaStream. Following algorithm also handles |ids| is a part of a MediaStream's tracks.
@@ -342,6 +351,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
342351
/**
343352
* @function _dataReceivedHandler
344353
* @desc Handle data received event from remote side.
354+
* @private
345355
*/
346356
_dataReceivedHandler(id) {
347357
if (!this._sendDataPromises.has(id)) {
@@ -355,6 +365,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
355365
/**
356366
* @function _sdpHandler
357367
* @desc Handle SDP received event from remote side.
368+
* @private
358369
*/
359370
_sdpHandler(sdp) {
360371
if (sdp.type === 'offer') {
@@ -369,6 +380,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
369380
/**
370381
* @function _trackSourcesHandler
371382
* @desc Received track source information from remote side.
383+
* @private
372384
*/
373385
_trackSourcesHandler(data) {
374386
for (const info of data) {
@@ -379,6 +391,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
379391
/**
380392
* @function _streamInfoHandler
381393
* @desc Received stream information from remote side.
394+
* @private
382395
*/
383396
_streamInfoHandler(data) {
384397
if (!data) {
@@ -397,6 +410,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
397410
/**
398411
* @function _chatClosedHandler
399412
* @desc Received chat closed event from remote side.
413+
* @private
400414
*/
401415
_chatClosedHandler(data) {
402416
this._disposed = true;

0 commit comments

Comments
 (0)