{method} only if 404

Author: krnr

instrumentation/opentelemetry-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py

@@ -247,11 +247,15 @@ def get_default_span_name(request: web.Request) -> str:
     path = request.path.strip()
     try:
         resource = request.match_info.route.resource
-        if resource:
-            path = resource.canonical
-    except AttributeError:
-        pass
-    return f"{request.method} {path}"
+        assert resource
+        path = resource.canonical
+    except (AttributeError, AssertionError):
+        path = ""
+
+    if path:
+        return f"{request.method} {path}"
+    else:
+        return f"{request.method}"
 
 
 def _get_view_func(request: web.Request) -> str:

instrumentation/opentelemetry-instrumentation-aiohttp-server/tests/test_aiohttp_server_integration.py

@@ -197,6 +197,13 @@ async def test_status_code_instrumentation(
                 "/object/234/action/baz",
             ),
         ),
+        (
+            "GET",
+            (
+                "/i/dont/exist",
+                "/me-neither",
+            ),
+        ),
     ],
 )
 async def test_url_params_instrumentation(