Skip to content

Commit 3954336

Browse files
committed
Update stringRepresentation test expectations for JUnit 5.14.1
JUnit 5.14.1 fixes a test discovery bug where package-private test methods inherited from superclasses in different packages were not being discovered. This caused only 1 of 31 tests to run in these test classes on main branch. The stringRepresentation() tests had outdated expectations since commit f720735 (June 2025) which changed HttpExporterBuilder.toString() format, but the failures were masked by the JUnit bug. Fixed by: - Updating field order to match actual toString() output - Replacing removed fields (exporterName, type) with new fields (exporterType, componentLoader, internalTelemetrySchemaVersion) - Using flexible regex for memoryMode (IMMUTABLE_DATA|REUSABLE_DATA) See: https://docs.junit.org/5.14.1/release-notes/#release-notes-5.14.1-junit-jupiter-bug-fixes
1 parent edf3f02 commit 3954336

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

exporters/otlp/all/src/testDefaultSender/java/io/opentelemetry/exporter/otlp/http/metrics/OtlpHttpMetricExporterOkHttpSenderTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@ void stringRepresentation() {
8686
assertThat(metricExporter.toString())
8787
.matches(
8888
"OtlpHttpMetricExporter\\{"
89-
+ "exporterType=OTLP_HTTP_METRIC_EXPORTER, "
90-
+ "componentLoader=.*"
91-
+ ", internalTelemetrySchemaVersion=LEGACY, "
9289
+ "endpoint=http://localhost:4318/v1/metrics, "
9390
+ "timeoutNanos="
9491
+ TimeUnit.SECONDS.toNanos(10)
@@ -101,9 +98,12 @@ void stringRepresentation() {
10198
+ "exportAsJson=false, "
10299
+ "headers=Headers\\{User-Agent=OBFUSCATED\\}, "
103100
+ "retryPolicy=RetryPolicy\\{.*\\}, "
101+
+ "componentLoader=.*, "
102+
+ "exporterType=OTLP_HTTP_METRIC_EXPORTER, "
103+
+ "internalTelemetrySchemaVersion=LEGACY, "
104104
+ "aggregationTemporalitySelector=AggregationTemporalitySelector\\{.*\\}, "
105105
+ "defaultAggregationSelector=DefaultAggregationSelector\\{.*\\}, "
106-
+ "memoryMode=IMMUTABLE_DATA"
106+
+ "memoryMode=(IMMUTABLE_DATA|REUSABLE_DATA)"
107107
+ "\\}");
108108
}
109109
}

exporters/otlp/all/src/testDefaultSender/java/io/opentelemetry/exporter/otlp/http/trace/OtlpHttpSpanExporterOkHttpSenderTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,6 @@ void stringRepresentation() {
3535
assertThat(spanExporter.toString())
3636
.matches(
3737
"OtlpHttpSpanExporter\\{"
38-
+ "exporterType=OTLP_HTTP_SPAN_EXPORTER, "
39-
+ "componentLoader=.*"
40-
+ ", internalTelemetrySchemaVersion=LEGACY, "
4138
+ "endpoint=http://localhost:4318/v1/traces, "
4239
+ "timeoutNanos="
4340
+ TimeUnit.SECONDS.toNanos(10)
@@ -50,7 +47,10 @@ void stringRepresentation() {
5047
+ "exportAsJson=false, "
5148
+ "headers=Headers\\{User-Agent=OBFUSCATED\\}, "
5249
+ "retryPolicy=RetryPolicy\\{.*\\}, "
53-
+ "memoryMode=IMMUTABLE_DATA"
50+
+ "componentLoader=.*, "
51+
+ "exporterType=OTLP_HTTP_SPAN_EXPORTER, "
52+
+ "internalTelemetrySchemaVersion=LEGACY, "
53+
+ "memoryMode=(IMMUTABLE_DATA|REUSABLE_DATA)"
5454
+ "\\}");
5555
}
5656
}

exporters/otlp/all/src/testJdkHttpSender/java/io/opentelemetry/exporter/otlp/http/metrics/OtlpHttpMetricExporterJdkSenderTest.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,12 @@ void stringRepresentation() {
9999
+ "exportAsJson=false, "
100100
+ "headers=Headers\\{User-Agent=OBFUSCATED\\}, "
101101
+ "retryPolicy=RetryPolicy\\{.*\\}, "
102-
+ "componentLoader=.*"
103-
+ ", "
104-
+ "exporterType=OTLP_HTTP_METRIC_EXPORTER"
105-
+ ", "
106-
+ "internalTelemetrySchemaVersion=LEGACY"
107-
+ ", "
102+
+ "componentLoader=.*, "
103+
+ "exporterType=OTLP_HTTP_METRIC_EXPORTER, "
104+
+ "internalTelemetrySchemaVersion=LEGACY, "
108105
+ "aggregationTemporalitySelector=AggregationTemporalitySelector\\{.*\\}, "
109106
+ "defaultAggregationSelector=DefaultAggregationSelector\\{.*\\}, "
110-
+ "memoryMode=REUSABLE_DATA"
107+
+ "memoryMode=(IMMUTABLE_DATA|REUSABLE_DATA)"
111108
+ "\\}");
112109
}
113110
}

0 commit comments

Comments
 (0)