Skip to content

Commit 2b13219

Browse files
committed
Simplify memoryMode assertions to exact value
All builder classes hardcode DEFAULT_MEMORY_MODE = MemoryMode.REUSABLE_DATA, so the regex alternation (IMMUTABLE_DATA|REUSABLE_DATA) is unnecessary. Using the exact value makes the tests more precise.
1 parent f525ac5 commit 2b13219

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

exporters/otlp/all/src/testDefaultSender/java/io/opentelemetry/exporter/otlp/http/metrics/OtlpHttpMetricExporterOkHttpSenderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ void stringRepresentation() {
103103
+ "internalTelemetrySchemaVersion=LEGACY, "
104104
+ "aggregationTemporalitySelector=AggregationTemporalitySelector\\{.*\\}, "
105105
+ "defaultAggregationSelector=DefaultAggregationSelector\\{.*\\}, "
106-
+ "memoryMode=(IMMUTABLE_DATA|REUSABLE_DATA)"
106+
+ "memoryMode=REUSABLE_DATA"
107107
+ "\\}");
108108
}
109109
}

exporters/otlp/all/src/testDefaultSender/java/io/opentelemetry/exporter/otlp/http/trace/OtlpHttpSpanExporterOkHttpSenderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ void stringRepresentation() {
5050
+ "componentLoader=.*, "
5151
+ "exporterType=OTLP_HTTP_SPAN_EXPORTER, "
5252
+ "internalTelemetrySchemaVersion=LEGACY, "
53-
+ "memoryMode=(IMMUTABLE_DATA|REUSABLE_DATA)"
53+
+ "memoryMode=REUSABLE_DATA"
5454
+ "\\}");
5555
}
5656
}

exporters/otlp/all/src/testDefaultSender/java/io/opentelemetry/exporter/otlp/metrics/OtlpGrpcMetricExporterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ void stringRepresentation() {
103103
+ "internalTelemetrySchemaVersion=LEGACY, "
104104
+ "aggregationTemporalitySelector=AggregationTemporalitySelector\\{.*\\}, "
105105
+ "defaultAggregationSelector=DefaultAggregationSelector\\{.*\\}, "
106-
+ "memoryMode=(IMMUTABLE_DATA|REUSABLE_DATA)"
106+
+ "memoryMode=REUSABLE_DATA"
107107
+ "\\}");
108108
}
109109
}

exporters/otlp/all/src/testDefaultSender/java/io/opentelemetry/exporter/otlp/traces/OtlpGrpcSpanExporterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ void stringRepresentation() {
5050
+ "componentLoader=.*, "
5151
+ "exporterType=OTLP_GRPC_SPAN_EXPORTER, "
5252
+ "internalTelemetrySchemaVersion=LEGACY, "
53-
+ "memoryMode=(IMMUTABLE_DATA|REUSABLE_DATA)"
53+
+ "memoryMode=REUSABLE_DATA"
5454
+ "\\}");
5555
}
5656
}

exporters/otlp/all/src/testJdkHttpSender/java/io/opentelemetry/exporter/otlp/http/metrics/OtlpHttpMetricExporterJdkSenderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ void stringRepresentation() {
104104
+ "internalTelemetrySchemaVersion=LEGACY, "
105105
+ "aggregationTemporalitySelector=AggregationTemporalitySelector\\{.*\\}, "
106106
+ "defaultAggregationSelector=DefaultAggregationSelector\\{.*\\}, "
107-
+ "memoryMode=(IMMUTABLE_DATA|REUSABLE_DATA)"
107+
+ "memoryMode=REUSABLE_DATA"
108108
+ "\\}");
109109
}
110110
}

0 commit comments

Comments
 (0)