Skip to content

Commit 72df93d

Browse files
committed
pr review
1 parent e7b4370 commit 72df93d

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

instrumentation/spring/spring-boot-autoconfigure/src/test/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/properties/SpringConfigPropertiesTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ void mapObjectHeaders(String key) {
105105

106106
public static Stream<Arguments> listProperties() {
107107
return Stream.of(
108+
Arguments.of("otel.experimental.metrics.view.config", Arrays.asList("a", "b")),
108109
Arguments.of("otel.experimental.resource.disabled.keys", Arrays.asList("a", "b")),
109110
Arguments.of("otel.propagators", Arrays.asList("baggage", "b3")),
110111
Arguments.of("otel.logs.exporter", Collections.singletonList("console")),

instrumentation/spring/spring-boot-autoconfigure/src/test/resources/application.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
otel:
22
experimental:
3+
metrics:
4+
view:
5+
config: [ a,b ]
36
resource:
47
disabled:
58
keys: [ a,b ]

sdk-autoconfigure-support/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ group = "io.opentelemetry.instrumentation"
77

88
dependencies {
99
api("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
10-
api("io.opentelemetry:opentelemetry-sdk-extension-incubator")
10+
compileOnly("io.opentelemetry:opentelemetry-sdk-extension-incubator")
11+
testImplementation("io.opentelemetry:opentelemetry-sdk-extension-incubator")
1112

1213
compileOnly("com.google.code.findbugs:annotations")
1314
testCompileOnly("com.google.code.findbugs:annotations")

0 commit comments

Comments
 (0)