Skip to content

feat(repo): move pkg/instrumentation → contrib for better separation of core vs hooks #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
tushar1977 wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat(repo): move pkg/instrumentation → contrib for better separation of core vs hooks #175

tushar1977 wants to merge 9 commits into from

Conversation

@tushar1977
Copy link

@tushar1977 tushar1977 commented Nov 17, 2025

Issue - #133

Description

  • Moved pkg/instrumentation directory into a new top-level contrib/ directory.
  • Updated all import paths, references, embedding logic, and tooling to reflect the new location
  • Updated golangci-lint to use v2
  • Replace If statements to switch statments to avoid if ladder in tool/internal/setup/extract.go
  • Added local contrib replace directive in demo/http/server/go.mod and demo/http/client/go.mod

@tushar1977 tushar1977 requested a review from a team as a code owner November 17, 2025 11:26
@github-actions github-actions bot added the scope:feat A new feature being added label Nov 17, 2025
@tushar1977
Copy link
Author

tushar1977 commented Nov 17, 2025

@y1yang0 Please review the PR and suggest any changes if necessary

kakkoyun
kakkoyun requested changes Nov 17, 2025
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in a good direction. Thanks for the PR.

My comment is still valid #133 (comment)

@kakkoyun kakkoyun marked this pull request as draft November 17, 2025 12:12
@kakkoyun
Copy link
Member

kakkoyun commented Nov 17, 2025

@tushar1977 I have made the PR draft to prevent merges for now.

@tushar1977
Copy link
Author

tushar1977 commented Nov 17, 2025

@tushar1977 I have made the PR draft to prevent merges for now.

oh my bad. Sure you can put this in draft

@tushar1977
Copy link
Author

tushar1977 commented Dec 5, 2025

Hi @kakkoyun any status on HTTP and GRPC implementations that you were working on?

@kakkoyun
Copy link
Member

kakkoyun commented Dec 5, 2025

HTTP is close to getting merged. And gRPC is next week I hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

scope:feat A new feature being added

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tushar1977 @kakkoyun