Skip to content

Conversation

@kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Nov 12, 2025

Adds HTTP instrumentation.

Key changes

  • a8992f6 adds the net/http client and server implementation. It mimics the upstream opentelemetry-go-contrib
  • 6b4f804 Removes the existing abstractions around semantic conventions and instrumenter for a leaner approach with more flexibility.

Screenshots (from demo/insfrastructure/docker-compose:
Screenshot 2025-11-25 at 16 13 44

Screenshot 2025-11-25 at 16 13 57

@github-actions github-actions bot added the scope:feat A new feature being added label Nov 12, 2025
@kakkoyun kakkoyun force-pushed the kakkoyun/http-instrumentation branch 2 times, most recently from 037c54b to 61407d3 Compare November 12, 2025 14:36
@kakkoyun kakkoyun changed the title feat(pkg): implement HTTP server instrumentation feat(pkg): implement HTTP instrumentation Nov 12, 2025
@kakkoyun kakkoyun force-pushed the kakkoyun/http-instrumentation branch from 0a0aec7 to cb0abd0 Compare November 12, 2025 17:04
@kakkoyun kakkoyun changed the title feat(pkg): implement HTTP instrumentation feat(instrumentation): implement HTTP instrumentation Nov 12, 2025
@kakkoyun kakkoyun changed the title feat(instrumentation): implement HTTP instrumentation feat(instrumentation): Add HTTP instrumentation Nov 12, 2025
@kakkoyun kakkoyun force-pushed the kakkoyun/http-instrumentation branch 2 times, most recently from fde24be to d67fc1a Compare November 24, 2025 15:54
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

📊 Semantic Convention Registry Update Check

Current Project Version: v1.37.0 (from .semconv-version)

ℹ️ This is a non-blocking informational check that shows what semantic convention updates are available. It helps you stay informed about new conventions without requiring immediate action.

🆕 Available Updates

Comparing latest (main branch) vs v1.37.0 (current)

💡 New semantic conventions are available. Consider updating if these changes are relevant to your instrumentation:

📋 View available updates

Summary of Schema Changes

Registry versions

Baseline: unversioned

Head: unversioned

Registry Attributes

Added

  • app.screen.id
  • app.screen.name
  • gcp.apphub_destination.application.container
  • gcp.apphub_destination.application.id
  • gcp.apphub_destination.application.location
  • gcp.apphub_destination.service.criticality_type
  • gcp.apphub_destination.service.environment_type
  • gcp.apphub_destination.service.id
  • gcp.apphub_destination.workload.criticality_type
  • gcp.apphub_destination.workload.environment_type
  • gcp.apphub_destination.workload.id
  • gen_ai.embeddings.dimension.count
  • gen_ai.evaluation.explanation
  • gen_ai.evaluation.name
  • gen_ai.evaluation.score.label
  • gen_ai.evaluation.score.value
  • gen_ai.tool.call.arguments
  • gen_ai.tool.call.result
  • gen_ai.tool.definitions
  • k8s.pod.hostname
  • k8s.pod.ip
  • k8s.pod.start_time
  • k8s.pod.status.phase
  • k8s.pod.status.reason
  • nfs.operation.name
  • nfs.server.repcache.status
  • onc_rpc.procedure.name
  • onc_rpc.procedure.number
  • onc_rpc.program.name
  • onc_rpc.version
  • openshift.clusterquota.name
  • openshift.clusterquota.uid
  • otel.event.name
  • pprof.location.is_folded
  • pprof.mapping.has_filenames
  • pprof.mapping.has_functions
  • pprof.mapping.has_inline_frames
  • pprof.mapping.has_line_numbers
  • pprof.profile.comment
  • process.context_switch.type
  • process.state
  • rpc.response.status_code
  • system.memory.linux.slab.state
  • system.paging.fault.type

Renamed

  • system.cpu.logical_number --> cpu.logical_number (Note: Replaced by cpu.logical_number.)
  • process.context_switch_type --> process.context_switch.type (Note: Replaced by process.context_switch.type.)
  • system.paging.type --> system.paging.fault.type (Note: Replaced by system.paging.fault.type.)
  • rpc.connect_rpc.error_code --> rpc.response.status_code (Note: Replaced by rpc.response.status_code.)
  • process.paging.fault_type --> system.paging.fault.type (Note: Replaced by system.paging.fault.type.)
  • linux.memory.slab.state --> system.memory.linux.slab.state (Note: Replaced by system.memory.linux.slab.state.)
  • system.processes.status --> process.state (Note: Replaced by process.state.)
  • system.process.status --> process.state (Note: Replaced by process.state.)

Uncategorized

  • db.cosmosdb.status_code (Note: Use db.response.status_code instead.)
  • db.redis.database_index (Note: Uncategorized.)
  • enduser.role (Note: Use user.roles instead.)
  • event.name (Note: The value of this attribute MUST now be set as the value of the EventName field on the LogRecord to indicate that the LogRecord represents an Event.
    )
  • http.flavor (Note: Split into network.protocol.name and network.protocol.version)
  • messaging.kafka.destination.partition (Note: Record string representation of the partition id in messaging.destination.partition.id attribute.)
  • rpc.grpc.status_code (Note: Use string representation of the gRPC status code on the rpc.response.status_code attribute.)
  • rpc.jsonrpc.error_code (Note: Use string representation of the error code on the rpc.response.status_code attribute.)
  • rpc.jsonrpc.error_message (Note: Use the span status description or error.message attribute on other signals.)

Metrics

Added

  • container.memory.available
  • container.memory.paging.faults
  • container.memory.rss
  • container.memory.working_set
  • k8s.container.cpu.limit_utilization
  • k8s.container.cpu.request_utilization
  • k8s.cronjob.job.active
  • k8s.daemonset.node.current_scheduled
  • k8s.daemonset.node.desired_scheduled
  • k8s.daemonset.node.misscheduled
  • k8s.daemonset.node.ready
  • k8s.deployment.pod.available
  • k8s.deployment.pod.desired
  • k8s.hpa.pod.current
  • k8s.hpa.pod.desired
  • k8s.hpa.pod.max
  • k8s.hpa.pod.min
  • k8s.job.pod.active
  • k8s.job.pod.desired_successful
  • k8s.job.pod.failed
  • k8s.job.pod.max_parallel
  • k8s.job.pod.successful
  • k8s.node.cpu.allocatable
  • k8s.node.ephemeral_storage.allocatable
  • k8s.node.memory.allocatable
  • k8s.node.memory.available
  • k8s.node.memory.paging.faults
  • k8s.node.memory.rss
  • k8s.node.memory.working_set
  • k8s.node.pod.allocatable
  • k8s.pod.memory.available
  • k8s.pod.memory.paging.faults
  • k8s.pod.memory.rss
  • k8s.pod.memory.working_set
  • k8s.pod.status.phase
  • k8s.pod.status.reason
  • k8s.replicaset.pod.available
  • k8s.replicaset.pod.desired
  • k8s.replicationcontroller.pod.available
  • k8s.replicationcontroller.pod.desired
  • k8s.statefulset.pod.current
  • k8s.statefulset.pod.desired
  • k8s.statefulset.pod.ready
  • k8s.statefulset.pod.updated
  • nfs.client.net.count
  • nfs.client.net.tcp.connection.accepted
  • nfs.client.operation.count
  • nfs.client.procedure.count
  • nfs.client.rpc.authrefresh.count
  • nfs.client.rpc.count
  • nfs.client.rpc.retransmit.count
  • nfs.server.fh.stale.count
  • nfs.server.io
  • nfs.server.net.count
  • nfs.server.net.tcp.connection.accepted
  • nfs.server.operation.count
  • nfs.server.procedure.count
  • nfs.server.repcache.requests
  • nfs.server.rpc.count
  • nfs.server.thread.count
  • openshift.clusterquota.cpu.limit.hard
  • openshift.clusterquota.cpu.limit.used
  • openshift.clusterquota.cpu.request.hard
  • openshift.clusterquota.cpu.request.used
  • openshift.clusterquota.ephemeral_storage.limit.hard
  • openshift.clusterquota.ephemeral_storage.limit.used
  • openshift.clusterquota.ephemeral_storage.request.hard
  • openshift.clusterquota.ephemeral_storage.request.used
  • openshift.clusterquota.hugepage_count.request.hard
  • openshift.clusterquota.hugepage_count.request.used
  • openshift.clusterquota.memory.limit.hard
  • openshift.clusterquota.memory.limit.used
  • openshift.clusterquota.memory.request.hard
  • openshift.clusterquota.memory.request.used
  • openshift.clusterquota.object_count.hard
  • openshift.clusterquota.object_count.used
  • openshift.clusterquota.persistentvolumeclaim_count.hard
  • openshift.clusterquota.persistentvolumeclaim_count.used
  • openshift.clusterquota.storage.request.hard
  • openshift.clusterquota.storage.request.used
  • rpc.client.call.duration
  • rpc.server.call.duration
  • system.memory.linux.available
  • system.memory.linux.slab.usage
  • system.network.dropped
  • system.network.packets
  • v8js.memory.heap.space.available_size
  • v8js.memory.heap.space.physical_size

Renamed

  • k8s.hpa.max_pods --> k8s.hpa.pod.max (Note: Replaced by k8s.hpa.pod.max.)
  • k8s.cronjob.active_jobs --> k8s.cronjob.job.active (Note: Replaced by k8s.cronjob.job.active.)
  • system.linux.memory.available --> system.memory.linux.available (Note: Replaced by system.memory.linux.available.)
  • k8s.statefulset.updated_pods --> k8s.statefulset.pod.updated (Note: Replaced by k8s.statefulset.pod.updated.)
  • k8s.daemonset.current_scheduled_nodes --> k8s.daemonset.node.current_scheduled (Note: Replaced by k8s.daemonset.node.current_scheduled.)
  • k8s.statefulset.ready_pods --> k8s.statefulset.pod.ready (Note: Replaced by k8s.statefulset.pod.ready.)
  • k8s.job.successful_pods --> k8s.job.pod.successful (Note: Replaced by k8s.job.pod.successful.)
  • k8s.job.desired_successful_pods --> k8s.job.pod.desired_successful (Note: Replaced by k8s.job.pod.desired_successful.)
  • k8s.daemonset.ready_nodes --> k8s.daemonset.node.ready (Note: Replaced by k8s.daemonset.node.ready.)
  • k8s.statefulset.desired_pods --> k8s.statefulset.pod.desired (Note: Replaced by k8s.statefulset.pod.desired.)
  • k8s.node.allocatable.pods --> k8s.node.pod.allocatable (Note: Replaced by k8s.node.pod.allocatable.)
  • k8s.node.allocatable.cpu --> k8s.node.cpu.allocatable (Note: Replaced by k8s.node.cpu.allocatable.)
  • k8s.deployment.available_pods --> k8s.deployment.pod.available (Note: Replaced by k8s.deployment.pod.available.)
  • k8s.deployment.desired_pods --> k8s.deployment.pod.desired (Note: Replaced by k8s.deployment.pod.desired.)
  • k8s.node.allocatable.ephemeral_storage --> k8s.node.ephemeral_storage.allocatable (Note: Replaced by k8s.node.ephemeral_storage.allocatable.)
  • k8s.hpa.desired_pods --> k8s.hpa.pod.desired (Note: Replaced by k8s.hpa.pod.desired.)
  • k8s.hpa.min_pods --> k8s.hpa.pod.min (Note: Replaced by k8s.hpa.pod.min.)
  • system.linux.memory.slab.usage --> system.memory.linux.slab.usage (Note: Replaced by system.memory.linux.slab.usage.)
  • k8s.replicaset.available_pods --> k8s.replicaset.pod.available (Note: Replaced by k8s.replicaset.pod.available.)
  • k8s.hpa.current_pods --> k8s.hpa.pod.current (Note: Replaced by k8s.hpa.pod.current.)
  • v8js.heap.space.available_size --> v8js.memory.heap.space.available_size (Note: Replaced by v8js.memory.heap.space.available_size.)
  • k8s.job.max_parallel_pods --> k8s.job.pod.max_parallel (Note: Replaced by k8s.job.pod.max_parallel.)
  • k8s.replicationcontroller.available_pods --> k8s.replicationcontroller.pod.available (Note: Replaced by k8s.replicationcontroller.pod.available.)
  • k8s.daemonset.desired_scheduled_nodes --> k8s.daemonset.node.desired_scheduled (Note: Replaced by k8s.daemonset.node.desired_scheduled.)
  • k8s.job.failed_pods --> k8s.job.pod.failed (Note: Replaced by k8s.job.pod.failed.)
  • k8s.job.active_pods --> k8s.job.pod.active (Note: Replaced by k8s.job.pod.active.)
  • k8s.node.allocatable.memory --> k8s.node.memory.allocatable (Note: Replaced by k8s.node.memory.allocatable.)
  • k8s.replicationcontroller.desired_pods --> k8s.replicationcontroller.pod.desired (Note: Replaced by k8s.replicationcontroller.pod.desired.)
  • v8js.heap.space.physical_size --> v8js.memory.heap.space.physical_size (Note: Replaced by v8js.memory.heap.space.physical_size.)
  • k8s.daemonset.misscheduled_nodes --> k8s.daemonset.node.misscheduled (Note: Replaced by k8s.daemonset.node.misscheduled.)
  • k8s.replication_controller.available_pods --> k8s.replicationcontroller.pod.available (Note: Replaced by k8s.replicationcontroller.pod.available.)
  • k8s.replicaset.desired_pods --> k8s.replicaset.pod.desired (Note: Replaced by k8s.replicaset.pod.desired.)
  • k8s.replication_controller.desired_pods --> k8s.replicationcontroller.pod.desired (Note: Replaced by k8s.replicationcontroller.pod.desired.)
  • k8s.statefulset.current_pods --> k8s.statefulset.pod.current (Note: Replaced by k8s.statefulset.pod.current.)

Obsoleted

  • rpc.client.requests_per_rpc (Note: Removed, no replacement at this time.)
  • rpc.client.responses_per_rpc (Note: Removed, no replacement at this time.)
  • rpc.server.requests_per_rpc (Note: Removed, no replacement at this time.)
  • rpc.server.responses_per_rpc (Note: Removed, no replacement at this time.)

Uncategorized

  • rpc.client.duration (Note: Replaced by rpc.client.call.duration with unit s.)
  • rpc.server.duration (Note: Replaced by rpc.server.call.duration with unit s.)

Events

Added

  • gen_ai.evaluation.result

📝 What This Means

  • Non-blocking: This check will never fail your PR
  • Informational: Shows what's new in the semantic conventions
  • Optional: You can choose when to adopt new conventions

How to Update (if desired):

  1. Review the changes above to see if they're relevant to your use case
  2. Update Go imports in pkg/inst-api-semconv/ to the new semconv version
  3. Update the version in .semconv-version file
  4. Run make registry-check locally to validate

Generated by OTel Weaver • Run make semantic-conventions/diff locally for details

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 69.60352% with 276 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.22%. Comparing base (17338b7) to head (f612273).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/otelsetup/setup.go 0.00% 133 Missing ⚠️
pkg/instrumentation/nethttp/semconv/server.go 81.57% 28 Missing and 14 partials ⚠️
pkg/instrumentation/nethttp/semconv/client.go 79.29% 33 Missing and 8 partials ⚠️
...trumentation/helloworld/helloworld_instrumenter.go 0.00% 21 Missing ⚠️
pkg/instrumentation/nethttp/semconv/util.go 82.75% 6 Missing and 4 partials ⚠️
pkg/instrumentation/helloworld/helloworld_hook.go 0.00% 9 Missing ⚠️
tool/internal/setup/sync.go 80.00% 4 Missing and 4 partials ⚠️
tool/internal/instrument/instrument.go 78.57% 3 Missing and 3 partials ⚠️
pkg/instrumentation/nethttp/server/server_hook.go 93.84% 2 Missing and 2 partials ⚠️
pkg/instrumentation/nethttp/client/client_hook.go 97.05% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main     #156       +/-   ##
=========================================
+ Coverage      0   51.22%   +51.22%     
=========================================
  Files         0       48       +48     
  Lines         0     3274     +3274     
=========================================
+ Hits          0     1677     +1677     
- Misses        0     1477     +1477     
- Partials      0      120      +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kakkoyun kakkoyun force-pushed the kakkoyun/http-instrumentation branch 11 times, most recently from 8d48629 to 034ad5b Compare November 25, 2025 16:54
@kakkoyun kakkoyun marked this pull request as ready for review November 25, 2025 16:55
@kakkoyun kakkoyun requested a review from a team as a code owner November 25, 2025 16:55
@kakkoyun
Copy link
Member Author

I don't understand why typos check fails on that???! 😫

@pdelewski
Copy link
Member

@kakkoyun Overall, LGTM and I like the direction.

Since many things have been simplified and several abstractions removed, the document
https://github.com/open-telemetry/opentelemetry-go-compile-instrumentation/blob/main/docs/api-design-and-project-structure.md

has become outdated. Do you plan to update it as part of this PR, or will that be done afterward?

@kakkoyun
Copy link
Member Author

kakkoyun commented Dec 4, 2025

has become outdated. Do you plan to update it as part of this PR, or will that be done afterward?

I'll update it in this PR. Thanks for pointing it out.

@kakkoyun
Copy link
Member Author

kakkoyun commented Dec 4, 2025

has become outdated. Do you plan to update it as part of this PR, or will that be done afterward?

I'll update it in this PR. Thanks for pointing it out.

@pdelewski 6c7db5f

@kakkoyun kakkoyun force-pushed the kakkoyun/http-instrumentation branch from 6c7db5f to a49c0f2 Compare December 4, 2025 11:55
…n with updated semconv

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
@kakkoyun kakkoyun force-pushed the kakkoyun/http-instrumentation branch 2 times, most recently from 34ab0d4 to a1c128a Compare December 5, 2025 12:21
@kakkoyun kakkoyun requested review from pdelewski and y1yang0 December 5, 2025 12:23
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
… comments

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>

test: Add more regression tests

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>

chore: Address review comments

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>

chore: Add OTel auto-discover and change the module structure

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>

chore: Apply suggestions from code review

Co-authored-by: Przemyslaw Delewski <102958445+pdelewski@users.noreply.github.com>

chore: Address review comments

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>

docs: Update the design document after the changes

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
…to match existing NodeJS auto-instrumentation and improve tests

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
@pdelewski
Copy link
Member

LGTM, Let's merge it.

@pdelewski pdelewski merged commit 947df23 into open-telemetry:main Dec 7, 2025
41 checks passed
@kakkoyun kakkoyun deleted the kakkoyun/http-instrumentation branch December 8, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:feat A new feature being added

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants