-
Notifications
You must be signed in to change notification settings - Fork 22
feat(instrumentation): Add HTTP instrumentation #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation): Add HTTP instrumentation #156
Conversation
037c54b to
61407d3
Compare
0a0aec7 to
cb0abd0
Compare
fde24be to
d67fc1a
Compare
📊 Semantic Convention Registry Update CheckCurrent Project Version:
🆕 Available UpdatesComparing latest (main branch) vs v1.37.0 (current) 💡 New semantic conventions are available. Consider updating if these changes are relevant to your instrumentation: 📋 View available updatesSummary of Schema ChangesRegistry versionsBaseline: unversioned Head: unversioned Registry AttributesAdded
Renamed
Uncategorized
MetricsAdded
Renamed
Obsoleted
Uncategorized
EventsAdded
📝 What This Means
How to Update (if desired):
Generated by OTel Weaver • Run |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=========================================
+ Coverage 0 51.22% +51.22%
=========================================
Files 0 48 +48
Lines 0 3274 +3274
=========================================
+ Hits 0 1677 +1677
- Misses 0 1477 +1477
- Partials 0 120 +120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8d48629 to
034ad5b
Compare
|
I don't understand why |
|
@kakkoyun Overall, LGTM and I like the direction. Since many things have been simplified and several abstractions removed, the document has become outdated. Do you plan to update it as part of this PR, or will that be done afterward? |
I'll update it in this PR. Thanks for pointing it out. |
|
6c7db5f to
a49c0f2
Compare
…n with updated semconv Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
34ab0d4 to
a1c128a
Compare
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
… comments Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com> test: Add more regression tests Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com> chore: Address review comments Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com> chore: Add OTel auto-discover and change the module structure Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com> chore: Apply suggestions from code review Co-authored-by: Przemyslaw Delewski <102958445+pdelewski@users.noreply.github.com> chore: Address review comments Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com> docs: Update the design document after the changes Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
…to match existing NodeJS auto-instrumentation and improve tests Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
a1c128a to
fba1e46
Compare
|
LGTM, Let's merge it. |
Adds HTTP instrumentation.
Key changes
net/httpclient and server implementation. It mimics the upstreamopentelemetry-go-contribScreenshots (from

demo/insfrastructure/docker-compose: