Merge pull request #5 from oslabs-beta/james/test/tree-files

James/test/tree files

Author: jemzir

src/backend/__tests__/helpers.test.ts

@@ -54,6 +54,9 @@ describe('AST Unit Tests', () => {
     });
   });
 
+
+
+  // test notes 
   describe('getHooksNames', () => {
     it('Should return object with one getter/setter for a single useState instance', () => {
       const elementType = `function SingleUseFakeComponent() { 

src/backend/__tests__/timeJump.test.ts

@@ -65,7 +65,8 @@ describe('unit testing for timeJump.ts', () => {
     timeJump = timeJumpRequire(mode);
   });
   test('calling the initial require should return a function', () => {
-    expect(typeof timeJumpRequire).toBe('function');
+    const funcDef = timeJumpRequire;
+    expect(typeof funcDef).toBe('function');
   });
 
   // xdescribe('testing iteration through snapshot tree', () => {

src/backend/__tests__/tree.test.ts

@@ -1,100 +1,98 @@
 import Tree from '../tree';
-import { networkInterfaces } from 'os';
 
 describe('Tree unit test', () => {
-  describe('Constructor', () => {
-    let newTree = new Tree({});
+  const newTree = new Tree({});
 
+  describe('Constructor', () => {
     it('should be able to create a newTree', () => {
       expect(newTree.state).toEqual({});
-    })
+    });
 
-    it('should have 5 properties', () => {
+    it('should have 8 properties', () => {
       expect(newTree).toHaveProperty('state');
       expect(newTree).toHaveProperty('name');
       expect(newTree).toHaveProperty('componentData');
       expect(newTree).toHaveProperty('children');
       expect(newTree).toHaveProperty('parent');
-    })
+      expect(newTree).toHaveProperty('isExpanded');
+      expect(newTree).toHaveProperty('rtid');
+      expect(newTree).toHaveProperty('route');
+    });
 
     it('has name default value as stateless', () => {
       expect(newTree.name).toBe('nameless');
-    })
+    });
 
     it('has children as an empty array', () => {
       expect(newTree.children).toEqual([]);
-    })
-  })
-
+    });
+  });
+
+  /**
+   *
+   * making sure to adhere to ts practices when goign through tests
+   *
+   * ^^
+   * the tree should have initial values of state,
+   * name, etc to be default as per newly created tree
+   * update the add child and add sibling tests
+   *
+   * update the clean tree copy test to make it test for deep equaltiy? (note:
+   * this test may always fail if we make it so because there is no way to have deep equalituy
+   * with some shit that isn't allowed)
+   */
 
   describe('Adding children', () => {
-    let newTree = new Tree({});
-    let returnChild = newTree.addChild('stateful', 'child', {}, null);
-  
-    it('should be able to add a child', () => {
-      expect(typeof newTree.children).toEqual('object');
-      expect(Array.isArray(newTree.children)).toBeTruthy;
-    })
-
-    it(`its parent should be newTree`, () => {
+    const returnChild = newTree.addChild('stateful', 'child', {}, null);
+
+    it('should have the child be in the children\'s array property', () => {
+      // check if returnChild is in the children array property of tree that invoked addChild
+      expect(newTree.children).toContain(returnChild);
+    });
+
+    it('should have the object that invoked it be it\'s parent', () => {
+      // checking parent to be the tree that invoked addChild
       expect(returnChild.parent).toEqual(newTree);
-    })
+    });
 
     it('parent now contains an array of children and each children is a valid tree', () => {
       expect(newTree.children[0]).toHaveProperty('state');
       expect(newTree.children[0]).toHaveProperty('name');
       expect(newTree.children[0]).toHaveProperty('componentData');
-    })
-  })
+    });
+  });
 
   describe('Adding sibling', () => {
-    let newTree = new Tree({});
-    let returnChild = newTree.addChild('stateful', 'child', {}, null);
-    let returnSibling = returnChild.addSibling('stateful', 'child', {}, null);
-
-    it('the tree now has 2 children', () => {
-      expect(newTree.children.length).toBe(2);
-    })
-
-    it('both of the children has the parent as this tree', () => {
-      expect(newTree.children[0]).toEqual(returnChild);
-      expect(newTree.children[1]).toEqual(returnSibling);
-    })
+    // const newTree = new Tree({});
+    const returnChild = newTree.addChild('stateful', 'child', {}, null);
+    const returnSibling = returnChild.addSibling('stateful', 'child', {}, null);
 
-    it('both of the children has the parent as this tree', () => {
-      expect(returnChild.parent).toEqual(newTree);
-      expect(returnSibling.parent).toEqual(newTree);
-    })  
-  })
-
-
-  describe('Adding sibling', () => {
-    let newTree = new Tree({});
-    let returnChild = newTree.addChild('stateful', 'child', {}, null);
-    let returnSibling = returnChild.addSibling('stateful', 'child', {}, null);
     it('the tree now has 2 children', () => {
       expect(newTree.children.length).toBe(2);
-    })
+    });
 
     it('both of the children has the parent as this tree', () => {
       expect(newTree.children[0]).toEqual(returnChild);
       expect(newTree.children[1]).toEqual(returnSibling);
-    })
+    });
 
     it('both of the children has the parent as this tree', () => {
       expect(returnChild.parent).toEqual(newTree);
       expect(returnSibling.parent).toEqual(newTree);
-    })  
-  })
+    });
+  });
 
+  // review this test
+  // returnSibling not used?
+  // Check Test
 
   describe('Copy & clean tree', () => {
-    let newTree = new Tree({});
-    let returnChild = newTree.addChild('stateful', 'child', {}, null);
-    let returnSibling = returnChild.addSibling('stateful', 'child', {}, null);
-    let copy = newTree.cleanTreeCopy();
+    // const newTree = new Tree({});
+    const returnChild = newTree.addChild('stateful', 'child', {}, null);
+    returnChild.addSibling('stateful', 'child', {}, null);
+    const copy = newTree.cleanTreeCopy();
     it('its copy has 2 children', () => {
       expect(copy.children.length).toEqual(2);
-    })
-  })
-})
+    });
+  });
+});

src/backend/linkFiber.ts

@@ -200,6 +200,7 @@ function createTree(
 // }
 
 // check to see if we can get the information we were looking for
+// need to figure out what tag is
   if (tag === 5) {
     try {
       if (memoizedProps.children && memoizedProps.children[0]?._owner?.memoizedProps !== undefined) {

src/backend/timeJump.ts

@@ -17,7 +17,6 @@ import routes from './routes';
  */
 
 /* eslint-disable no-param-reassign */
-
 import componentActionsRecord from './masterState';
 
 const circularComponentTable = new Set();