fix: remove guard for method.examples to allow schema.examples fallback

Author: shanejonas

src/ExamplePairings/ExamplePairings.tsx

@@ -1,6 +1,6 @@
 import React, { Component } from "react";
 import ExamplePairing from "../ExamplePairing/ExamplePairing";
-import { Typography, List, ListItem, ListItemText, Grid, MenuItem, Menu, withStyles } from "@material-ui/core";
+import { Typography, List, ListItem, ListItemText, Grid, MenuItem, Menu, withStyles, ExpansionPanelDetails } from "@material-ui/core";
 import { MethodObject, ExamplePairingObject, ContentDescriptorObject, ReferenceObject } from "@open-rpc/meta-schema";
 
 interface IProps {
@@ -26,10 +26,11 @@ const newExample: ExamplePairingObject = {
 };
 const getExamplesFromMethod = (method?: MethodObject): ExamplePairingObject[] => {
   if (!method) { return []; }
+  if (!method.params) { return []; }
   const examples: ExamplePairingObject[] = [];
 
   (method.params as ContentDescriptorObject[]).forEach((param, index: number) => {
-    if (param.schema.examples && param.schema.examples.length > 0) {
+    if (param.schema && param.schema.examples && param.schema.examples.length > 0) {
       param.schema.examples.forEach((ex: any, i: number) => {
         if (!examples[i]) {
           examples.push({ ...newExample });
@@ -92,48 +93,50 @@ class ExamplePairings extends Component<IProps, IState> {
       return null;
     }
     return (
-      <Grid container>
-        <Grid item xs={12}>
-          <Typography variant="h5">Examples</Typography>
+      <ExpansionPanelDetails key="examples">
+        <Grid container>
+          <Grid item xs={12}>
+            <Typography variant="h5">Examples</Typography>
+          </Grid>
+          <Grid item xs={12}>
+            <List component="nav">
+              <ListItem
+                button
+                aria-haspopup="true"
+                aria-controls="menu-menu"
+                aria-label="Method Examples"
+                onClick={this.handleClickListItem}>
+                <ListItemText
+                  primary={examples[this.state.selectedIndex].name}
+                  secondary={examples[this.state.selectedIndex].summary} />
+              </ListItem>
+              <Menu
+                id="menu-menu"
+                anchorEl={anchorEl as HTMLElement}
+                open={Boolean(anchorEl)}
+                onClose={this.handleClose}
+              >
+                {examples.map((example, index) => (
+                  <MenuItem
+                    key={example.name}
+                    selected={index === this.state.selectedIndex}
+                    onClick={(event) => this.handleMenuItemClick(event, index)}
+                  >
+                    {example.name}
+                  </MenuItem>
+                ))}
+              </Menu>
+            </List>
+          </Grid>
+          <Grid item xs={12}>
+            {examples &&
+              <ExamplePairing
+                examplePairing={examples[this.state.selectedIndex]}
+                methodName={this.props.method && this.props.method.name}
+                reactJsonOptions={this.props.reactJsonOptions} />}
+          </Grid>
         </Grid>
-        <Grid item xs={12}>
-          <List component="nav">
-            <ListItem
-              button
-              aria-haspopup="true"
-              aria-controls="menu-menu"
-              aria-label="Method Examples"
-              onClick={this.handleClickListItem}>
-              <ListItemText
-                primary={examples[this.state.selectedIndex].name}
-                secondary={examples[this.state.selectedIndex].summary} />
-            </ListItem>
-            <Menu
-              id="menu-menu"
-              anchorEl={anchorEl as HTMLElement}
-              open={Boolean(anchorEl)}
-              onClose={this.handleClose}
-            >
-              {examples.map((example, index) => (
-                <MenuItem
-                  key={example.name}
-                  selected={index === this.state.selectedIndex}
-                  onClick={(event) => this.handleMenuItemClick(event, index)}
-                >
-                  {example.name}
-                </MenuItem>
-              ))}
-            </Menu>
-          </List>
-        </Grid>
-        <Grid item xs={12}>
-          {examples &&
-            <ExamplePairing
-              examplePairing={examples[this.state.selectedIndex]}
-              methodName={this.props.method && this.props.method.name}
-              reactJsonOptions={this.props.reactJsonOptions} />}
-        </Grid>
-      </Grid>
+      </ExpansionPanelDetails>
     );
   }
 }

src/Methods/Methods.tsx

@@ -69,7 +69,7 @@ class Methods extends Component<IProps> {
         {schema.methods.map((method, i) => (
           <ExpansionPanel
             key={i + method.name}
-            TransitionProps={{unmountOnExit: disableTransitionProps ? false : true}}
+            TransitionProps={{ unmountOnExit: disableTransitionProps ? false : true }}
             defaultExpanded={uiSchema && uiSchema.methods["ui:defaultExpanded"]}
           >
             <ExpansionPanelSummary expandIcon={<ExpandMoreIcon />}>
@@ -114,14 +114,10 @@ class Methods extends Component<IProps> {
                 <Errors errors={method.errors as ErrorObject[]} reactJsonOptions={this.props.reactJsonOptions} />
               </ExpansionPanelDetails>
             }
-            {method.examples && method.examples.length > 0 &&
-              <ExpansionPanelDetails key="examples">
-                <ExamplePairings
-                  examples={method.examples as ExamplePairingObject[]}
-                  method={method}
-                  reactJsonOptions={this.props.reactJsonOptions} />
-              </ExpansionPanelDetails>
-            }
+            <ExamplePairings
+              examples={method.examples as ExamplePairingObject[]}
+              method={method}
+              reactJsonOptions={this.props.reactJsonOptions} />
             {method.links && method.links.length > 0 &&
               <ExpansionPanelDetails key="links-title">
                 <Typography variant="h5">Links</Typography>